You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by mattunderscorechampion <gi...@git.apache.org> on 2014/11/17 13:40:05 UTC
[GitHub] incubator-brooklyn pull request: Added a predicate that can correc...
GitHub user mattunderscorechampion opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/338
Added a predicate that can correctly match the type of a spec
A new predicate has been added that correctly detect the format of the type passed to the BasicBrooklynCatalog.loadClassByType method and uses the correct predicate.
This fixes issue [BROOKLYN-89](https://issues.apache.org/jira/browse/BROOKLYN-89).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pushtechnology/incubator-brooklyn loadClassByTypeCatalogVersionException
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/338.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #338
----
commit fb296f47752611453fa0f53099572b0820546b39
Author: Matt Champion <ma...@gmail.com>
Date: 2014-11-17T10:29:49Z
Added a predicate that can correctly match the type of an application or entity spec.
This fixes issue BROOKLYN-89. The new predicate correctly handles the symbolic-name:version format of the type. The method BrooklynCatalog.loadClassByType(String, Class) is called either with either the symbolic-name or the symbolic-name:version format. It will detect the format it is passed and use the appropriate predicate.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Added a predicate that can correc...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/338
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Added a predicate that can correc...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/338#issuecomment-63308749
good fix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Added a predicate that can correc...
Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/338#issuecomment-63300781
Works fine :frog: Merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Added a predicate that can correc...
Posted by grkvlt <gi...@git.apache.org>.
Github user grkvlt commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/338#issuecomment-63299971
@mattunderscorechampion Thanks, this looks pretty much like what I was about to write! I'll give it a quich test and then hopefully it can be merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---