You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2023/01/03 15:57:11 UTC
[GitHub] [beam] damccorm opened a new pull request, #24866: WIP: Support passing in special pytest args
damccorm opened a new pull request, #24866:
URL: https://github.com/apache/beam/pull/24866
Not ready for review
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #24866: Shard Python PreCommit
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #24866:
URL: https://github.com/apache/beam/pull/24866#issuecomment-1376266037
Run Seed Job
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #24866: WIP: Support passing in special pytest args
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #24866:
URL: https://github.com/apache/beam/pull/24866#issuecomment-1370133025
Run Python PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #24866: WIP: Support passing in special pytest args
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #24866:
URL: https://github.com/apache/beam/pull/24866#issuecomment-1370263073
Run Python PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #24866: WIP: Support passing in special pytest args
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #24866:
URL: https://github.com/apache/beam/pull/24866#issuecomment-1369979665
# [Codecov](https://codecov.io/gh/apache/beam/pull/24866?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24866](https://codecov.io/gh/apache/beam/pull/24866?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (756c772) into [master](https://codecov.io/gh/apache/beam/commit/803bfa6e2b140a8031e288e2b0ef3e6b632ad4f2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (803bfa6) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #24866 +/- ##
=======================================
Coverage 73.11% 73.12%
=======================================
Files 731 731
Lines 97960 97960
=======================================
+ Hits 71628 71633 +5
+ Misses 24977 24972 -5
Partials 1355 1355
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `82.84% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/24866?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache\_beam/runners/interactive/dataproc/types.py](https://codecov.io/gh/apache/beam/pull/24866/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9kYXRhcHJvYy90eXBlcy5weQ==) | `93.10% <0.00%> (-3.45%)` | :arrow_down: |
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/24866/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `95.12% <0.00%> (-2.44%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/24866/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.54% <0.00%> (+0.12%)` | :arrow_up: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/24866/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.24% <0.00%> (+0.16%)` | :arrow_up: |
| [...eam/runners/portability/fn\_api\_runner/execution.py](https://codecov.io/gh/apache/beam/pull/24866/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9wb3J0YWJpbGl0eS9mbl9hcGlfcnVubmVyL2V4ZWN1dGlvbi5weQ==) | `93.13% <0.00%> (+0.63%)` | :arrow_up: |
| [.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/24866/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5) | `98.50% <0.00%> (+1.49%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #24866: WIP: Support passing in special pytest args
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #24866:
URL: https://github.com/apache/beam/pull/24866#issuecomment-1370096740
Run Seed Job
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #24866: Shard Python PreCommit
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #24866:
URL: https://github.com/apache/beam/pull/24866#issuecomment-1371131846
Run Python PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on pull request #24866: Shard Python PreCommit
Posted by GitBox <gi...@apache.org>.
Abacn commented on PR #24866:
URL: https://github.com/apache/beam/pull/24866#issuecomment-1379520978
@damccorm It appears to have another unexpected effect that is code coverage now misses much part of python code base: https://app.codecov.io/gh/apache/beam/tree/master/sdks/python/apache_beam
because the tox task used to report the codecov is [testenv:py38-cloudcoverage] now also have `--ignore` passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on a diff in pull request #24866: Shard Python PreCommit
Posted by GitBox <gi...@apache.org>.
Abacn commented on code in PR #24866:
URL: https://github.com/apache/beam/pull/24866#discussion_r1065043781
##########
sdks/python/scripts/run_pytest.sh:
##########
@@ -43,12 +48,7 @@ pytest -o junit_suite_name=${envname}_no_xdist \
--junitxml=pytest_${envname}_no_xdist.xml -m 'no_xdist' ${pytest_args} --pyargs ${posargs}
status2=$?
-# Exit with error if no tests were run in either suite (status code 5).
Review Comment:
Is removing this block intended?
##########
sdks/python/scripts/run_pytest.sh:
##########
@@ -35,6 +35,11 @@ if [[ $pytest_args =~ "-m" ]] || [[ $posargs =~ "-m" ]]; then
exit 1
fi
+# strip leading/trailing quotes from posargs because it can get double quoted as its passed through.
Review Comment:
Just curious, is the quotes the actual cause prevented `--ignore` to work https://github.com/apache/beam/pull/24204#discussion_r1058662550 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm merged pull request #24866: Shard Python PreCommit
Posted by GitBox <gi...@apache.org>.
damccorm merged PR #24866:
URL: https://github.com/apache/beam/pull/24866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on a diff in pull request #24866: Shard Python PreCommit
Posted by GitBox <gi...@apache.org>.
Abacn commented on code in PR #24866:
URL: https://github.com/apache/beam/pull/24866#discussion_r1061562614
##########
sdks/python/scripts/run_pytest.sh:
##########
@@ -35,20 +35,32 @@ if [[ $pytest_args =~ "-m" ]] || [[ $posargs =~ "-m" ]]; then
exit 1
fi
+pyargs=""
Review Comment:
Should this block be effective only when $3 is not exist (i.e. it is ambiguous whether $2 is pyargs or pytest_args). Otherwise there is no way to pass certain args to pyargs (currently there is only `--ignore` though)
and some comment is appreciative
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #24866: Shard Python PreCommit
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #24866:
URL: https://github.com/apache/beam/pull/24866#issuecomment-1371049406
Run Seed Job
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #24866: WIP: Support passing in special pytest args
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #24866:
URL: https://github.com/apache/beam/pull/24866#issuecomment-1370125302
Run Seed Job
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on a diff in pull request #24866: Shard Python PreCommit
Posted by GitBox <gi...@apache.org>.
Abacn commented on code in PR #24866:
URL: https://github.com/apache/beam/pull/24866#discussion_r1065065491
##########
sdks/python/scripts/run_pytest.sh:
##########
@@ -43,12 +48,7 @@ pytest -o junit_suite_name=${envname}_no_xdist \
--junitxml=pytest_${envname}_no_xdist.xml -m 'no_xdist' ${pytest_args} --pyargs ${posargs}
status2=$?
-# Exit with error if no tests were run in either suite (status code 5).
Review Comment:
To me like with current change there isn't a test suite hitting `$status1 == 5 && $status2 == 5` still, is that wrong? Still sounds not good to me to ignore not test running. I had experiences on running some local tests but did not feed the test with needed args and triggered `@ignore`. Currently I get warned by this clause.
If there is a test job that hitting this clause, one can fix that special case by sth like `sh run_pytest.sh ... || [[ $? == 5 ]] `to allow return code 5
##########
sdks/python/scripts/run_pytest.sh:
##########
@@ -43,12 +48,7 @@ pytest -o junit_suite_name=${envname}_no_xdist \
--junitxml=pytest_${envname}_no_xdist.xml -m 'no_xdist' ${pytest_args} --pyargs ${posargs}
status2=$?
-# Exit with error if no tests were run in either suite (status code 5).
Review Comment:
Looks like with current change there isn't a test suite hitting `$status1 == 5 && $status2 == 5` still, is that wrong? Still sounds not good to me to ignore not test running. I had experiences on running some local tests but did not feed the test with needed args and triggered `@ignore`. Currently I get warned by this clause.
If there is a test job that hitting this clause, one can fix that special case by sth like `sh run_pytest.sh ... || [[ $? == 5 ]] `to allow return code 5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #24866: WIP: Support passing in special pytest args
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #24866:
URL: https://github.com/apache/beam/pull/24866#issuecomment-1370207895
Run Seed Job
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #24866: WIP: Support passing in special pytest args
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #24866:
URL: https://github.com/apache/beam/pull/24866#issuecomment-1370255536
Run Seed Job
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #24866: Shard Python PreCommit
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #24866:
URL: https://github.com/apache/beam/pull/24866#issuecomment-1371060632
Run Python PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #24866: WIP: Support passing in special pytest args
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #24866:
URL: https://github.com/apache/beam/pull/24866#issuecomment-1370281137
Run Python PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #24866: WIP: Support passing in special pytest args
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #24866:
URL: https://github.com/apache/beam/pull/24866#issuecomment-1370349265
Run Seed Job
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #24866: Shard Python PreCommit
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #24866:
URL: https://github.com/apache/beam/pull/24866#issuecomment-1376276774
Run Python PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #24866: Shard Python PreCommit
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #24866:
URL: https://github.com/apache/beam/pull/24866#discussion_r1065070166
##########
sdks/python/scripts/run_pytest.sh:
##########
@@ -43,12 +48,7 @@ pytest -o junit_suite_name=${envname}_no_xdist \
--junitxml=pytest_${envname}_no_xdist.xml -m 'no_xdist' ${pytest_args} --pyargs ${posargs}
status2=$?
-# Exit with error if no tests were run in either suite (status code 5).
Review Comment:
Yeah, that's fair. I'll see if I can add it back in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #24866: Shard Python PreCommit
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #24866:
URL: https://github.com/apache/beam/pull/24866#discussion_r1065122612
##########
sdks/python/scripts/run_pytest.sh:
##########
@@ -43,12 +48,7 @@ pytest -o junit_suite_name=${envname}_no_xdist \
--junitxml=pytest_${envname}_no_xdist.xml -m 'no_xdist' ${pytest_args} --pyargs ${posargs}
status2=$?
-# Exit with error if no tests were run in either suite (status code 5).
Review Comment:
Looks like this indeed worked, thanks for pushing on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #24866: Shard Python PreCommit
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #24866:
URL: https://github.com/apache/beam/pull/24866#discussion_r1065054029
##########
sdks/python/scripts/run_pytest.sh:
##########
@@ -43,12 +48,7 @@ pytest -o junit_suite_name=${envname}_no_xdist \
--junitxml=pytest_${envname}_no_xdist.xml -m 'no_xdist' ${pytest_args} --pyargs ${posargs}
status2=$?
-# Exit with error if no tests were run in either suite (status code 5).
Review Comment:
Yes (and I also intentionally slightly ammended the comment below) - since some environments may not have tests in every directory and we're now only running tests on certain directories at a given time, we need to be tolerant of empty pytest invocations.
The original motivating example was `dataframes` tests, but I think we can still run into this with other environments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #24866: Shard Python PreCommit
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24866:
URL: https://github.com/apache/beam/pull/24866#issuecomment-1370968956
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @jrmccluskey for label python.
R: @Abacn for label build.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #24866: Shard Python PreCommit
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #24866:
URL: https://github.com/apache/beam/pull/24866#discussion_r1061750873
##########
sdks/python/scripts/run_pytest.sh:
##########
@@ -35,20 +35,32 @@ if [[ $pytest_args =~ "-m" ]] || [[ $posargs =~ "-m" ]]; then
exit 1
fi
+pyargs=""
Review Comment:
Ok, this block is dramatically simplified now, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #24866: WIP: Support passing in special pytest args
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #24866:
URL: https://github.com/apache/beam/pull/24866#issuecomment-1370209171
Run Seed Job
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #24866: WIP: Support passing in special pytest args
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #24866:
URL: https://github.com/apache/beam/pull/24866#issuecomment-1370355940
Run Python_Runners PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #24866: WIP: Support passing in special pytest args
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #24866:
URL: https://github.com/apache/beam/pull/24866#issuecomment-1370356083
Run Python_Transforms PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #24866: WIP: Support passing in special pytest args
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #24866:
URL: https://github.com/apache/beam/pull/24866#issuecomment-1370355635
Run Python PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #24866: WIP: Support passing in special pytest args
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #24866:
URL: https://github.com/apache/beam/pull/24866#issuecomment-1370215544
Run Python PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #24866: Shard Python PreCommit
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #24866:
URL: https://github.com/apache/beam/pull/24866#discussion_r1061579937
##########
sdks/python/scripts/run_pytest.sh:
##########
@@ -35,20 +35,32 @@ if [[ $pytest_args =~ "-m" ]] || [[ $posargs =~ "-m" ]]; then
exit 1
fi
+pyargs=""
Review Comment:
Taking another look, I think I actually just overcomplicated this by trying to maintain the existing structure - I probably just need to strip the leading/trailing quotes from posargs and that should be good enough (posargs gets double quoted which causes some problems parsing the args).
Let me try that and I'll reping here once I have it cleaned up (unfortunately, the double quoting comes from the interaction with jenkins so its hard to test locally).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #24866: WIP: Support passing in special pytest args
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #24866:
URL: https://github.com/apache/beam/pull/24866#issuecomment-1370272422
Run Seed Job
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #24866: Shard Python PreCommit
Posted by GitBox <gi...@apache.org>.
damccorm commented on PR #24866:
URL: https://github.com/apache/beam/pull/24866#issuecomment-1371120137
Run Seed Job
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #24866: Shard Python PreCommit
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #24866:
URL: https://github.com/apache/beam/pull/24866#discussion_r1065048667
##########
sdks/python/scripts/run_pytest.sh:
##########
@@ -35,6 +35,11 @@ if [[ $pytest_args =~ "-m" ]] || [[ $posargs =~ "-m" ]]; then
exit 1
fi
+# strip leading/trailing quotes from posargs because it can get double quoted as its passed through.
Review Comment:
Yeah - it tried to parse `'--ignore=apache_beam/coders` as an argument instead of the `ignore` flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org