You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stratos.apache.org by Swapnil Patil <sw...@gmail.com> on 2015/07/24 15:19:18 UTC
Code Review meeting - AWS Load Balancing Support for Stratos
Hi All,
I am planning to schedule a code review meeting for AWS extension on Monday
at 1 pm.
Please feel free to let me know if you want to reschedule it at different
time or a day?
Thanks and Regards,
Swapnil
Re: Code Review meeting - AWS Load Balancing Support for Stratos
Posted by Swapnil Patil <sw...@gmail.com>.
Thanks Imesh. I will send a pull request in the evening.
Thanks and Regards,
Swapnil
On Aug 18, 2015 9:47 AM, "Imesh Gunaratne" <im...@apache.org> wrote:
> It would be better to send a pull request Swapnil. It's easier to review
> the code there.
>
> On Sun, Aug 16, 2015 at 10:09 AM, Swapnil Patil <sw...@gmail.com>
> wrote:
>
>> Hi All,
>>
>> After the last code review meeting I have made code changes related to
>> automatic security group creation and getting in flight request count.
>>
>> Would someone like to review my code before I send a pull request to gsoc-projects-2015
>> branch.
>>
>> Thanks and Regards,
>> Swapnil
>>
>> On Tue, Aug 4, 2015 at 2:39 AM, Swapnil Patil <sw...@gmail.com>
>> wrote:
>>
>>> Hi All,
>>>
>>> I have made code changes suggested in last code review meeting and
>>> committed at my GitHub repo [1].
>>>
>>> Please feel free to let me know if I have missed anything.
>>>
>>> [1] https://github.com/swaprp15/stratos
>>>
>>> Thanks and Regards,
>>> Swapnil
>>> On Jul 29, 2015 5:05 PM, "Swapnil Patil" <sw...@gmail.com> wrote:
>>>
>>>> Thanks Thanuja!
>>>>
>>>> I also need to catch specific exception and log appropriate message.
>>>>
>>>> Thanks and Regards,
>>>> Swapnil
>>>> On Jul 29, 2015 4:11 PM, "Thanuja Uruththirakodeeswaran" <
>>>> thanujau@wso2.com> wrote:
>>>>
>>>>> Hi All,
>>>>>
>>>>> Please find the code review notes below:
>>>>>
>>>>> 1. Define used constant values as readable constant variables.
>>>>> 2. Include loadbalancer name length constant (32) in the exception
>>>>> message in AWSHelper class.
>>>>> 3. In AWSLoadBalancer avoid using "if(clusterMemberSize()==0)
>>>>> break;" and follow best coding practice.
>>>>> 4. Use datatype for the integer sequence in AWSLoadBalancer.
>>>>> 5. In AWSHelper, refactor setEndPoint method.
>>>>> 6. Pass exception as second arguement in log.error()
>>>>> 7. Don't declare method parameters as final in AWSHelper class.
>>>>> 8. In AWSLoadBalancer remove instance logic as it is not needed.
>>>>> 9. Add method comments.
>>>>>
>>>>> Thank you.
>>>>>
>>>>> On Wed, Jul 29, 2015 at 2:11 PM, Swapnil Patil <swapnil.rp15@gmail.com
>>>>> > wrote:
>>>>>
>>>>>> Hi All,
>>>>>>
>>>>>> I have started hangout. You can join in for code review.
>>>>>>
>>>>>> URL: https://plus.google.com/hangouts/_/g7jnhpysd3dxyyrqycerhd6iyua
>>>>>>
>>>>>> Thanks and Regards,
>>>>>> Swapnil
>>>>>>
>>>>>> On Mon, Jul 27, 2015 at 1:14 PM, Swapnil Patil <
>>>>>> swapnil.rp15@gmail.com> wrote:
>>>>>>
>>>>>>> Hi Imesh,
>>>>>>>
>>>>>>> Ok. No problem. We can have this on Wednesday 29th July at 2 PM IST.
>>>>>>>
>>>>>>> Thanks and Regards,
>>>>>>> Swapnil
>>>>>>> On Jul 27, 2015 5:02 PM, "Imesh Gunaratne" <im...@apache.org> wrote:
>>>>>>>
>>>>>>>> Hi Swapnil,
>>>>>>>>
>>>>>>>> I'm sorry I missed this, shall we have this on this Wednesday the
>>>>>>>> 29th July at 2 PM IST?
>>>>>>>>
>>>>>>>> Thanks
>>>>>>>>
>>>>>>>> On Mon, Jul 27, 2015 at 2:23 PM, Swapnil Patil <
>>>>>>>> swapnil.rp15@gmail.com> wrote:
>>>>>>>>
>>>>>>>>> It seems no one has joined yet. Shall we have it some other time?
>>>>>>>>>
>>>>>>>>> Thanks and Regards,
>>>>>>>>> Swapnil
>>>>>>>>>
>>>>>>>>> On Mon, Jul 27, 2015 at 8:28 AM, Swapnil Patil <
>>>>>>>>> swapnil.rp15@gmail.com> wrote:
>>>>>>>>>
>>>>>>>>>> Hi All,
>>>>>>>>>>
>>>>>>>>>> I have started a Google Hangout. You can join in for code review.
>>>>>>>>>>
>>>>>>>>>> Hangout URL:
>>>>>>>>>> https://plus.google.com/hangouts/_/guna2qyr7euqebsqk7lm42j6hia
>>>>>>>>>>
>>>>>>>>>> Thanks and Regards,
>>>>>>>>>> Swapnil
>>>>>>>>>>
>>>>>>>>>> On Sat, Jul 25, 2015 at 2:38 AM, Swapnil Patil <
>>>>>>>>>> swapnil.rp15@gmail.com> wrote:
>>>>>>>>>>
>>>>>>>>>>> Sure. Fine with me.
>>>>>>>>>>>
>>>>>>>>>>> Thanks and Regards,
>>>>>>>>>>> Swapnil
>>>>>>>>>>>
>>>>>>>>>>> On Fri, Jul 24, 2015 at 5:59 PM, Imesh Gunaratne <
>>>>>>>>>>> imesh@apache.org> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> Shall we move this to 2 PM on the same day (27th July)?
>>>>>>>>>>>>
>>>>>>>>>>>> Thanks
>>>>>>>>>>>>
>>>>>>>>>>>> On Fri, Jul 24, 2015 at 6:49 PM, Swapnil Patil <
>>>>>>>>>>>> swapnil.rp15@gmail.com> wrote:
>>>>>>>>>>>>
>>>>>>>>>>>>> Hi All,
>>>>>>>>>>>>>
>>>>>>>>>>>>> I am planning to schedule a code review meeting for AWS
>>>>>>>>>>>>> extension on Monday at 1 pm.
>>>>>>>>>>>>>
>>>>>>>>>>>>> Please feel free to let me know if you want to reschedule it
>>>>>>>>>>>>> at different time or a day?
>>>>>>>>>>>>>
>>>>>>>>>>>>> Thanks and Regards,
>>>>>>>>>>>>> Swapnil
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> --
>>>>>>>>>>>> Imesh Gunaratne
>>>>>>>>>>>>
>>>>>>>>>>>> Senior Technical Lead, WSO2
>>>>>>>>>>>> Committer & PMC Member, Apache Stratos
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Imesh Gunaratne
>>>>>>>>
>>>>>>>> Senior Technical Lead, WSO2
>>>>>>>> Committer & PMC Member, Apache Stratos
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Thanuja Uruththirakodeeswaran
>>>>> Software Engineer
>>>>> WSO2 Inc.;http://wso2.com
>>>>> lean.enterprise.middleware
>>>>>
>>>>> mobile: +94 774363167
>>>>>
>>>>
>>
>
>
> --
> Imesh Gunaratne
>
> Senior Technical Lead, WSO2
> Committer & PMC Member, Apache Stratos
>
Re: Code Review meeting - AWS Load Balancing Support for Stratos
Posted by Imesh Gunaratne <im...@apache.org>.
It would be better to send a pull request Swapnil. It's easier to review
the code there.
On Sun, Aug 16, 2015 at 10:09 AM, Swapnil Patil <sw...@gmail.com>
wrote:
> Hi All,
>
> After the last code review meeting I have made code changes related to
> automatic security group creation and getting in flight request count.
>
> Would someone like to review my code before I send a pull request to gsoc-projects-2015
> branch.
>
> Thanks and Regards,
> Swapnil
>
> On Tue, Aug 4, 2015 at 2:39 AM, Swapnil Patil <sw...@gmail.com>
> wrote:
>
>> Hi All,
>>
>> I have made code changes suggested in last code review meeting and
>> committed at my GitHub repo [1].
>>
>> Please feel free to let me know if I have missed anything.
>>
>> [1] https://github.com/swaprp15/stratos
>>
>> Thanks and Regards,
>> Swapnil
>> On Jul 29, 2015 5:05 PM, "Swapnil Patil" <sw...@gmail.com> wrote:
>>
>>> Thanks Thanuja!
>>>
>>> I also need to catch specific exception and log appropriate message.
>>>
>>> Thanks and Regards,
>>> Swapnil
>>> On Jul 29, 2015 4:11 PM, "Thanuja Uruththirakodeeswaran" <
>>> thanujau@wso2.com> wrote:
>>>
>>>> Hi All,
>>>>
>>>> Please find the code review notes below:
>>>>
>>>> 1. Define used constant values as readable constant variables.
>>>> 2. Include loadbalancer name length constant (32) in the exception
>>>> message in AWSHelper class.
>>>> 3. In AWSLoadBalancer avoid using "if(clusterMemberSize()==0)
>>>> break;" and follow best coding practice.
>>>> 4. Use datatype for the integer sequence in AWSLoadBalancer.
>>>> 5. In AWSHelper, refactor setEndPoint method.
>>>> 6. Pass exception as second arguement in log.error()
>>>> 7. Don't declare method parameters as final in AWSHelper class.
>>>> 8. In AWSLoadBalancer remove instance logic as it is not needed.
>>>> 9. Add method comments.
>>>>
>>>> Thank you.
>>>>
>>>> On Wed, Jul 29, 2015 at 2:11 PM, Swapnil Patil <sw...@gmail.com>
>>>> wrote:
>>>>
>>>>> Hi All,
>>>>>
>>>>> I have started hangout. You can join in for code review.
>>>>>
>>>>> URL: https://plus.google.com/hangouts/_/g7jnhpysd3dxyyrqycerhd6iyua
>>>>>
>>>>> Thanks and Regards,
>>>>> Swapnil
>>>>>
>>>>> On Mon, Jul 27, 2015 at 1:14 PM, Swapnil Patil <swapnil.rp15@gmail.com
>>>>> > wrote:
>>>>>
>>>>>> Hi Imesh,
>>>>>>
>>>>>> Ok. No problem. We can have this on Wednesday 29th July at 2 PM IST.
>>>>>>
>>>>>> Thanks and Regards,
>>>>>> Swapnil
>>>>>> On Jul 27, 2015 5:02 PM, "Imesh Gunaratne" <im...@apache.org> wrote:
>>>>>>
>>>>>>> Hi Swapnil,
>>>>>>>
>>>>>>> I'm sorry I missed this, shall we have this on this Wednesday the
>>>>>>> 29th July at 2 PM IST?
>>>>>>>
>>>>>>> Thanks
>>>>>>>
>>>>>>> On Mon, Jul 27, 2015 at 2:23 PM, Swapnil Patil <
>>>>>>> swapnil.rp15@gmail.com> wrote:
>>>>>>>
>>>>>>>> It seems no one has joined yet. Shall we have it some other time?
>>>>>>>>
>>>>>>>> Thanks and Regards,
>>>>>>>> Swapnil
>>>>>>>>
>>>>>>>> On Mon, Jul 27, 2015 at 8:28 AM, Swapnil Patil <
>>>>>>>> swapnil.rp15@gmail.com> wrote:
>>>>>>>>
>>>>>>>>> Hi All,
>>>>>>>>>
>>>>>>>>> I have started a Google Hangout. You can join in for code review.
>>>>>>>>>
>>>>>>>>> Hangout URL:
>>>>>>>>> https://plus.google.com/hangouts/_/guna2qyr7euqebsqk7lm42j6hia
>>>>>>>>>
>>>>>>>>> Thanks and Regards,
>>>>>>>>> Swapnil
>>>>>>>>>
>>>>>>>>> On Sat, Jul 25, 2015 at 2:38 AM, Swapnil Patil <
>>>>>>>>> swapnil.rp15@gmail.com> wrote:
>>>>>>>>>
>>>>>>>>>> Sure. Fine with me.
>>>>>>>>>>
>>>>>>>>>> Thanks and Regards,
>>>>>>>>>> Swapnil
>>>>>>>>>>
>>>>>>>>>> On Fri, Jul 24, 2015 at 5:59 PM, Imesh Gunaratne <
>>>>>>>>>> imesh@apache.org> wrote:
>>>>>>>>>>
>>>>>>>>>>> Shall we move this to 2 PM on the same day (27th July)?
>>>>>>>>>>>
>>>>>>>>>>> Thanks
>>>>>>>>>>>
>>>>>>>>>>> On Fri, Jul 24, 2015 at 6:49 PM, Swapnil Patil <
>>>>>>>>>>> swapnil.rp15@gmail.com> wrote:
>>>>>>>>>>>
>>>>>>>>>>>> Hi All,
>>>>>>>>>>>>
>>>>>>>>>>>> I am planning to schedule a code review meeting for AWS
>>>>>>>>>>>> extension on Monday at 1 pm.
>>>>>>>>>>>>
>>>>>>>>>>>> Please feel free to let me know if you want to reschedule it at
>>>>>>>>>>>> different time or a day?
>>>>>>>>>>>>
>>>>>>>>>>>> Thanks and Regards,
>>>>>>>>>>>> Swapnil
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> --
>>>>>>>>>>> Imesh Gunaratne
>>>>>>>>>>>
>>>>>>>>>>> Senior Technical Lead, WSO2
>>>>>>>>>>> Committer & PMC Member, Apache Stratos
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Imesh Gunaratne
>>>>>>>
>>>>>>> Senior Technical Lead, WSO2
>>>>>>> Committer & PMC Member, Apache Stratos
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Thanuja Uruththirakodeeswaran
>>>> Software Engineer
>>>> WSO2 Inc.;http://wso2.com
>>>> lean.enterprise.middleware
>>>>
>>>> mobile: +94 774363167
>>>>
>>>
>
--
Imesh Gunaratne
Senior Technical Lead, WSO2
Committer & PMC Member, Apache Stratos
Re: Code Review meeting - AWS Load Balancing Support for Stratos
Posted by Swapnil Patil <sw...@gmail.com>.
Hi All,
After the last code review meeting I have made code changes related to
automatic security group creation and getting in flight request count.
Would someone like to review my code before I send a pull request to
gsoc-projects-2015
branch.
Thanks and Regards,
Swapnil
On Tue, Aug 4, 2015 at 2:39 AM, Swapnil Patil <sw...@gmail.com>
wrote:
> Hi All,
>
> I have made code changes suggested in last code review meeting and
> committed at my GitHub repo [1].
>
> Please feel free to let me know if I have missed anything.
>
> [1] https://github.com/swaprp15/stratos
>
> Thanks and Regards,
> Swapnil
> On Jul 29, 2015 5:05 PM, "Swapnil Patil" <sw...@gmail.com> wrote:
>
>> Thanks Thanuja!
>>
>> I also need to catch specific exception and log appropriate message.
>>
>> Thanks and Regards,
>> Swapnil
>> On Jul 29, 2015 4:11 PM, "Thanuja Uruththirakodeeswaran" <
>> thanujau@wso2.com> wrote:
>>
>>> Hi All,
>>>
>>> Please find the code review notes below:
>>>
>>> 1. Define used constant values as readable constant variables.
>>> 2. Include loadbalancer name length constant (32) in the exception
>>> message in AWSHelper class.
>>> 3. In AWSLoadBalancer avoid using "if(clusterMemberSize()==0)
>>> break;" and follow best coding practice.
>>> 4. Use datatype for the integer sequence in AWSLoadBalancer.
>>> 5. In AWSHelper, refactor setEndPoint method.
>>> 6. Pass exception as second arguement in log.error()
>>> 7. Don't declare method parameters as final in AWSHelper class.
>>> 8. In AWSLoadBalancer remove instance logic as it is not needed.
>>> 9. Add method comments.
>>>
>>> Thank you.
>>>
>>> On Wed, Jul 29, 2015 at 2:11 PM, Swapnil Patil <sw...@gmail.com>
>>> wrote:
>>>
>>>> Hi All,
>>>>
>>>> I have started hangout. You can join in for code review.
>>>>
>>>> URL: https://plus.google.com/hangouts/_/g7jnhpysd3dxyyrqycerhd6iyua
>>>>
>>>> Thanks and Regards,
>>>> Swapnil
>>>>
>>>> On Mon, Jul 27, 2015 at 1:14 PM, Swapnil Patil <sw...@gmail.com>
>>>> wrote:
>>>>
>>>>> Hi Imesh,
>>>>>
>>>>> Ok. No problem. We can have this on Wednesday 29th July at 2 PM IST.
>>>>>
>>>>> Thanks and Regards,
>>>>> Swapnil
>>>>> On Jul 27, 2015 5:02 PM, "Imesh Gunaratne" <im...@apache.org> wrote:
>>>>>
>>>>>> Hi Swapnil,
>>>>>>
>>>>>> I'm sorry I missed this, shall we have this on this Wednesday the
>>>>>> 29th July at 2 PM IST?
>>>>>>
>>>>>> Thanks
>>>>>>
>>>>>> On Mon, Jul 27, 2015 at 2:23 PM, Swapnil Patil <
>>>>>> swapnil.rp15@gmail.com> wrote:
>>>>>>
>>>>>>> It seems no one has joined yet. Shall we have it some other time?
>>>>>>>
>>>>>>> Thanks and Regards,
>>>>>>> Swapnil
>>>>>>>
>>>>>>> On Mon, Jul 27, 2015 at 8:28 AM, Swapnil Patil <
>>>>>>> swapnil.rp15@gmail.com> wrote:
>>>>>>>
>>>>>>>> Hi All,
>>>>>>>>
>>>>>>>> I have started a Google Hangout. You can join in for code review.
>>>>>>>>
>>>>>>>> Hangout URL:
>>>>>>>> https://plus.google.com/hangouts/_/guna2qyr7euqebsqk7lm42j6hia
>>>>>>>>
>>>>>>>> Thanks and Regards,
>>>>>>>> Swapnil
>>>>>>>>
>>>>>>>> On Sat, Jul 25, 2015 at 2:38 AM, Swapnil Patil <
>>>>>>>> swapnil.rp15@gmail.com> wrote:
>>>>>>>>
>>>>>>>>> Sure. Fine with me.
>>>>>>>>>
>>>>>>>>> Thanks and Regards,
>>>>>>>>> Swapnil
>>>>>>>>>
>>>>>>>>> On Fri, Jul 24, 2015 at 5:59 PM, Imesh Gunaratne <imesh@apache.org
>>>>>>>>> > wrote:
>>>>>>>>>
>>>>>>>>>> Shall we move this to 2 PM on the same day (27th July)?
>>>>>>>>>>
>>>>>>>>>> Thanks
>>>>>>>>>>
>>>>>>>>>> On Fri, Jul 24, 2015 at 6:49 PM, Swapnil Patil <
>>>>>>>>>> swapnil.rp15@gmail.com> wrote:
>>>>>>>>>>
>>>>>>>>>>> Hi All,
>>>>>>>>>>>
>>>>>>>>>>> I am planning to schedule a code review meeting for AWS
>>>>>>>>>>> extension on Monday at 1 pm.
>>>>>>>>>>>
>>>>>>>>>>> Please feel free to let me know if you want to reschedule it at
>>>>>>>>>>> different time or a day?
>>>>>>>>>>>
>>>>>>>>>>> Thanks and Regards,
>>>>>>>>>>> Swapnil
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> Imesh Gunaratne
>>>>>>>>>>
>>>>>>>>>> Senior Technical Lead, WSO2
>>>>>>>>>> Committer & PMC Member, Apache Stratos
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Imesh Gunaratne
>>>>>>
>>>>>> Senior Technical Lead, WSO2
>>>>>> Committer & PMC Member, Apache Stratos
>>>>>>
>>>>>
>>>>
>>>
>>>
>>> --
>>> Thanuja Uruththirakodeeswaran
>>> Software Engineer
>>> WSO2 Inc.;http://wso2.com
>>> lean.enterprise.middleware
>>>
>>> mobile: +94 774363167
>>>
>>
Re: Code Review meeting - AWS Load Balancing Support for Stratos
Posted by Swapnil Patil <sw...@gmail.com>.
Hi All,
I have made code changes suggested in last code review meeting and
committed at my GitHub repo [1].
Please feel free to let me know if I have missed anything.
[1] https://github.com/swaprp15/stratos
Thanks and Regards,
Swapnil
On Jul 29, 2015 5:05 PM, "Swapnil Patil" <sw...@gmail.com> wrote:
> Thanks Thanuja!
>
> I also need to catch specific exception and log appropriate message.
>
> Thanks and Regards,
> Swapnil
> On Jul 29, 2015 4:11 PM, "Thanuja Uruththirakodeeswaran" <
> thanujau@wso2.com> wrote:
>
>> Hi All,
>>
>> Please find the code review notes below:
>>
>> 1. Define used constant values as readable constant variables.
>> 2. Include loadbalancer name length constant (32) in the exception
>> message in AWSHelper class.
>> 3. In AWSLoadBalancer avoid using "if(clusterMemberSize()==0) break;"
>> and follow best coding practice.
>> 4. Use datatype for the integer sequence in AWSLoadBalancer.
>> 5. In AWSHelper, refactor setEndPoint method.
>> 6. Pass exception as second arguement in log.error()
>> 7. Don't declare method parameters as final in AWSHelper class.
>> 8. In AWSLoadBalancer remove instance logic as it is not needed.
>> 9. Add method comments.
>>
>> Thank you.
>>
>> On Wed, Jul 29, 2015 at 2:11 PM, Swapnil Patil <sw...@gmail.com>
>> wrote:
>>
>>> Hi All,
>>>
>>> I have started hangout. You can join in for code review.
>>>
>>> URL: https://plus.google.com/hangouts/_/g7jnhpysd3dxyyrqycerhd6iyua
>>>
>>> Thanks and Regards,
>>> Swapnil
>>>
>>> On Mon, Jul 27, 2015 at 1:14 PM, Swapnil Patil <sw...@gmail.com>
>>> wrote:
>>>
>>>> Hi Imesh,
>>>>
>>>> Ok. No problem. We can have this on Wednesday 29th July at 2 PM IST.
>>>>
>>>> Thanks and Regards,
>>>> Swapnil
>>>> On Jul 27, 2015 5:02 PM, "Imesh Gunaratne" <im...@apache.org> wrote:
>>>>
>>>>> Hi Swapnil,
>>>>>
>>>>> I'm sorry I missed this, shall we have this on this Wednesday the 29th
>>>>> July at 2 PM IST?
>>>>>
>>>>> Thanks
>>>>>
>>>>> On Mon, Jul 27, 2015 at 2:23 PM, Swapnil Patil <swapnil.rp15@gmail.com
>>>>> > wrote:
>>>>>
>>>>>> It seems no one has joined yet. Shall we have it some other time?
>>>>>>
>>>>>> Thanks and Regards,
>>>>>> Swapnil
>>>>>>
>>>>>> On Mon, Jul 27, 2015 at 8:28 AM, Swapnil Patil <
>>>>>> swapnil.rp15@gmail.com> wrote:
>>>>>>
>>>>>>> Hi All,
>>>>>>>
>>>>>>> I have started a Google Hangout. You can join in for code review.
>>>>>>>
>>>>>>> Hangout URL:
>>>>>>> https://plus.google.com/hangouts/_/guna2qyr7euqebsqk7lm42j6hia
>>>>>>>
>>>>>>> Thanks and Regards,
>>>>>>> Swapnil
>>>>>>>
>>>>>>> On Sat, Jul 25, 2015 at 2:38 AM, Swapnil Patil <
>>>>>>> swapnil.rp15@gmail.com> wrote:
>>>>>>>
>>>>>>>> Sure. Fine with me.
>>>>>>>>
>>>>>>>> Thanks and Regards,
>>>>>>>> Swapnil
>>>>>>>>
>>>>>>>> On Fri, Jul 24, 2015 at 5:59 PM, Imesh Gunaratne <im...@apache.org>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> Shall we move this to 2 PM on the same day (27th July)?
>>>>>>>>>
>>>>>>>>> Thanks
>>>>>>>>>
>>>>>>>>> On Fri, Jul 24, 2015 at 6:49 PM, Swapnil Patil <
>>>>>>>>> swapnil.rp15@gmail.com> wrote:
>>>>>>>>>
>>>>>>>>>> Hi All,
>>>>>>>>>>
>>>>>>>>>> I am planning to schedule a code review meeting for AWS extension
>>>>>>>>>> on Monday at 1 pm.
>>>>>>>>>>
>>>>>>>>>> Please feel free to let me know if you want to reschedule it at
>>>>>>>>>> different time or a day?
>>>>>>>>>>
>>>>>>>>>> Thanks and Regards,
>>>>>>>>>> Swapnil
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Imesh Gunaratne
>>>>>>>>>
>>>>>>>>> Senior Technical Lead, WSO2
>>>>>>>>> Committer & PMC Member, Apache Stratos
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Imesh Gunaratne
>>>>>
>>>>> Senior Technical Lead, WSO2
>>>>> Committer & PMC Member, Apache Stratos
>>>>>
>>>>
>>>
>>
>>
>> --
>> Thanuja Uruththirakodeeswaran
>> Software Engineer
>> WSO2 Inc.;http://wso2.com
>> lean.enterprise.middleware
>>
>> mobile: +94 774363167
>>
>
Re: Code Review meeting - AWS Load Balancing Support for Stratos
Posted by Swapnil Patil <sw...@gmail.com>.
Thanks Thanuja!
I also need to catch specific exception and log appropriate message.
Thanks and Regards,
Swapnil
On Jul 29, 2015 4:11 PM, "Thanuja Uruththirakodeeswaran" <th...@wso2.com>
wrote:
> Hi All,
>
> Please find the code review notes below:
>
> 1. Define used constant values as readable constant variables.
> 2. Include loadbalancer name length constant (32) in the exception
> message in AWSHelper class.
> 3. In AWSLoadBalancer avoid using "if(clusterMemberSize()==0) break;"
> and follow best coding practice.
> 4. Use datatype for the integer sequence in AWSLoadBalancer.
> 5. In AWSHelper, refactor setEndPoint method.
> 6. Pass exception as second arguement in log.error()
> 7. Don't declare method parameters as final in AWSHelper class.
> 8. In AWSLoadBalancer remove instance logic as it is not needed.
> 9. Add method comments.
>
> Thank you.
>
> On Wed, Jul 29, 2015 at 2:11 PM, Swapnil Patil <sw...@gmail.com>
> wrote:
>
>> Hi All,
>>
>> I have started hangout. You can join in for code review.
>>
>> URL: https://plus.google.com/hangouts/_/g7jnhpysd3dxyyrqycerhd6iyua
>>
>> Thanks and Regards,
>> Swapnil
>>
>> On Mon, Jul 27, 2015 at 1:14 PM, Swapnil Patil <sw...@gmail.com>
>> wrote:
>>
>>> Hi Imesh,
>>>
>>> Ok. No problem. We can have this on Wednesday 29th July at 2 PM IST.
>>>
>>> Thanks and Regards,
>>> Swapnil
>>> On Jul 27, 2015 5:02 PM, "Imesh Gunaratne" <im...@apache.org> wrote:
>>>
>>>> Hi Swapnil,
>>>>
>>>> I'm sorry I missed this, shall we have this on this Wednesday the 29th
>>>> July at 2 PM IST?
>>>>
>>>> Thanks
>>>>
>>>> On Mon, Jul 27, 2015 at 2:23 PM, Swapnil Patil <sw...@gmail.com>
>>>> wrote:
>>>>
>>>>> It seems no one has joined yet. Shall we have it some other time?
>>>>>
>>>>> Thanks and Regards,
>>>>> Swapnil
>>>>>
>>>>> On Mon, Jul 27, 2015 at 8:28 AM, Swapnil Patil <swapnil.rp15@gmail.com
>>>>> > wrote:
>>>>>
>>>>>> Hi All,
>>>>>>
>>>>>> I have started a Google Hangout. You can join in for code review.
>>>>>>
>>>>>> Hangout URL:
>>>>>> https://plus.google.com/hangouts/_/guna2qyr7euqebsqk7lm42j6hia
>>>>>>
>>>>>> Thanks and Regards,
>>>>>> Swapnil
>>>>>>
>>>>>> On Sat, Jul 25, 2015 at 2:38 AM, Swapnil Patil <
>>>>>> swapnil.rp15@gmail.com> wrote:
>>>>>>
>>>>>>> Sure. Fine with me.
>>>>>>>
>>>>>>> Thanks and Regards,
>>>>>>> Swapnil
>>>>>>>
>>>>>>> On Fri, Jul 24, 2015 at 5:59 PM, Imesh Gunaratne <im...@apache.org>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> Shall we move this to 2 PM on the same day (27th July)?
>>>>>>>>
>>>>>>>> Thanks
>>>>>>>>
>>>>>>>> On Fri, Jul 24, 2015 at 6:49 PM, Swapnil Patil <
>>>>>>>> swapnil.rp15@gmail.com> wrote:
>>>>>>>>
>>>>>>>>> Hi All,
>>>>>>>>>
>>>>>>>>> I am planning to schedule a code review meeting for AWS extension
>>>>>>>>> on Monday at 1 pm.
>>>>>>>>>
>>>>>>>>> Please feel free to let me know if you want to reschedule it at
>>>>>>>>> different time or a day?
>>>>>>>>>
>>>>>>>>> Thanks and Regards,
>>>>>>>>> Swapnil
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Imesh Gunaratne
>>>>>>>>
>>>>>>>> Senior Technical Lead, WSO2
>>>>>>>> Committer & PMC Member, Apache Stratos
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Imesh Gunaratne
>>>>
>>>> Senior Technical Lead, WSO2
>>>> Committer & PMC Member, Apache Stratos
>>>>
>>>
>>
>
>
> --
> Thanuja Uruththirakodeeswaran
> Software Engineer
> WSO2 Inc.;http://wso2.com
> lean.enterprise.middleware
>
> mobile: +94 774363167
>
Re: Code Review meeting - AWS Load Balancing Support for Stratos
Posted by Thanuja Uruththirakodeeswaran <th...@wso2.com>.
Hi All,
Please find the code review notes below:
1. Define used constant values as readable constant variables.
2. Include loadbalancer name length constant (32) in the exception
message in AWSHelper class.
3. In AWSLoadBalancer avoid using "if(clusterMemberSize()==0) break;"
and follow best coding practice.
4. Use datatype for the integer sequence in AWSLoadBalancer.
5. In AWSHelper, refactor setEndPoint method.
6. Pass exception as second arguement in log.error()
7. Don't declare method parameters as final in AWSHelper class.
8. In AWSLoadBalancer remove instance logic as it is not needed.
9. Add method comments.
Thank you.
On Wed, Jul 29, 2015 at 2:11 PM, Swapnil Patil <sw...@gmail.com>
wrote:
> Hi All,
>
> I have started hangout. You can join in for code review.
>
> URL: https://plus.google.com/hangouts/_/g7jnhpysd3dxyyrqycerhd6iyua
>
> Thanks and Regards,
> Swapnil
>
> On Mon, Jul 27, 2015 at 1:14 PM, Swapnil Patil <sw...@gmail.com>
> wrote:
>
>> Hi Imesh,
>>
>> Ok. No problem. We can have this on Wednesday 29th July at 2 PM IST.
>>
>> Thanks and Regards,
>> Swapnil
>> On Jul 27, 2015 5:02 PM, "Imesh Gunaratne" <im...@apache.org> wrote:
>>
>>> Hi Swapnil,
>>>
>>> I'm sorry I missed this, shall we have this on this Wednesday the 29th
>>> July at 2 PM IST?
>>>
>>> Thanks
>>>
>>> On Mon, Jul 27, 2015 at 2:23 PM, Swapnil Patil <sw...@gmail.com>
>>> wrote:
>>>
>>>> It seems no one has joined yet. Shall we have it some other time?
>>>>
>>>> Thanks and Regards,
>>>> Swapnil
>>>>
>>>> On Mon, Jul 27, 2015 at 8:28 AM, Swapnil Patil <sw...@gmail.com>
>>>> wrote:
>>>>
>>>>> Hi All,
>>>>>
>>>>> I have started a Google Hangout. You can join in for code review.
>>>>>
>>>>> Hangout URL:
>>>>> https://plus.google.com/hangouts/_/guna2qyr7euqebsqk7lm42j6hia
>>>>>
>>>>> Thanks and Regards,
>>>>> Swapnil
>>>>>
>>>>> On Sat, Jul 25, 2015 at 2:38 AM, Swapnil Patil <swapnil.rp15@gmail.com
>>>>> > wrote:
>>>>>
>>>>>> Sure. Fine with me.
>>>>>>
>>>>>> Thanks and Regards,
>>>>>> Swapnil
>>>>>>
>>>>>> On Fri, Jul 24, 2015 at 5:59 PM, Imesh Gunaratne <im...@apache.org>
>>>>>> wrote:
>>>>>>
>>>>>>> Shall we move this to 2 PM on the same day (27th July)?
>>>>>>>
>>>>>>> Thanks
>>>>>>>
>>>>>>> On Fri, Jul 24, 2015 at 6:49 PM, Swapnil Patil <
>>>>>>> swapnil.rp15@gmail.com> wrote:
>>>>>>>
>>>>>>>> Hi All,
>>>>>>>>
>>>>>>>> I am planning to schedule a code review meeting for AWS extension
>>>>>>>> on Monday at 1 pm.
>>>>>>>>
>>>>>>>> Please feel free to let me know if you want to reschedule it at
>>>>>>>> different time or a day?
>>>>>>>>
>>>>>>>> Thanks and Regards,
>>>>>>>> Swapnil
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Imesh Gunaratne
>>>>>>>
>>>>>>> Senior Technical Lead, WSO2
>>>>>>> Committer & PMC Member, Apache Stratos
>>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>>
>>> --
>>> Imesh Gunaratne
>>>
>>> Senior Technical Lead, WSO2
>>> Committer & PMC Member, Apache Stratos
>>>
>>
>
--
Thanuja Uruththirakodeeswaran
Software Engineer
WSO2 Inc.;http://wso2.com
lean.enterprise.middleware
mobile: +94 774363167
Re: Code Review meeting - AWS Load Balancing Support for Stratos
Posted by Swapnil Patil <sw...@gmail.com>.
Hi All,
I have started hangout. You can join in for code review.
URL: https://plus.google.com/hangouts/_/g7jnhpysd3dxyyrqycerhd6iyua
Thanks and Regards,
Swapnil
On Mon, Jul 27, 2015 at 1:14 PM, Swapnil Patil <sw...@gmail.com>
wrote:
> Hi Imesh,
>
> Ok. No problem. We can have this on Wednesday 29th July at 2 PM IST.
>
> Thanks and Regards,
> Swapnil
> On Jul 27, 2015 5:02 PM, "Imesh Gunaratne" <im...@apache.org> wrote:
>
>> Hi Swapnil,
>>
>> I'm sorry I missed this, shall we have this on this Wednesday the 29th
>> July at 2 PM IST?
>>
>> Thanks
>>
>> On Mon, Jul 27, 2015 at 2:23 PM, Swapnil Patil <sw...@gmail.com>
>> wrote:
>>
>>> It seems no one has joined yet. Shall we have it some other time?
>>>
>>> Thanks and Regards,
>>> Swapnil
>>>
>>> On Mon, Jul 27, 2015 at 8:28 AM, Swapnil Patil <sw...@gmail.com>
>>> wrote:
>>>
>>>> Hi All,
>>>>
>>>> I have started a Google Hangout. You can join in for code review.
>>>>
>>>> Hangout URL:
>>>> https://plus.google.com/hangouts/_/guna2qyr7euqebsqk7lm42j6hia
>>>>
>>>> Thanks and Regards,
>>>> Swapnil
>>>>
>>>> On Sat, Jul 25, 2015 at 2:38 AM, Swapnil Patil <sw...@gmail.com>
>>>> wrote:
>>>>
>>>>> Sure. Fine with me.
>>>>>
>>>>> Thanks and Regards,
>>>>> Swapnil
>>>>>
>>>>> On Fri, Jul 24, 2015 at 5:59 PM, Imesh Gunaratne <im...@apache.org>
>>>>> wrote:
>>>>>
>>>>>> Shall we move this to 2 PM on the same day (27th July)?
>>>>>>
>>>>>> Thanks
>>>>>>
>>>>>> On Fri, Jul 24, 2015 at 6:49 PM, Swapnil Patil <
>>>>>> swapnil.rp15@gmail.com> wrote:
>>>>>>
>>>>>>> Hi All,
>>>>>>>
>>>>>>> I am planning to schedule a code review meeting for AWS extension on
>>>>>>> Monday at 1 pm.
>>>>>>>
>>>>>>> Please feel free to let me know if you want to reschedule it at
>>>>>>> different time or a day?
>>>>>>>
>>>>>>> Thanks and Regards,
>>>>>>> Swapnil
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Imesh Gunaratne
>>>>>>
>>>>>> Senior Technical Lead, WSO2
>>>>>> Committer & PMC Member, Apache Stratos
>>>>>>
>>>>>
>>>>>
>>>>
>>>
>>
>>
>> --
>> Imesh Gunaratne
>>
>> Senior Technical Lead, WSO2
>> Committer & PMC Member, Apache Stratos
>>
>
Re: Code Review meeting - AWS Load Balancing Support for Stratos
Posted by Swapnil Patil <sw...@gmail.com>.
Hi Imesh,
Ok. No problem. We can have this on Wednesday 29th July at 2 PM IST.
Thanks and Regards,
Swapnil
On Jul 27, 2015 5:02 PM, "Imesh Gunaratne" <im...@apache.org> wrote:
> Hi Swapnil,
>
> I'm sorry I missed this, shall we have this on this Wednesday the 29th
> July at 2 PM IST?
>
> Thanks
>
> On Mon, Jul 27, 2015 at 2:23 PM, Swapnil Patil <sw...@gmail.com>
> wrote:
>
>> It seems no one has joined yet. Shall we have it some other time?
>>
>> Thanks and Regards,
>> Swapnil
>>
>> On Mon, Jul 27, 2015 at 8:28 AM, Swapnil Patil <sw...@gmail.com>
>> wrote:
>>
>>> Hi All,
>>>
>>> I have started a Google Hangout. You can join in for code review.
>>>
>>> Hangout URL:
>>> https://plus.google.com/hangouts/_/guna2qyr7euqebsqk7lm42j6hia
>>>
>>> Thanks and Regards,
>>> Swapnil
>>>
>>> On Sat, Jul 25, 2015 at 2:38 AM, Swapnil Patil <sw...@gmail.com>
>>> wrote:
>>>
>>>> Sure. Fine with me.
>>>>
>>>> Thanks and Regards,
>>>> Swapnil
>>>>
>>>> On Fri, Jul 24, 2015 at 5:59 PM, Imesh Gunaratne <im...@apache.org>
>>>> wrote:
>>>>
>>>>> Shall we move this to 2 PM on the same day (27th July)?
>>>>>
>>>>> Thanks
>>>>>
>>>>> On Fri, Jul 24, 2015 at 6:49 PM, Swapnil Patil <swapnil.rp15@gmail.com
>>>>> > wrote:
>>>>>
>>>>>> Hi All,
>>>>>>
>>>>>> I am planning to schedule a code review meeting for AWS extension on
>>>>>> Monday at 1 pm.
>>>>>>
>>>>>> Please feel free to let me know if you want to reschedule it at
>>>>>> different time or a day?
>>>>>>
>>>>>> Thanks and Regards,
>>>>>> Swapnil
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Imesh Gunaratne
>>>>>
>>>>> Senior Technical Lead, WSO2
>>>>> Committer & PMC Member, Apache Stratos
>>>>>
>>>>
>>>>
>>>
>>
>
>
> --
> Imesh Gunaratne
>
> Senior Technical Lead, WSO2
> Committer & PMC Member, Apache Stratos
>
Re: Code Review meeting - AWS Load Balancing Support for Stratos
Posted by Imesh Gunaratne <im...@apache.org>.
Hi Swapnil,
I'm sorry I missed this, shall we have this on this Wednesday the 29th July
at 2 PM IST?
Thanks
On Mon, Jul 27, 2015 at 2:23 PM, Swapnil Patil <sw...@gmail.com>
wrote:
> It seems no one has joined yet. Shall we have it some other time?
>
> Thanks and Regards,
> Swapnil
>
> On Mon, Jul 27, 2015 at 8:28 AM, Swapnil Patil <sw...@gmail.com>
> wrote:
>
>> Hi All,
>>
>> I have started a Google Hangout. You can join in for code review.
>>
>> Hangout URL:
>> https://plus.google.com/hangouts/_/guna2qyr7euqebsqk7lm42j6hia
>>
>> Thanks and Regards,
>> Swapnil
>>
>> On Sat, Jul 25, 2015 at 2:38 AM, Swapnil Patil <sw...@gmail.com>
>> wrote:
>>
>>> Sure. Fine with me.
>>>
>>> Thanks and Regards,
>>> Swapnil
>>>
>>> On Fri, Jul 24, 2015 at 5:59 PM, Imesh Gunaratne <im...@apache.org>
>>> wrote:
>>>
>>>> Shall we move this to 2 PM on the same day (27th July)?
>>>>
>>>> Thanks
>>>>
>>>> On Fri, Jul 24, 2015 at 6:49 PM, Swapnil Patil <sw...@gmail.com>
>>>> wrote:
>>>>
>>>>> Hi All,
>>>>>
>>>>> I am planning to schedule a code review meeting for AWS extension on
>>>>> Monday at 1 pm.
>>>>>
>>>>> Please feel free to let me know if you want to reschedule it at
>>>>> different time or a day?
>>>>>
>>>>> Thanks and Regards,
>>>>> Swapnil
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Imesh Gunaratne
>>>>
>>>> Senior Technical Lead, WSO2
>>>> Committer & PMC Member, Apache Stratos
>>>>
>>>
>>>
>>
>
--
Imesh Gunaratne
Senior Technical Lead, WSO2
Committer & PMC Member, Apache Stratos
Re: Code Review meeting - AWS Load Balancing Support for Stratos
Posted by Swapnil Patil <sw...@gmail.com>.
It seems no one has joined yet. Shall we have it some other time?
Thanks and Regards,
Swapnil
On Mon, Jul 27, 2015 at 8:28 AM, Swapnil Patil <sw...@gmail.com>
wrote:
> Hi All,
>
> I have started a Google Hangout. You can join in for code review.
>
> Hangout URL:
> https://plus.google.com/hangouts/_/guna2qyr7euqebsqk7lm42j6hia
>
> Thanks and Regards,
> Swapnil
>
> On Sat, Jul 25, 2015 at 2:38 AM, Swapnil Patil <sw...@gmail.com>
> wrote:
>
>> Sure. Fine with me.
>>
>> Thanks and Regards,
>> Swapnil
>>
>> On Fri, Jul 24, 2015 at 5:59 PM, Imesh Gunaratne <im...@apache.org>
>> wrote:
>>
>>> Shall we move this to 2 PM on the same day (27th July)?
>>>
>>> Thanks
>>>
>>> On Fri, Jul 24, 2015 at 6:49 PM, Swapnil Patil <sw...@gmail.com>
>>> wrote:
>>>
>>>> Hi All,
>>>>
>>>> I am planning to schedule a code review meeting for AWS extension on
>>>> Monday at 1 pm.
>>>>
>>>> Please feel free to let me know if you want to reschedule it at
>>>> different time or a day?
>>>>
>>>> Thanks and Regards,
>>>> Swapnil
>>>>
>>>
>>>
>>>
>>> --
>>> Imesh Gunaratne
>>>
>>> Senior Technical Lead, WSO2
>>> Committer & PMC Member, Apache Stratos
>>>
>>
>>
>
Re: Code Review meeting - AWS Load Balancing Support for Stratos
Posted by Swapnil Patil <sw...@gmail.com>.
Hi All,
I have started a Google Hangout. You can join in for code review.
Hangout URL: https://plus.google.com/hangouts/_/guna2qyr7euqebsqk7lm42j6hia
Thanks and Regards,
Swapnil
On Sat, Jul 25, 2015 at 2:38 AM, Swapnil Patil <sw...@gmail.com>
wrote:
> Sure. Fine with me.
>
> Thanks and Regards,
> Swapnil
>
> On Fri, Jul 24, 2015 at 5:59 PM, Imesh Gunaratne <im...@apache.org> wrote:
>
>> Shall we move this to 2 PM on the same day (27th July)?
>>
>> Thanks
>>
>> On Fri, Jul 24, 2015 at 6:49 PM, Swapnil Patil <sw...@gmail.com>
>> wrote:
>>
>>> Hi All,
>>>
>>> I am planning to schedule a code review meeting for AWS extension on
>>> Monday at 1 pm.
>>>
>>> Please feel free to let me know if you want to reschedule it at
>>> different time or a day?
>>>
>>> Thanks and Regards,
>>> Swapnil
>>>
>>
>>
>>
>> --
>> Imesh Gunaratne
>>
>> Senior Technical Lead, WSO2
>> Committer & PMC Member, Apache Stratos
>>
>
>
Re: Code Review meeting - AWS Load Balancing Support for Stratos
Posted by Swapnil Patil <sw...@gmail.com>.
Sure. Fine with me.
Thanks and Regards,
Swapnil
On Fri, Jul 24, 2015 at 5:59 PM, Imesh Gunaratne <im...@apache.org> wrote:
> Shall we move this to 2 PM on the same day (27th July)?
>
> Thanks
>
> On Fri, Jul 24, 2015 at 6:49 PM, Swapnil Patil <sw...@gmail.com>
> wrote:
>
>> Hi All,
>>
>> I am planning to schedule a code review meeting for AWS extension on
>> Monday at 1 pm.
>>
>> Please feel free to let me know if you want to reschedule it at different
>> time or a day?
>>
>> Thanks and Regards,
>> Swapnil
>>
>
>
>
> --
> Imesh Gunaratne
>
> Senior Technical Lead, WSO2
> Committer & PMC Member, Apache Stratos
>
Re: Code Review meeting - AWS Load Balancing Support for Stratos
Posted by Imesh Gunaratne <im...@apache.org>.
Shall we move this to 2 PM on the same day (27th July)?
Thanks
On Fri, Jul 24, 2015 at 6:49 PM, Swapnil Patil <sw...@gmail.com>
wrote:
> Hi All,
>
> I am planning to schedule a code review meeting for AWS extension on
> Monday at 1 pm.
>
> Please feel free to let me know if you want to reschedule it at different
> time or a day?
>
> Thanks and Regards,
> Swapnil
>
--
Imesh Gunaratne
Senior Technical Lead, WSO2
Committer & PMC Member, Apache Stratos