[jira] [Commented] (YARN-2128) SchedulerApplicationAttempt's amResource should be normalized and FSLeafQueue's amResourceUsage should be updated correctly

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14020345#comment-14020345 ] 

Hadoop QA commented on YARN-2128:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12648700/YARN-2128.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-YARN-Build/3928//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3928//console

This message is automatically generated.

> SchedulerApplicationAttempt's amResource should be normalized and FSLeafQueue's amResourceUsage should be updated correctly
> ---------------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-2128
>                 URL: https://issues.apache.org/jira/browse/YARN-2128
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Wei Yan
>            Assignee: Wei Yan
>         Attachments: YARN-2128.patch, YARN-2128.patch
>
>
> 1. The amResource should be normalized instead of fetching from ApplicationSubmissionContext directly.
> {code}
>     ApplicationSubmissionContext appSubmissionContext =
>         rmContext.getRMApps().get(applicationAttemptId.getApplicationId())
>             .getApplicationSubmissionContext();
>     if (appSubmissionContext != null) {
>         amResource = appSubmissionContext.getResource();
>         unmanagedAM = appSubmissionContext.getUnmanagedAM();
>     }
> {code}
> 2. When one application is removed, the FSLeafQueue's amResourceUsage should be updated only if the app has started its AM.
> {code}
>   if (runnableAppScheds.remove(app.getAppSchedulable())) {
>       // Update AM resource usage
>       if (app.getAMResource() != null) {
>         Resources.subtractFrom(amResourceUsage, app.getAMResource());
>       }
>       return true;
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)