[GitHub] [beam] TheNeuralBit commented on a change in pull request #17126: Add ability to handle streaming input to AvroSchemaIOProvider

[GitBox <gi...@apache.org>]

TheNeuralBit commented on a change in pull request #17126:
URL: https://github.com/apache/beam/pull/17126#discussion_r832718849



##########
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/io/AvroSchemaIOProvider.java
##########
@@ -74,17 +80,25 @@ public boolean requiresDataSchema() {
 
   @Override
   public PCollection.IsBounded isBounded() {
+    // This supports streaming now as well but there's no option for this. The move to
+    // SchemaTransform will remove the need to provide this.
     return PCollection.IsBounded.BOUNDED;
   }
 
   /** An abstraction to create schema aware IOs. */
   private static class AvroSchemaIO implements SchemaIO, Serializable {
     protected final Schema dataSchema;
     protected final String location;
+    protected final Duration windowSize;

Review comment:
       nit: the null checker should complain about this, but it looks like it's disabled in this file (`SuppressWarnings("nullness")` above)
   ```suggestion
       protected final @Nullable Duration windowSize;
   ```
   
   Doesn't necessarily need to happen now, we could enable the null checker and fix this issue and others at a later date.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org