[GitHub] [hadoop] hadoop-yetus commented on a change in pull request #1680: HDFS-14907. [Dynamometer] DataNode can't find junit jar when using Hadoop-3 binary

[GitBox <gi...@apache.org>]

hadoop-yetus commented on a change in pull request #1680: HDFS-14907. [Dynamometer] DataNode can't find junit jar when using Hadoop-3 binary
URL: https://github.com/apache/hadoop/pull/1680#discussion_r339458575
 
 

 ##########
 File path: hadoop-tools/hadoop-dynamometer/hadoop-dynamometer-infra/src/main/resources/start-component.sh
 ##########
 @@ -94,6 +94,12 @@ function hdfs_original {
 extraClasspathDir="$(pwd)/additionalClasspath/"
 mkdir -p "${extraClasspathDir}"
 
+junitClassPath="$(find $hadoopHome -name "junit*.jar" | head -n 1)"
 
 Review comment:
   shellcheck:24: note: Double quote to prevent globbing and word splitting. [SC2086]
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org