[GitHub] [james-project] chibenwa edited a comment on pull request #446: JAMES-3516 Add threadId property to MessageResult POJO, MailboxMessage POJO

[GitBox <gi...@apache.org>]

chibenwa edited a comment on pull request #446:
URL: https://github.com/apache/james-project/pull/446#issuecomment-845911128


   > `return new ThreadId(message.getMessageId().serialize());`
   
   Underlying storing things as string is innefficient.
   
   I would prefer `return new ThreadId(message.getMessageId());` as:
   
    - The first messageId seems like a good way to designate a thread
    - We can rely on the implementation-specific MessageId to avoid yet another generic POJO.
    
    (for me the alternative is having a generic `ThreadId` and a `CassandraThreadId`, `JpaThreadId`, `MemoryThreadId` but it seems pretty boiler plate to me....)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org