You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by sp...@apache.org on 2015/05/22 18:44:56 UTC
[2/2] incubator-tinkerpop git commit: Enforce exception types for
ScriptEngineLambda.
Enforce exception types for ScriptEngineLambda.
Project: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/commit/dd28f55d
Tree: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/tree/dd28f55d
Diff: http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/diff/dd28f55d
Branch: refs/heads/master
Commit: dd28f55dca4f029e1c35ad29ac6b0bd7faee23c9
Parents: 3b9dcb8
Author: Stephen Mallette <sp...@genoprime.com>
Authored: Fri May 22 12:44:25 2015 -0400
Committer: Stephen Mallette <sp...@genoprime.com>
Committed: Fri May 22 12:44:25 2015 -0400
----------------------------------------------------------------------
.../util/function/ScriptEngineLambdaTest.java | 30 ++++++++++++++++++++
1 file changed, 30 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-tinkerpop/blob/dd28f55d/gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/util/function/ScriptEngineLambdaTest.java
----------------------------------------------------------------------
diff --git a/gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/util/function/ScriptEngineLambdaTest.java b/gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/util/function/ScriptEngineLambdaTest.java
index 5e70c6a..a609ee0 100644
--- a/gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/util/function/ScriptEngineLambdaTest.java
+++ b/gremlin-core/src/test/java/org/apache/tinkerpop/gremlin/util/function/ScriptEngineLambdaTest.java
@@ -35,18 +35,33 @@ public class ScriptEngineLambdaTest {
assertEquals(11.0, lambda.apply(10));
}
+ @Test(expected = IllegalArgumentException.class)
+ public void shouldThrowOnBadScriptAsFunction() {
+ new ScriptEngineLambda("nashorn", "1432423)a").apply("a");
+ }
+
@Test
public void shouldCallAsSupplier() {
final ScriptEngineLambda lambda = new ScriptEngineLambda("nashorn", "11");
assertEquals(11, lambda.get());
}
+ @Test(expected = IllegalArgumentException.class)
+ public void shouldThrowOnBadScriptAsSupplier() {
+ new ScriptEngineLambda("nashorn", "1432423)a").get();
+ }
+
@Test
public void shouldCallAsPredicate() {
final ScriptEngineLambda lambda = new ScriptEngineLambda("nashorn", "a > 10");
assertThat(lambda.test(100), is(true));
}
+ @Test(expected = IllegalArgumentException.class)
+ public void shouldThrowOnBadScriptAsPredicate() {
+ new ScriptEngineLambda("nashorn", "1432423)a").test(1);
+ }
+
@Test
public void shouldCallAsConsumer() {
final ScriptEngineLambda lambda = new ScriptEngineLambda("nashorn", "a.setData('test')");
@@ -55,6 +70,11 @@ public class ScriptEngineLambdaTest {
assertEquals("test", junk.getData());
}
+ @Test(expected = IllegalArgumentException.class)
+ public void shouldThrowOnBadScriptAsConsumer() {
+ new ScriptEngineLambda("nashorn", "1432423)a").accept("1");
+ }
+
@Test
public void shouldCallAsBiConsumer() {
final ScriptEngineLambda lambda = new ScriptEngineLambda("nashorn", "a.setData('testa');b.setData('testb')");
@@ -66,6 +86,11 @@ public class ScriptEngineLambdaTest {
assertEquals("testb", junkB.getData());
}
+ @Test(expected = IllegalArgumentException.class)
+ public void shouldThrowOnBadScriptAsBiConsumer() {
+ new ScriptEngineLambda("nashorn", "1432423)a").accept("1", "2");
+ }
+
@Test
public void shouldCallAsTriConsumer() {
final ScriptEngineLambda lambda = new ScriptEngineLambda("nashorn", "a.setData('testa');b.setData('testb');c.setData('testc')");
@@ -79,6 +104,11 @@ public class ScriptEngineLambdaTest {
assertEquals("testc", junkC.getData());
}
+ @Test(expected = IllegalArgumentException.class)
+ public void shouldThrowOnBadScriptAsTriConsumer() {
+ new ScriptEngineLambda("nashorn", "1432423)a").accept("1", "2", "3");
+ }
+
public static class Junk {
private String data = "";