You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Dennis Lawler <dl...@gmail.com> on 2013/05/01 20:41:25 UTC
Review Request: Release old DHCP entries
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10884/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
Release old DHCP entries when adding new entries.
Add dnsmasq-utils to System VM template.
This addresses bug CLOUDSTACK-2299.
Diffs
-----
patches/systemvm/debian/config/root/edithosts.sh 1f98fbf
scripts/network/exdhcp/dnsmasq_edithosts.sh 05285d9
tools/appliance/definitions/systemvmtemplate/postinstall.sh ae8f1ad
tools/appliance/definitions/systemvmtemplate64/postinstall.sh ae8f1ad
Diff: https://reviews.apache.org/r/10884/diff/
Testing
-------
Tested in staging VM destroyed and re-instantiated with same IP.
Did not test adding dnsmasq-utils to system VM build (yet).
Thanks,
Dennis Lawler
Re: Review Request: Release old DHCP entries
Posted by Marcus Sorensen <sh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10884/#review20076
-----------------------------------------------------------
Ship it!
Ship It!
- Marcus Sorensen
On May 2, 2013, 5:38 a.m., Dennis Lawler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10884/
> -----------------------------------------------------------
>
> (Updated May 2, 2013, 5:38 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Release old DHCP entries when adding new entries.
>
> Add dnsmasq-utils to System VM template.
>
>
> This addresses bug CLOUDSTACK-2299.
>
>
> Diffs
> -----
>
> patches/systemvm/debian/config/root/edithosts.sh 1f98fbf
> scripts/network/exdhcp/dnsmasq_edithosts.sh 05285d9
> tools/appliance/definitions/systemvmtemplate/postinstall.sh ae8f1ad
> tools/appliance/definitions/systemvmtemplate64/postinstall.sh ae8f1ad
>
> Diff: https://reviews.apache.org/r/10884/diff/
>
>
> Testing
> -------
>
> Tested in staging VM destroyed and re-instantiated with same IP.
> Did not test adding dnsmasq-utils to system VM build (yet).
>
>
> Thanks,
>
> Dennis Lawler
>
>
Re: Review Request: Release old DHCP entries
Posted by Chiradeep Vittal <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10884/#review20088
-----------------------------------------------------------
Ship it!
Ship It!
- Chiradeep Vittal
On May 2, 2013, 5:38 a.m., Dennis Lawler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10884/
> -----------------------------------------------------------
>
> (Updated May 2, 2013, 5:38 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Release old DHCP entries when adding new entries.
>
> Add dnsmasq-utils to System VM template.
>
>
> This addresses bug CLOUDSTACK-2299.
>
>
> Diffs
> -----
>
> patches/systemvm/debian/config/root/edithosts.sh 1f98fbf
> scripts/network/exdhcp/dnsmasq_edithosts.sh 05285d9
> tools/appliance/definitions/systemvmtemplate/postinstall.sh ae8f1ad
> tools/appliance/definitions/systemvmtemplate64/postinstall.sh ae8f1ad
>
> Diff: https://reviews.apache.org/r/10884/diff/
>
>
> Testing
> -------
>
> Tested in staging VM destroyed and re-instantiated with same IP.
> Did not test adding dnsmasq-utils to system VM build (yet).
>
>
> Thanks,
>
> Dennis Lawler
>
>
Re: Review Request: Release old DHCP entries
Posted by Dennis Lawler <dl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10884/
-----------------------------------------------------------
(Updated May 2, 2013, 5:38 a.m.)
Review request for cloudstack.
Changes
-------
Incorporated proposed changes from Marcus Sorensen, but used "command -v" to determine existence of dhcp_release.
Fixed $ipv4 usage in patch.
Fixed exdhcp dnsmasq update to reflect correct args.
Description
-------
Release old DHCP entries when adding new entries.
Add dnsmasq-utils to System VM template.
This addresses bug CLOUDSTACK-2299.
Diffs (updated)
-----
patches/systemvm/debian/config/root/edithosts.sh 1f98fbf
scripts/network/exdhcp/dnsmasq_edithosts.sh 05285d9
tools/appliance/definitions/systemvmtemplate/postinstall.sh ae8f1ad
tools/appliance/definitions/systemvmtemplate64/postinstall.sh ae8f1ad
Diff: https://reviews.apache.org/r/10884/diff/
Testing
-------
Tested in staging VM destroyed and re-instantiated with same IP.
Did not test adding dnsmasq-utils to system VM build (yet).
Thanks,
Dennis Lawler
Re: Review Request: Release old DHCP entries
Posted by Dennis Lawler <dl...@gmail.com>.
> On May 1, 2013, 10:05 p.m., Chiradeep Vittal wrote:
> > patches/systemvm/debian/config/root/edithosts.sh, line 104
> > <https://reviews.apache.org/r/10884/diff/2/?file=286739#file286739line104>
> >
> > Please check for the existence of 'dhcp_release' binary. You will have folks upgrading from 4.1 and expecting their 'old' system vms to work until they finish upgrading to the new system vm.
That's right, my apologies.
I didn't think about that until after Marcus posted his proposed changes to the mailing list, so I incorporated them with a few minor changes.
- Dennis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10884/#review20031
-----------------------------------------------------------
On May 2, 2013, 5:38 a.m., Dennis Lawler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10884/
> -----------------------------------------------------------
>
> (Updated May 2, 2013, 5:38 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Release old DHCP entries when adding new entries.
>
> Add dnsmasq-utils to System VM template.
>
>
> This addresses bug CLOUDSTACK-2299.
>
>
> Diffs
> -----
>
> patches/systemvm/debian/config/root/edithosts.sh 1f98fbf
> scripts/network/exdhcp/dnsmasq_edithosts.sh 05285d9
> tools/appliance/definitions/systemvmtemplate/postinstall.sh ae8f1ad
> tools/appliance/definitions/systemvmtemplate64/postinstall.sh ae8f1ad
>
> Diff: https://reviews.apache.org/r/10884/diff/
>
>
> Testing
> -------
>
> Tested in staging VM destroyed and re-instantiated with same IP.
> Did not test adding dnsmasq-utils to system VM build (yet).
>
>
> Thanks,
>
> Dennis Lawler
>
>
Re: Review Request: Release old DHCP entries
Posted by Chiradeep Vittal <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10884/#review20031
-----------------------------------------------------------
patches/systemvm/debian/config/root/edithosts.sh
<https://reviews.apache.org/r/10884/#comment41265>
Please check for the existence of 'dhcp_release' binary. You will have folks upgrading from 4.1 and expecting their 'old' system vms to work until they finish upgrading to the new system vm.
- Chiradeep Vittal
On May 1, 2013, 6:41 p.m., Dennis Lawler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10884/
> -----------------------------------------------------------
>
> (Updated May 1, 2013, 6:41 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Release old DHCP entries when adding new entries.
>
> Add dnsmasq-utils to System VM template.
>
>
> This addresses bug CLOUDSTACK-2299.
>
>
> Diffs
> -----
>
> patches/systemvm/debian/config/root/edithosts.sh 1f98fbf
> scripts/network/exdhcp/dnsmasq_edithosts.sh 05285d9
> tools/appliance/definitions/systemvmtemplate/postinstall.sh ae8f1ad
> tools/appliance/definitions/systemvmtemplate64/postinstall.sh ae8f1ad
>
> Diff: https://reviews.apache.org/r/10884/diff/
>
>
> Testing
> -------
>
> Tested in staging VM destroyed and re-instantiated with same IP.
> Did not test adding dnsmasq-utils to system VM build (yet).
>
>
> Thanks,
>
> Dennis Lawler
>
>
Re: Review Request: Release old DHCP entries
Posted by Dennis Lawler <dl...@gmail.com>.
> On May 1, 2013, 8:36 p.m., Marcus Sorensen wrote:
> > patches/systemvm/debian/config/root/edithosts.sh, line 103
> > <https://reviews.apache.org/r/10884/diff/2/?file=286739#file286739line103>
> >
> > shouldn't this be $ipv4?, and if it fails to find the mac in the leases file, will it kill the whole script?
That's right - bad typo.
If it fails to find the MAC in the leases file (the usual case), dhcp_release does not get enough args and fails.
It shouldn't kill the whole script, or at least it hasn't in testing.
- Dennis
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10884/#review20025
-----------------------------------------------------------
On May 2, 2013, 5:38 a.m., Dennis Lawler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10884/
> -----------------------------------------------------------
>
> (Updated May 2, 2013, 5:38 a.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Release old DHCP entries when adding new entries.
>
> Add dnsmasq-utils to System VM template.
>
>
> This addresses bug CLOUDSTACK-2299.
>
>
> Diffs
> -----
>
> patches/systemvm/debian/config/root/edithosts.sh 1f98fbf
> scripts/network/exdhcp/dnsmasq_edithosts.sh 05285d9
> tools/appliance/definitions/systemvmtemplate/postinstall.sh ae8f1ad
> tools/appliance/definitions/systemvmtemplate64/postinstall.sh ae8f1ad
>
> Diff: https://reviews.apache.org/r/10884/diff/
>
>
> Testing
> -------
>
> Tested in staging VM destroyed and re-instantiated with same IP.
> Did not test adding dnsmasq-utils to system VM build (yet).
>
>
> Thanks,
>
> Dennis Lawler
>
>
Re: Review Request: Release old DHCP entries
Posted by Marcus Sorensen <sh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10884/#review20025
-----------------------------------------------------------
patches/systemvm/debian/config/root/edithosts.sh
<https://reviews.apache.org/r/10884/#comment41259>
shouldn't this be $ipv4?, and if it fails to find the mac in the leases file, will it kill the whole script?
- Marcus Sorensen
On May 1, 2013, 6:41 p.m., Dennis Lawler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10884/
> -----------------------------------------------------------
>
> (Updated May 1, 2013, 6:41 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Release old DHCP entries when adding new entries.
>
> Add dnsmasq-utils to System VM template.
>
>
> This addresses bug CLOUDSTACK-2299.
>
>
> Diffs
> -----
>
> patches/systemvm/debian/config/root/edithosts.sh 1f98fbf
> scripts/network/exdhcp/dnsmasq_edithosts.sh 05285d9
> tools/appliance/definitions/systemvmtemplate/postinstall.sh ae8f1ad
> tools/appliance/definitions/systemvmtemplate64/postinstall.sh ae8f1ad
>
> Diff: https://reviews.apache.org/r/10884/diff/
>
>
> Testing
> -------
>
> Tested in staging VM destroyed and re-instantiated with same IP.
> Did not test adding dnsmasq-utils to system VM build (yet).
>
>
> Thanks,
>
> Dennis Lawler
>
>