You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2021/06/15 16:18:29 UTC

[tomcat] branch main updated: Update comments after change to DEFAULT_OVERHEAD_REDUCTION_FACTOR

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
     new b72e38a  Update comments after change to DEFAULT_OVERHEAD_REDUCTION_FACTOR
b72e38a is described below

commit b72e38adedf6a3f7da0d4e2d7d2c898f44fae2fd
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Tue Jun 15 17:15:02 2021 +0100

    Update comments after change to DEFAULT_OVERHEAD_REDUCTION_FACTOR
---
 java/org/apache/coyote/http2/Http2UpgradeHandler.java | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/java/org/apache/coyote/http2/Http2UpgradeHandler.java b/java/org/apache/coyote/http2/Http2UpgradeHandler.java
index 34601ba..e12daf5 100644
--- a/java/org/apache/coyote/http2/Http2UpgradeHandler.java
+++ b/java/org/apache/coyote/http2/Http2UpgradeHandler.java
@@ -1396,7 +1396,7 @@ class Http2UpgradeHandler extends AbstractStream implements InternalHttpUpgradeH
         // Http2Protocol.DEFAULT_OVERHEAD_REDUCTION_FACTOR. A simple browser
         // request is likely to have one non-overhead frame (HEADERS) and one
         // overhead frame (REPRIORITISE). With the default settings the overhead
-        // count will remain unchanged for each simple request.
+        // count will reduce by 1 for each simple request.
         // Requests and responses with bodies will create additional
         // non-overhead frames, further reducing the overhead count.
         updateOverheadCount(frameType, Http2Protocol.DEFAULT_OVERHEAD_REDUCTION_FACTOR);
@@ -1406,10 +1406,10 @@ class Http2UpgradeHandler extends AbstractStream implements InternalHttpUpgradeH
     private void increaseOverheadCount(FrameType frameType) {
         // An overhead frame increases the overhead count by
         // overheadCountFactor. By default, this means an overhead frame
-        // increases the overhead count by 1. A simple browser request is likely
-        // to have one non-overhead frame (HEADERS) and one overhead frame
-        // (REPRIORITISE). With the default settings the overhead count will
-        // remain unchanged for each simple request.
+        // increases the overhead count by 1. A simple browser request is
+        // likely to have one non-overhead frame (HEADERS) and one overhead
+        // frame (REPRIORITISE). With the default settings the overhead count
+        // will reduce by 1 for each simple request.
         updateOverheadCount(frameType, getProtocol().getOverheadCountFactor());
     }
 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org