[GitHub] [hive] maheshk114 commented on a change in pull request #2224: HIVE-24537: Optimise locking in LlapTaskSchedulerService

[GitBox <gi...@apache.org>]

maheshk114 commented on a change in pull request #2224:
URL: https://github.com/apache/hive/pull/2224#discussion_r638673230



##########
File path: llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java
##########
@@ -1168,16 +1165,13 @@ public void allocateTask(Object task, Resource capability, ContainerId container
         capability, null, null, clock.getTime(), id);
     LOG.info("Received allocateRequest. task={}, priority={}, capability={}, containerId={}",
         task, priority, capability, containerId);
-    writeLock.lock();
-    try {
-      if (!dagRunning && metrics != null && id != null) {
+    if (!dagRunning) {
+      if (metrics != null && id != null) {

Review comment:
       One issue i can see is , we are setting the dagRunning to true without setting any stats. So the stats reading thread may get some junk value for numRequestedAllocations etc. is it fine ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org