You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2017/12/01 21:57:27 UTC

[GitHub] starpit commented on issue #3044: add WhiskActivation.Outcome, hiding Either[ActivationId, WhiskActivation] impl

starpit commented on issue #3044: add WhiskActivation.Outcome, hiding Either[ActivationId, WhiskActivation] impl
URL: https://github.com/apache/incubator-openwhisk/pull/3044#issuecomment-348625041
 
 
   i'm now a bit more skeptical of this PR. any change to `WhiskActivation.Outcome` that moves it away from a type alias will run afoul of the pervasive `Left` and `Right` idioms, not to mention the maps. i.e. the use points all assume that the impl is an `Either`, making it hard to refactor, unless we *also* abstract away the projections...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services