You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Dante-dan (via GitHub)" <gi...@apache.org> on 2026/10/18 11:25:14 UTC
[PR] fix(storage): retry pending context-offload checkpoints [maka]
Dante-dan opened a new pull request, #6151:
URL: https://github.com/apache/maka/pull/6151
## Summary
Retain incomplete PASSIVE checkpoint state after context-offload page reclamation and retry it on later idle calls, including after the freelist drains. The small internal helper reads SQLite's checkpoint result and keeps the retry outside write transactions; pending readers do not turn `hasMore` into a busy loop. The runtime lane remains in #6083 and can reuse the helper.
Fixes #6149
## Verification
- Context-offload store suite: 26/26 passed. The new real-SQLite regression pins a reader across the final batch, checks idle cadence and a competing writer, then verifies the next available idle checkpoint shrinks the file and preserves `quick_check`. It fails against the original store implementation at the file-shrink assertion.
- Passed: `npm run lint`, `npm run format:check`, `npm run build`, `npm run typecheck`, both required `knip` workspace checks, and commit hooks.
- Full storage suite: 1,690 tests, 1,228 passed, 454 failed, 8 skipped. Most failures include sandbox `EPERM` on the OS account's `Library/Application Support/Maka/state-root-owners` or `Library/Caches/Maka`; the run also reported lock/watch timeouts and `io_failure` assertions. This run was not compared against the base and is not claimed green. Node 24.12.0.
## AI use
- [ ] No generative tool made a substantive contribution
- [x] Generative tooling made a substantive contribution
Tool(s) and scope: OpenAI Codex prepared this automated contribution's analysis, implementation, regression test, and PR text. The commit includes `Generated-by: OpenAI Codex`.
## Checklist
- [x] Tests cover the change and fail without it
- [ ] Lint, format, typecheck and the affected suites pass locally
Does this PR entail a change in behavior?
- [x] Yes — described under Summary above
- [ ] No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(storage): retry pending context-offload checkpoints [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han commented on PR #6151:
URL: https://github.com/apache/maka/pull/6151#issuecomment-6312485482
Thanks for retrying incomplete context-offload checkpoints and for the regression coverage. The reviewed head `e6d722e7b6861b92558d924c5f125b569b1e1254` is unchanged, its test checks pass, and it merges cleanly with current main. I am proceeding with the merge at Astro-Han's explicit request.
> **Automated review notice:** This comment was posted by an automated review agent operated by Astro-Han. It is not an independent human review and does not replace one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [PR] fix(storage): retry pending context-offload checkpoints [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han merged PR #6151:
URL: https://github.com/apache/maka/pull/6151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org