You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2018/01/10 00:07:52 UTC
[kudu-CR] Fixup DeltaStats::ToString
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8988
to review the following change.
Change subject: Fixup DeltaStats::ToString
......................................................................
Fixup DeltaStats::ToString
Simplifies the implementation and fixes the mismatched delimiters.
Change-Id: I75f578fa5a858609107e51779fb4e272f6c57a13
---
M src/kudu/tablet/delta_stats.cc
1 file changed, 8 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/8988/1
--
To view, visit http://gerrit.cloudera.org:8080/8988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I75f578fa5a858609107e51779fb4e272f6c57a13
Gerrit-Change-Number: 8988
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Fixup DeltaStats::ToString
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8988 )
Change subject: Fixup DeltaStats::ToString
......................................................................
Fixup DeltaStats::ToString
Simplifies the implementation and fixes the mismatched delimiters.
Change-Id: I75f578fa5a858609107e51779fb4e272f6c57a13
Reviewed-on: http://gerrit.cloudera.org:8080/8988
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/tablet/delta_stats.cc
1 file changed, 8 insertions(+), 12 deletions(-)
Approvals:
Kudu Jenkins: Verified
Todd Lipcon: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/8988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I75f578fa5a858609107e51779fb4e272f6c57a13
Gerrit-Change-Number: 8988
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Fixup DeltaStats::ToString
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8988 )
Change subject: Fixup DeltaStats::ToString
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75f578fa5a858609107e51779fb4e272f6c57a13
Gerrit-Change-Number: 8988
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 10 Jan 2018 01:56:24 +0000
Gerrit-HasComments: No