You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2018/02/03 09:11:16 UTC
[GitHub] spark pull request #20496: Revert "[SPARK-21658][SQL][PYSPARK] Add default N...
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/spark/pull/20496
Revert "[SPARK-21658][SQL][PYSPARK] Add default None for value in na.replace in PySpark"
This reverts commit 0fcde87aadc9a92e138f11583119465ca4b5c518.
See the discussion in [SPARK-21658](https://issues.apache.org/jira/browse/SPARK-21658), [SPARK-19454](https://issues.apache.org/jira/browse/SPARK-19454) and https://github.com/apache/spark/pull/16793
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HyukjinKwon/spark revert-SPARK-21658
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20496.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20496
----
commit 8a9316479b561ccef5e949411f22826d19820874
Author: hyukjinkwon <gu...@...>
Date: 2018-02-03T09:09:32Z
Revert "[SPARK-21658][SQL][PYSPARK] Add default None for value in na.replace in PySpark"
This reverts commit 0fcde87aadc9a92e138f11583119465ca4b5c518.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20496: Revert "[SPARK-21658][SQL][PYSPARK] Add default None for...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/20496
cc @rxin
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20496: Revert "[SPARK-21658][SQL][PYSPARK] Add default None for...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20496
LGTM
Thanks for your quick PR! Merged to master/2.3
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20496: Revert "[SPARK-21658][SQL][PYSPARK] Add default None for...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20496
**[Test build #87028 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87028/testReport)** for PR 20496 at commit [`8a93164`](https://github.com/apache/spark/commit/8a9316479b561ccef5e949411f22826d19820874).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20496: Revert "[SPARK-21658][SQL][PYSPARK] Add default None for...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20496
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20496: Revert "[SPARK-21658][SQL][PYSPARK] Add default None for...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20496
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87028/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20496: Revert "[SPARK-21658][SQL][PYSPARK] Add default None for...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20496
**[Test build #87028 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87028/testReport)** for PR 20496 at commit [`8a93164`](https://github.com/apache/spark/commit/8a9316479b561ccef5e949411f22826d19820874).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20496: Revert "[SPARK-21658][SQL][PYSPARK] Add default N...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20496
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20496: Revert "[SPARK-21658][SQL][PYSPARK] Add default None for...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20496
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20496: Revert "[SPARK-21658][SQL][PYSPARK] Add default None for...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20496
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/562/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org