You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2021/08/22 13:59:27 UTC
[GitHub] [httpcomponents-client] jaikiran opened a new pull request #311: Don't retry a request for NoRouteToHostException
jaikiran opened a new pull request #311:
URL: https://github.com/apache/httpcomponents-client/pull/311
As discussed in the mailing list discussion here[1], the commit here includes `java.net.NoRouteToHostException` to the set of exception types, for which request retries are disabled by default. The commit also has a test case which reproduces the issue and verifies the fix.
I had a look at the `java.net.SocketException` hieararchy. It has `BindException`, `ConnectException`, `NoRouteToHostException` and `PortUnreachableException` as its subclasses. The `BindException` is not relevant while connecting as a client. The `ConnectException` is already included in the default set of non-retriable exception types in this `DefaultHttpRequestRetryHandler` class. The `PortUnreachableException` is for ICMP port unreachable cases, so it isn't relevant in this flow. So that leaves only `NoRouteToHostException` which was missing from this set of non-retriable exception type. Adding this should thus make it behave similar like the `ConnectException` and cover the possible exception types.
P.S: I haven't checked if a similar change is needed in 5.x versions of this library.
[1] https://mail-archives.apache.org/mod_mbox/hc-httpclient-users/202108.mbox/%3C3362ac32-1ced-9aad-36d6-2e0e000168ff%40apache.org%3E
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] jaikiran commented on pull request #311: Don't retry a request for NoRouteToHostException
Posted by GitBox <gi...@apache.org>.
jaikiran commented on pull request #311:
URL: https://github.com/apache/httpcomponents-client/pull/311#issuecomment-904281565
@ok2c, Thank you for the help in reviewing and porting this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c merged pull request #311: Don't retry a request for NoRouteToHostException
Posted by GitBox <gi...@apache.org>.
ok2c merged pull request #311:
URL: https://github.com/apache/httpcomponents-client/pull/311
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] ok2c commented on pull request #311: Don't retry a request for NoRouteToHostException
Posted by GitBox <gi...@apache.org>.
ok2c commented on pull request #311:
URL: https://github.com/apache/httpcomponents-client/pull/311#issuecomment-904100228
@jaikiran Ported to `5.1.x` and `master`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[GitHub] [httpcomponents-client] jaikiran commented on pull request #311: Don't retry a request for NoRouteToHostException
Posted by GitBox <gi...@apache.org>.
jaikiran commented on pull request #311:
URL: https://github.com/apache/httpcomponents-client/pull/311#issuecomment-933124292
Hello @ok2c, would it be possible to do a release of 4.5.x version some time in near future? It looks like the workaround that one of the projects added to get past this issue is no longer applicable in Java 18 https://github.com/quarkusio/quarkus/pull/19559#issuecomment-932987301. So it would be good to have a official release of 4.5.x with this fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org