[jira] [Created] (RAT-209) Ignore short files when checking licenses

["Sebb (JIRA)" <ji...@apache.org>]

Sebb created RAT-209:
------------------------

             Summary: Ignore short files when checking licenses
                 Key: RAT-209
                 URL: https://issues.apache.org/jira/browse/RAT-209
             Project: Apache Rat
          Issue Type: Improvement
            Reporter: Sebb


A license header is not usually required for short files that have no creative content.

For example

{code:title=project.css|borderStyle=solid}
@import url("http://commons.apache.org/style/commons-maven.css");
{code}

It would be useful to be able to ignore these when listing which files don't have headers.

The criteria for ignoring files could be expressed as file size and/or number of lines. The criteria used should be documented on the RAT report.

Files which don't have headers but which fulfil the criteria could either be listed at the end of the report in a separate section from the missing headers, or they could be listed in the main file list with a different category, e.g. NA.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Re: [jira] [Created] (RAT-209) Ignore short files when checking licenses

[sebb <se...@gmail.com>]

On 12 November 2015 at 18:41, P. Ottlinger <po...@apache.org> wrote:
> Hi,
>
> Am 12.11.2015 um 16:39 schrieb Sebb (JIRA):
>> Sebb created RAT-209:
>> ------------------------
>> A license header is not usually required for short files that have no creative content.
>
> I do not really think that this feature is that useful since it adds
> some unclear "guessing" to the otherwise deterministic RAT runs ....

It is fully deterministic. No guessing needed.
The config would specify what criterion to use, e.g.  less than 80 chars.

> what if we miss important files with that fuzzy rule?!

The intention was not to ignore the files completely, just to ignore
them when listing the files without headers.

If a file does not pass the AL check, then see if it is short, and if
so, either report it in a separate section for files that don't need
AL headers.
Or report it with a different tag, e.g. NA.

It's not possible to "miss" files with that approach.

> If you insist on adding it I'd make it optionally configurable.

Yes, it needs to be optional.

> Furthermore I'd prefer to add it after integration Apache Tika to detect
> the type of contents that is scanned ....

It is orthogonal to that, and likely much simpler to add.

> Just my 2ct
>
> Phil

Re: [jira] [Created] (RAT-209) Ignore short files when checking licenses

["P. Ottlinger" <po...@apache.org>]

Hi,

Am 12.11.2015 um 16:39 schrieb Sebb (JIRA):
> Sebb created RAT-209:
> ------------------------
> A license header is not usually required for short files that have no creative content.

I do not really think that this feature is that useful since it adds
some unclear "guessing" to the otherwise deterministic RAT runs ....
what if we miss important files with that fuzzy rule?!

If you insist on adding it I'd make it optionally configurable.

Furthermore I'd prefer to add it after integration Apache Tika to detect
the type of contents that is scanned ....

Just my 2ct

Phil