You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/08/17 08:38:26 UTC
[GitHub] [iceberg] nastra opened a new pull request, #5558: API/Core: Don't track name in Counter/Timer API
nastra opened a new pull request, #5558:
URL: https://github.com/apache/iceberg/pull/5558
´name()` was added to the Counter/Timer API in order to make their
results serializable. In #5427 we realized that we don't necessarily
need to track the name of a particular metric in order to serialize
counter/timer results, thus we're simplifying the Counter/Timer API by
removing `name()`.
Looking at other metric frameworks, they don't track the name of a
metric within the counter/timer itself, but rather in the metric
registry.
In our case this metric registry would be `DefaultMetricsContext` or any
other subclass that implements `MetricsContext`, so tracking the name of
a metric should be the responsibility of this registry rather than the
actual metric itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on pull request #5558: API/Core: Don't track name in Counter/Timer API
Posted by GitBox <gi...@apache.org>.
nastra commented on PR #5558:
URL: https://github.com/apache/iceberg/pull/5558#issuecomment-1219735990
merged with https://github.com/apache/iceberg/pull/5559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra closed pull request #5558: API/Core: Don't track name in Counter/Timer API
Posted by GitBox <gi...@apache.org>.
nastra closed pull request #5558: API/Core: Don't track name in Counter/Timer API
URL: https://github.com/apache/iceberg/pull/5558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org