You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/11/27 08:17:38 UTC
[GitHub] [iotdb] OneSizeFitsQuorum commented on a diff in pull request #8202: Ratis disk usage control
OneSizeFitsQuorum commented on code in PR #8202:
URL: https://github.com/apache/iotdb/pull/8202#discussion_r1032886138
##########
confignode/src/main/java/org/apache/iotdb/confignode/conf/ConfigNodeDescriptor.java:
##########
@@ -691,6 +691,30 @@ private void loadRatisConsensusConfig(Properties properties) {
"ratis_first_election_timeout_max_ms",
String.valueOf(conf.getRatisFirstElectionTimeoutMaxMs()))
.trim()));
+
+ conf.setConfigNodeRatisLogMaxMB(
+ Long.parseLong(
+ properties
+ .getProperty(
+ "config_node_ratis_log_max_size_MB",
Review Comment:
MB -> mb?
##########
confignode/src/main/java/org/apache/iotdb/confignode/conf/ConfigNodeConfig.java:
##########
@@ -247,6 +247,10 @@ public class ConfigNodeConfig {
private long ratisFirstElectionTimeoutMinMs = 50;
private long ratisFirstElectionTimeoutMaxMs = 150;
+ private long configNodeRatisLogMaxMB = 20480;
+ private long schemaRegionRatisLogMaxMB = 20480;
+ private long dataRegionRatisLogMaxMB = 20480;
Review Comment:
maybe we need different default size for different region
##########
confignode/src/main/java/org/apache/iotdb/confignode/conf/ConfigNodeConfig.java:
##########
@@ -247,6 +247,10 @@ public class ConfigNodeConfig {
private long ratisFirstElectionTimeoutMinMs = 50;
private long ratisFirstElectionTimeoutMaxMs = 150;
+ private long configNodeRatisLogMaxMB = 20480;
Review Comment:
20480->20 * 1024?
##########
confignode/src/main/java/org/apache/iotdb/confignode/conf/ConfigNodeDescriptor.java:
##########
@@ -691,6 +691,30 @@ private void loadRatisConsensusConfig(Properties properties) {
"ratis_first_election_timeout_max_ms",
String.valueOf(conf.getRatisFirstElectionTimeoutMaxMs()))
.trim()));
+
+ conf.setConfigNodeRatisLogMaxMB(
+ Long.parseLong(
+ properties
+ .getProperty(
+ "config_node_ratis_log_max_size_MB",
+ String.valueOf(conf.getConfigNodeRatisLogMaxMB()))
+ .trim()));
+
+ conf.setSchemaRegionRatisLogMaxMB(
+ Long.parseLong(
+ properties
+ .getProperty(
+ "schema_region_ratis_log_max_size_MB",
Review Comment:
.
##########
node-commons/src/assembly/resources/conf/iotdb-common.properties:
##########
@@ -931,6 +931,11 @@
# schema_region_ratis_preserve_logs_num_when_purge=1000
# data_region_ratis_preserve_logs_num_when_purge=1000
+# Raft Log disk size control
+# config_node_ratis_log_max_size_MB = 20480
Review Comment:
1. MB -> mb
2. maybe different size
##########
confignode/src/main/java/org/apache/iotdb/confignode/manager/ConsensusManager.java:
##########
@@ -164,6 +164,8 @@ private void setConsensusLayer(ConfigNodeRegionStateMachine stateMachine) throws
CONF.getConfigNodeRatisInitialSleepTimeMs())
.setClientRetryMaxSleepTimeMs(
CONF.getConfigNodeRatisMaxSleepTimeMs())
+ .setTriggerSnapshotFileSize(
+ CONF.getSchemaRegionRatisLogMaxMB() * 1024 * 1024)
Review Comment:
configRegion ?
##########
confignode/src/main/java/org/apache/iotdb/confignode/conf/ConfigNodeDescriptor.java:
##########
@@ -691,6 +691,30 @@ private void loadRatisConsensusConfig(Properties properties) {
"ratis_first_election_timeout_max_ms",
String.valueOf(conf.getRatisFirstElectionTimeoutMaxMs()))
.trim()));
+
+ conf.setConfigNodeRatisLogMaxMB(
+ Long.parseLong(
+ properties
+ .getProperty(
+ "config_node_ratis_log_max_size_MB",
+ String.valueOf(conf.getConfigNodeRatisLogMaxMB()))
+ .trim()));
+
+ conf.setSchemaRegionRatisLogMaxMB(
+ Long.parseLong(
+ properties
+ .getProperty(
+ "schema_region_ratis_log_max_size_MB",
+ String.valueOf(conf.getSchemaRegionRatisLogMaxMB()))
+ .trim()));
+
+ conf.setDataRegionRatisLogMaxMB(
+ Long.parseLong(
+ properties
+ .getProperty(
+ "data_region_ratis_log_max_size_MB",
Review Comment:
.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org