You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2021/03/25 18:44:41 UTC

[GitHub] [thrift] kpy3 opened a new pull request #2357: Remove Erlang R16 support

kpy3 opened a new pull request #2357:
URL: https://github.com/apache/thrift/pull/2357


   Erlang R16 has reached end of life several years ago
   
   <!-- Explain the changes in the pull request below: -->
     
   
   <!-- We recommend you review the checklist/tips before submitting a pull request. -->
   
   - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket?  (not required for trivial changes)
   - [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
   - [ ] Did you squash your changes to a single commit?  (not required, but preferred)
   - [ ] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
   
   <!--
     The Contributing Guide at:
     https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
     has more details and tips for committing properly.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G commented on pull request #2357: THRIFT-5377 Remove Erlang R16 support

Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2357:
URL: https://github.com/apache/thrift/pull/2357#issuecomment-808514771


   Removed last leftover in configure.ac, then merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G commented on pull request #2357: Remove Erlang R16 support

Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2357:
URL: https://github.com/apache/thrift/pull/2357#issuecomment-807485096


   Again? Remove twice?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G edited a comment on pull request #2357: THRIFT-5377 Remove Erlang R16 support

Posted by GitBox <gi...@apache.org>.
Jens-G edited a comment on pull request #2357:
URL: https://github.com/apache/thrift/pull/2357#issuecomment-807485096


   Again? Remove twice? In case you didn't notice, the previous PR #2354 got merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G closed pull request #2357: THRIFT-5377 Remove Erlang R16 support

Posted by GitBox <gi...@apache.org>.
Jens-G closed pull request #2357:
URL: https://github.com/apache/thrift/pull/2357


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] Jens-G commented on pull request #2357: THRIFT-5377 Remove Erlang R16 support

Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2357:
URL: https://github.com/apache/thrift/pull/2357#issuecomment-808175134


   > Should I create another PR for that?
   
   I see, no leave it as it is. I'll look at it as soon as I have the time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [thrift] kpy3 commented on pull request #2357: THRIFT-5377 Remove Erlang R16 support

Posted by GitBox <gi...@apache.org>.
kpy3 commented on pull request #2357:
URL: https://github.com/apache/thrift/pull/2357#issuecomment-807961172


   > Again? Remove twice? In case you didn't notice, the previous PR #2354 got merged.
   
   Oh, sorry missed that! I've found I forgot to cleanup `configure.ac`, help in generator and test and decided to update my open PR. Should I create another PR for that?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org