[jira] [Commented] (AMBARI-17249) Storm metrics sink should include worker host and port to metric name when metrics are coming from SystemBolt

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-17249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15335428#comment-15335428 ] 

Hadoop QA commented on AMBARI-17249:
------------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12811281/AMBARI-17249-v1.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in ambari-metrics/ambari-metrics-storm-sink.

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/7400//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/7400//console

This message is automatically generated.

> Storm metrics sink should include worker host and port to metric name when metrics are coming from SystemBolt
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: AMBARI-17249
>                 URL: https://issues.apache.org/jira/browse/AMBARI-17249
>             Project: Ambari
>          Issue Type: Improvement
>          Components: ambari-metrics
>    Affects Versions: 2.4.0
>            Reporter: Jungtaek Lim
>         Attachments: AMBARI-17249-v1.patch
>
>
> Background: SystemBolt is reserved component for each worker which exposes worker level metrics like Memory, GC, and uptime, and so on.
> All SystemBolts have -1 as task id, so identifying SystemBolt components to task id as same as normal components will fail.
> Since each worker is identified by (worker host, port) pair, we can add hostname and port to metric name to make metric name unique.
> Since it's only for SystemBolt, instead of adding hostname and port to all of metrics, we can add these to specific metrics which are coming from SystemBolt.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)