[GitHub] [pinot] tibrewalpratik17 commented on a diff in pull request #10955: Update pinot client to not use Calcite extractTableNames

["tibrewalpratik17 (via GitHub)" <gi...@apache.org>]

tibrewalpratik17 commented on code in PR #10955:
URL: https://github.com/apache/pinot/pull/10955#discussion_r1238255857


##########
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/Connection.java:
##########
@@ -190,8 +192,10 @@ public Future<ResultSetGroup> executeAsync(@Nullable String tableName, String qu
   private static String[] resolveTableName(String query) {
     try {
       SqlNodeAndOptions sqlNodeAndOptions = CalciteSqlParser.compileToSqlNodeAndOptions(query);
-      List<String> tableNames = CalciteSqlParser.extractTableNamesFromNode(sqlNodeAndOptions.getSqlNode());
-      return tableNames.toArray(new String[0]);
+      String tableName = (sqlNodeAndOptions.getSqlNode() != null

Review Comment:
   @walterddr updated this! 
   
   On a side note, i wonder if we can remove the same logic from here as well - https://github.com/apache/pinot/blob/2b47dd68926dd39da05949fc204388797dfd14cb/pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java#L232



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org