[GitHub] [apisix] spacewander commented on a change in pull request #3006: feat: Add docker image that contains apisix all dependencies

[GitBox <gi...@apache.org>]

spacewander commented on a change in pull request #3006:
URL: https://github.com/apache/apisix/pull/3006#discussion_r539767514



##########
File path: docker/Dockerfile
##########
@@ -0,0 +1,52 @@
+FROM openresty/openresty:alpine-fat AS production-stage
+
+ARG APISIX_VERSION=master
+LABEL apisix_version="${APISIX_VERSION}"
+
+RUN set -x \
+    && /bin/sed -i 's,http://dl-cdn.alpinelinux.org,https://mirrors.aliyun.com,g' /etc/apk/repositories \
+    && apk add --no-cache --virtual .builddeps \
+    automake \
+    autoconf \
+    libtool \
+    pkgconfig \
+    cmake \
+    git \
+    && luarocks install https://github.com/apache/apisix/raw/master/rockspec/apisix-${APISIX_VERSION}-0.rockspec --tree=/usr/local/apisix/deps \
+    && cp -v /usr/local/apisix/deps/lib/luarocks/rocks-5.1/apisix/${APISIX_VERSION}-0/bin/apisix /usr/bin/ \
+    && bin='#! /usr/local/openresty/luajit/bin/luajit\npackage.path = "/usr/local/apisix/?.lua;" .. package.path' \
+    && sed -i "1s@.*@$bin@" /usr/bin/apisix \
+    && mv /usr/local/apisix/deps/share/lua/5.1/apisix /usr/local/apisix \
+    && apk del .builddeps build-base make unzip
+
+FROM alpine:3.11 AS etcd-stage
+
+WORKDIR /tmp
+
+RUN wget https://github.com/etcd-io/etcd/releases/download/v3.4.14/etcd-v3.4.14-linux-amd64.tar.gz \

Review comment:
       Better to put `v3.4.14` into an ARG.

##########
File path: README_CN.md
##########
@@ -151,6 +151,15 @@ A/B 测试、金丝雀发布(灰度发布)、蓝绿部署、限流限速、抵
 
 ## 立刻开始
 
+### 快速体验
+
+使用docker快速build一个包含所有依赖的 apisix 镜像，一键启动。
+
+```shell
+$ docker build -t apache/apisix:whole -f ./docker/Dockerfile .
+$ docker run -v ./docker/config.yaml:/usr/local/apisix/conf/config.yaml -p 9080:9080 -p 2379:2379 -d apache/apisix:whole

Review comment:
       Can we test this build in the CI?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org