You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Ski Gh3 <sk...@gmail.com> on 2009/07/21 20:31:55 UTC

Re: [jira] Updated: (HBASE-1670) transactions / indexing fixes: trx deletes not handeled, index scan can't specify stopRow

Hi Clint,

Are you trying to gradually implement SQL isolation standards or just add
patches as you see fit?

Thanks!

On Tue, Jul 21, 2009 at 10:14 AM, Clint Morgan (JIRA) <ji...@apache.org>wrote:

>
>     [
> https://issues.apache.org/jira/browse/HBASE-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel]
>
> Clint Morgan updated HBASE-1670:
> --------------------------------
>
>     Attachment: 1670-v2.patch
>
> This patch adds the ability to see puts from the current transaction from
> scans in the same transaction. (Previously the trx puts had to be committed
> before scans would see them). I implemented it by passing an additional
> InternalScanner to the getScanner() method which iterates over the put's
> KVs. Added simple tests for this behavior.
>
> Additionally, this patch fixes tests,  addressees some FIXMES, and cleans
> some code.
>
> > transactions / indexing fixes: trx deletes not handeled, index scan can't
> specify stopRow
> >
> -----------------------------------------------------------------------------------------
> >
> >                 Key: HBASE-1670
> >                 URL: https://issues.apache.org/jira/browse/HBASE-1670
> >             Project: Hadoop HBase
> >          Issue Type: Bug
> >            Reporter: Clint Morgan
> >             Fix For: 0.20.0
> >
> >         Attachments: 1670-v2.patch, 1670.patch
> >
> >
> > couple of things I missed in api refactor
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>

Re: [jira] Updated: (HBASE-1670) transactions / indexing fixes: trx deletes not handeled, index scan can't specify stopRow

Posted by Clint Morgan <cl...@troove.net>.
The transactional layer already provides isolation. I don't know about SQL
standards...

This issue is about making scans see the puts that happened in the current
transaction before the commit. Previously you would have to commit the
transaction before you could scan over the rows you put. This is
non-intuitive from a users point of view, and caused a bug in my application
code. And with the 0.20 API change it looks like an easy enough fix, so I
put it in.

But yeah, I'm patching in the support that I need rather than working toward
some standard..

-clint

On Tue, Jul 21, 2009 at 11:31 AM, Ski Gh3 <sk...@gmail.com> wrote:

> Hi Clint,
>
> Are you trying to gradually implement SQL isolation standards or just add
> patches as you see fit?
>
> Thanks!
>
> On Tue, Jul 21, 2009 at 10:14 AM, Clint Morgan (JIRA) <jira@apache.org
> >wrote:
>
> >
> >     [
> >
> https://issues.apache.org/jira/browse/HBASE-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
> >
> > Clint Morgan updated HBASE-1670:
> > --------------------------------
> >
> >     Attachment: 1670-v2.patch
> >
> > This patch adds the ability to see puts from the current transaction from
> > scans in the same transaction. (Previously the trx puts had to be
> committed
> > before scans would see them). I implemented it by passing an additional
> > InternalScanner to the getScanner() method which iterates over the put's
> > KVs. Added simple tests for this behavior.
> >
> > Additionally, this patch fixes tests,  addressees some FIXMES, and cleans
> > some code.
> >
> > > transactions / indexing fixes: trx deletes not handeled, index scan
> can't
> > specify stopRow
> > >
> >
> -----------------------------------------------------------------------------------------
> > >
> > >                 Key: HBASE-1670
> > >                 URL: https://issues.apache.org/jira/browse/HBASE-1670
> > >             Project: Hadoop HBase
> > >          Issue Type: Bug
> > >            Reporter: Clint Morgan
> > >             Fix For: 0.20.0
> > >
> > >         Attachments: 1670-v2.patch, 1670.patch
> > >
> > >
> > > couple of things I missed in api refactor
> >
> > --
> > This message is automatically generated by JIRA.
> > -
> > You can reply to this email to add a comment to the issue online.
> >
> >
>