[jira] [Commented] (IMPALA-11456) Refactor SkipIf logic for filesystems

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-11456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17578266#comment-17578266 ] 

ASF subversion and git services commented on IMPALA-11456:
----------------------------------------------------------

Commit 1eb0510eaa8b54e021847775db32e250775101d9 in impala's branch refs/heads/master from Michael Smith
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=1eb0510ea ]

IMPALA-11456: Collapse filesystem Skip logic

Combines all SkipIf* classes for different filesystems into a single
SkipIfFS class. Many cases are simplified to 'not IS_HDFS', with the
rest as filesystem-specific special cases. The 'jira' option is removed
in favor of specific flags for each issue.

Change-Id: Ib928a6274baaaec45614887b9e762346a25812a1
Reviewed-on: http://gerrit.cloudera.org:8080/18781
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Refactor SkipIf logic for filesystems
> -------------------------------------
>
>                 Key: IMPALA-11456
>                 URL: https://issues.apache.org/jira/browse/IMPALA-11456
>             Project: IMPALA
>          Issue Type: Task
>            Reporter: Michael Smith
>            Assignee: Michael Smith
>            Priority: Minor
>
> The SkipIf py.test logic is pretty fragmented. There are cases where it’s not applied consistently, and I can’t tell if those are mistakes or intentional. And it seems far more granular than it needs to be.
> Refactor SkipIf classes for the filesystem to use a single class to reduce duplication and inconsistency. If special cases are needed for specific filesystems, those will be called out as different skip cases with their own reasons.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org