You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Cody Gibb <co...@gmail.com> on 2016/12/07 00:37:52 UTC

Review Request 54459: Add message parameter to killTasks

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/
-----------------------------------------------------------

Review request for Aurora, Joshua Cohen and Zameer Manji.


Bugs: AURORA-1846
    https://issues.apache.org/jira/browse/AURORA-1846


Repository: aurora


Description
-------

RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.

Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`

In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".


Diffs
-----

  api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7 
  src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80 
  src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 16b1b52f8691d978a9ec1bf7aa0c9716b3484cf0 
  src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1 
  src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc 
  src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d 
  src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38 
  src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff 
  src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7 
  src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61 
  src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b28cd2489a52041a8e7e53f298fad8d8cd29406f 
  src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa 
  src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef 
  src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc 
  src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912 

Diff: https://reviews.apache.org/r/54459/diff/


Testing
-------

Added a unit test in the scheduler, and a test in the client.

Also manually tested using the Vagrant environment.


Thanks,

Cody Gibb

Re: Review Request 54459: Add message parameter to killTasks

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/#review158289
-----------------------------------------------------------


Ship it!




Master (91ddb07) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Dec. 7, 2016, 2:20 a.m., Cody Gibb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54459/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2016, 2:20 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1846
>     https://issues.apache.org/jira/browse/AURORA-1846
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.
> 
> Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`
> 
> In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7 
>   src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 16b1b52f8691d978a9ec1bf7aa0c9716b3484cf0 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1 
>   src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc 
>   src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7 
>   src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b28cd2489a52041a8e7e53f298fad8d8cd29406f 
>   src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef 
>   src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc 
>   src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912 
> 
> Diff: https://reviews.apache.org/r/54459/diff/
> 
> 
> Testing
> -------
> 
> Added a unit test in the scheduler, and a test in the client.
> 
> Also manually tested using the Vagrant environment.
> 
> 
> File Attachments
> ----------------
> 
> "Some message" shown in UI
>   https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png
> 
> 
> Thanks,
> 
> Cody Gibb
> 
>

Re: Review Request 54459: Add message parameter to killTasks

Posted by Zameer Manji <zm...@apache.org>.

> On Dec. 7, 2016, 10:09 a.m., David McLaughlin wrote:
> > LGTM! 
> > 
> > Can you add an end to end test (src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh) for this?
> 
> Cody Gibb wrote:
>     I noticed several of the existing e2e tests simply run a command, and then implicitly assert that the command exits with no errors. Is this what you had in mind for my message test, or should I do some extra work to verify the message was persisted in the task events?
> 
> David McLaughlin wrote:
>     I don't think the message would be visibile in the client anywhere, right?So just making sure that the process still exits OK when the message was supplied should be enough.

Actually, the message should be visible in the ouput of `aurora job status` but we don't really exercise that in the e2e tests.


- Zameer


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/#review158358
-----------------------------------------------------------


On Dec. 6, 2016, 6:20 p.m., Cody Gibb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54459/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2016, 6:20 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1846
>     https://issues.apache.org/jira/browse/AURORA-1846
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.
> 
> Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`
> 
> In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7 
>   src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 16b1b52f8691d978a9ec1bf7aa0c9716b3484cf0 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1 
>   src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc 
>   src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7 
>   src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b28cd2489a52041a8e7e53f298fad8d8cd29406f 
>   src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef 
>   src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc 
>   src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912 
> 
> Diff: https://reviews.apache.org/r/54459/diff/
> 
> 
> Testing
> -------
> 
> Added a unit test in the scheduler, and a test in the client.
> 
> Also manually tested using the Vagrant environment.
> 
> 
> File Attachments
> ----------------
> 
> "Some message" shown in UI
>   https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png
> 
> 
> Thanks,
> 
> Cody Gibb
> 
>

Re: Review Request 54459: Add message parameter to killTasks

Posted by Cody Gibb <co...@gmail.com>.

> On Dec. 7, 2016, 6:09 p.m., David McLaughlin wrote:
> > LGTM! 
> > 
> > Can you add an end to end test (src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh) for this?

I noticed several of the existing e2e tests simply run a command, and then implicitly assert that the command exits with no errors. Is this what you had in mind for my message test, or should I do some extra work to verify the message was persisted in the task events?


- Cody


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/#review158358
-----------------------------------------------------------


On Dec. 7, 2016, 2:20 a.m., Cody Gibb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54459/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2016, 2:20 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1846
>     https://issues.apache.org/jira/browse/AURORA-1846
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.
> 
> Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`
> 
> In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7 
>   src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 16b1b52f8691d978a9ec1bf7aa0c9716b3484cf0 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1 
>   src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc 
>   src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7 
>   src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b28cd2489a52041a8e7e53f298fad8d8cd29406f 
>   src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef 
>   src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc 
>   src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912 
> 
> Diff: https://reviews.apache.org/r/54459/diff/
> 
> 
> Testing
> -------
> 
> Added a unit test in the scheduler, and a test in the client.
> 
> Also manually tested using the Vagrant environment.
> 
> 
> File Attachments
> ----------------
> 
> "Some message" shown in UI
>   https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png
> 
> 
> Thanks,
> 
> Cody Gibb
> 
>

Re: Review Request 54459: Add message parameter to killTasks

Posted by David McLaughlin <da...@dmclaughlin.com>.

> On Dec. 7, 2016, 6:09 p.m., David McLaughlin wrote:
> > LGTM! 
> > 
> > Can you add an end to end test (src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh) for this?
> 
> Cody Gibb wrote:
>     I noticed several of the existing e2e tests simply run a command, and then implicitly assert that the command exits with no errors. Is this what you had in mind for my message test, or should I do some extra work to verify the message was persisted in the task events?

I don't think the message would be visibile in the client anywhere, right?So just making sure that the process still exits OK when the message was supplied should be enough.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/#review158358
-----------------------------------------------------------


On Dec. 7, 2016, 2:20 a.m., Cody Gibb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54459/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2016, 2:20 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1846
>     https://issues.apache.org/jira/browse/AURORA-1846
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.
> 
> Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`
> 
> In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7 
>   src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 16b1b52f8691d978a9ec1bf7aa0c9716b3484cf0 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1 
>   src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc 
>   src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7 
>   src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b28cd2489a52041a8e7e53f298fad8d8cd29406f 
>   src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef 
>   src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc 
>   src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912 
> 
> Diff: https://reviews.apache.org/r/54459/diff/
> 
> 
> Testing
> -------
> 
> Added a unit test in the scheduler, and a test in the client.
> 
> Also manually tested using the Vagrant environment.
> 
> 
> File Attachments
> ----------------
> 
> "Some message" shown in UI
>   https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png
> 
> 
> Thanks,
> 
> Cody Gibb
> 
>

Re: Review Request 54459: Add message parameter to killTasks

Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/#review158358
-----------------------------------------------------------



LGTM! 

Can you add an end to end test (src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh) for this?


src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java (line 56)
<https://reviews.apache.org/r/54459/#comment229123>

    Nit: add a period after getRemoteUserName().


- David McLaughlin


On Dec. 7, 2016, 2:20 a.m., Cody Gibb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54459/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2016, 2:20 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1846
>     https://issues.apache.org/jira/browse/AURORA-1846
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.
> 
> Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`
> 
> In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7 
>   src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 16b1b52f8691d978a9ec1bf7aa0c9716b3484cf0 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1 
>   src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc 
>   src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7 
>   src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b28cd2489a52041a8e7e53f298fad8d8cd29406f 
>   src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef 
>   src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc 
>   src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912 
> 
> Diff: https://reviews.apache.org/r/54459/diff/
> 
> 
> Testing
> -------
> 
> Added a unit test in the scheduler, and a test in the client.
> 
> Also manually tested using the Vagrant environment.
> 
> 
> File Attachments
> ----------------
> 
> "Some message" shown in UI
>   https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png
> 
> 
> Thanks,
> 
> Cody Gibb
> 
>

Re: Review Request 54459: Add message parameter to killTasks

Posted by Cody Gibb <co...@gmail.com>.

> On Jan. 31, 2017, 5:20 p.m., Stephan Erb wrote:
> > What is the status of this?

Still waiting on ship-its -- I'll start pinging people to try and get this accepted.


- Cody


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/#review163678
-----------------------------------------------------------


On Feb. 2, 2017, 12:57 a.m., Cody Gibb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54459/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2017, 12:57 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1846
>     https://issues.apache.org/jira/browse/AURORA-1846
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.
> 
> Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`
> 
> In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7 
>   src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a40114d6c49b3892f21aedddcdd3a414675e39f3 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1 
>   src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc 
>   src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7 
>   src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b7574e45368b877807b6b0b391e0ae4a1610b780 
>   src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef 
>   src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc 
>   src/test/python/apache/aurora/client/hooks/test_hooked_api.py eb97c611d7e17668a3e646722684a847fc491d1a 
>   src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 736d1fcf1d99226efd252336f1630e1f033073ca 
> 
> Diff: https://reviews.apache.org/r/54459/diff/
> 
> 
> Testing
> -------
> 
> Added a unit test in the scheduler, and a test in the client.
> 
> Also manually tested using the Vagrant environment.
> 
> 
> File Attachments
> ----------------
> 
> "Some message" shown in UI
>   https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png
> 
> 
> Thanks,
> 
> Cody Gibb
> 
>

Re: Review Request 54459: Add message parameter to killTasks

Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/#review163678
-----------------------------------------------------------



What is the status of this?

- Stephan Erb


On Dec. 9, 2016, 8:22 p.m., Cody Gibb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54459/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2016, 8:22 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1846
>     https://issues.apache.org/jira/browse/AURORA-1846
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.
> 
> Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`
> 
> In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7 
>   src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 16b1b52f8691d978a9ec1bf7aa0c9716b3484cf0 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1 
>   src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc 
>   src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7 
>   src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b28cd2489a52041a8e7e53f298fad8d8cd29406f 
>   src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef 
>   src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc 
>   src/test/python/apache/aurora/client/hooks/test_hooked_api.py eb97c611d7e17668a3e646722684a847fc491d1a 
>   src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 46309371a33d26bdd467b5fa131634354be2a978 
> 
> Diff: https://reviews.apache.org/r/54459/diff/
> 
> 
> Testing
> -------
> 
> Added a unit test in the scheduler, and a test in the client.
> 
> Also manually tested using the Vagrant environment.
> 
> 
> File Attachments
> ----------------
> 
> "Some message" shown in UI
>   https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png
> 
> 
> Thanks,
> 
> Cody Gibb
> 
>

Re: Review Request 54459: Add message parameter to killTasks

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/#review158713
-----------------------------------------------------------


Ship it!




Master (c8e8953) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Dec. 9, 2016, 7:22 p.m., Cody Gibb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54459/
> -----------------------------------------------------------
> 
> (Updated Dec. 9, 2016, 7:22 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1846
>     https://issues.apache.org/jira/browse/AURORA-1846
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.
> 
> Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`
> 
> In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7 
>   src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 16b1b52f8691d978a9ec1bf7aa0c9716b3484cf0 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1 
>   src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc 
>   src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7 
>   src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b28cd2489a52041a8e7e53f298fad8d8cd29406f 
>   src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef 
>   src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc 
>   src/test/python/apache/aurora/client/hooks/test_hooked_api.py eb97c611d7e17668a3e646722684a847fc491d1a 
>   src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 46309371a33d26bdd467b5fa131634354be2a978 
> 
> Diff: https://reviews.apache.org/r/54459/diff/
> 
> 
> Testing
> -------
> 
> Added a unit test in the scheduler, and a test in the client.
> 
> Also manually tested using the Vagrant environment.
> 
> 
> File Attachments
> ----------------
> 
> "Some message" shown in UI
>   https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png
> 
> 
> Thanks,
> 
> Cody Gibb
> 
>

Re: Review Request 54459: Add message parameter to killTasks

Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/#review163995
-----------------------------------------------------------


Ship it!




Ship It!

- Joshua Cohen


On Feb. 2, 2017, 12:57 a.m., Cody Gibb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54459/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2017, 12:57 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1846
>     https://issues.apache.org/jira/browse/AURORA-1846
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.
> 
> Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`
> 
> In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7 
>   src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a40114d6c49b3892f21aedddcdd3a414675e39f3 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1 
>   src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc 
>   src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7 
>   src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b7574e45368b877807b6b0b391e0ae4a1610b780 
>   src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef 
>   src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc 
>   src/test/python/apache/aurora/client/hooks/test_hooked_api.py eb97c611d7e17668a3e646722684a847fc491d1a 
>   src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 736d1fcf1d99226efd252336f1630e1f033073ca 
> 
> Diff: https://reviews.apache.org/r/54459/diff/
> 
> 
> Testing
> -------
> 
> Added a unit test in the scheduler, and a test in the client.
> 
> Also manually tested using the Vagrant environment.
> 
> 
> File Attachments
> ----------------
> 
> "Some message" shown in UI
>   https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png
> 
> 
> Thanks,
> 
> Cody Gibb
> 
>

Re: Review Request 54459: Add message parameter to killTasks

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/#review164388
-----------------------------------------------------------


Ship it!




Master (7de6d34) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Feb. 6, 2017, 6:40 p.m., Cody Gibb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54459/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2017, 6:40 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1846
>     https://issues.apache.org/jira/browse/AURORA-1846
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.
> 
> Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`
> 
> In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md 05fdfb6f7ec5b19986afbc89de33f2773d62b363 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7 
>   src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a40114d6c49b3892f21aedddcdd3a414675e39f3 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1 
>   src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc 
>   src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7 
>   src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b7574e45368b877807b6b0b391e0ae4a1610b780 
>   src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef 
>   src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc 
>   src/test/python/apache/aurora/client/hooks/test_hooked_api.py eb97c611d7e17668a3e646722684a847fc491d1a 
>   src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 736d1fcf1d99226efd252336f1630e1f033073ca 
> 
> Diff: https://reviews.apache.org/r/54459/diff/
> 
> 
> Testing
> -------
> 
> Added a unit test in the scheduler, and a test in the client.
> 
> Also manually tested using the Vagrant environment.
> 
> 
> File Attachments
> ----------------
> 
> "Some message" shown in UI
>   https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png
> 
> 
> Thanks,
> 
> Cody Gibb
> 
>

Re: Review Request 54459: Add message parameter to killTasks

Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/#review164384
-----------------------------------------------------------



This change is now on master.

- Zameer Manji


On Feb. 6, 2017, 10:40 a.m., Cody Gibb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54459/
> -----------------------------------------------------------
> 
> (Updated Feb. 6, 2017, 10:40 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1846
>     https://issues.apache.org/jira/browse/AURORA-1846
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.
> 
> Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`
> 
> In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md 05fdfb6f7ec5b19986afbc89de33f2773d62b363 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7 
>   src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a40114d6c49b3892f21aedddcdd3a414675e39f3 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1 
>   src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc 
>   src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7 
>   src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b7574e45368b877807b6b0b391e0ae4a1610b780 
>   src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef 
>   src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc 
>   src/test/python/apache/aurora/client/hooks/test_hooked_api.py eb97c611d7e17668a3e646722684a847fc491d1a 
>   src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 736d1fcf1d99226efd252336f1630e1f033073ca 
> 
> Diff: https://reviews.apache.org/r/54459/diff/
> 
> 
> Testing
> -------
> 
> Added a unit test in the scheduler, and a test in the client.
> 
> Also manually tested using the Vagrant environment.
> 
> 
> File Attachments
> ----------------
> 
> "Some message" shown in UI
>   https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png
> 
> 
> Thanks,
> 
> Cody Gibb
> 
>

Re: Review Request 54459: Add message parameter to killTasks

Posted by Cody Gibb <co...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/
-----------------------------------------------------------

(Updated Feb. 6, 2017, 6:40 p.m.)


Review request for Aurora, Joshua Cohen and Zameer Manji.


Changes
-------

Update release notes


Bugs: AURORA-1846
    https://issues.apache.org/jira/browse/AURORA-1846


Repository: aurora


Description
-------

RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.

Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`

In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".


Diffs (updated)
-----

  RELEASE-NOTES.md 05fdfb6f7ec5b19986afbc89de33f2773d62b363 
  api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7 
  src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80 
  src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a40114d6c49b3892f21aedddcdd3a414675e39f3 
  src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1 
  src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc 
  src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d 
  src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38 
  src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff 
  src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7 
  src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61 
  src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b7574e45368b877807b6b0b391e0ae4a1610b780 
  src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa 
  src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef 
  src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc 
  src/test/python/apache/aurora/client/hooks/test_hooked_api.py eb97c611d7e17668a3e646722684a847fc491d1a 
  src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 736d1fcf1d99226efd252336f1630e1f033073ca 

Diff: https://reviews.apache.org/r/54459/diff/


Testing
-------

Added a unit test in the scheduler, and a test in the client.

Also manually tested using the Vagrant environment.


File Attachments
----------------

"Some message" shown in UI
  https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png


Thanks,

Cody Gibb

Re: Review Request 54459: Add message parameter to killTasks

Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/#review164381
-----------------------------------------------------------


Ship it!




Please add an entry in the release notes for 0.18.0 and I'll land this.

- Zameer Manji


On Feb. 1, 2017, 4:57 p.m., Cody Gibb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54459/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2017, 4:57 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1846
>     https://issues.apache.org/jira/browse/AURORA-1846
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.
> 
> Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`
> 
> In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7 
>   src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a40114d6c49b3892f21aedddcdd3a414675e39f3 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1 
>   src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc 
>   src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7 
>   src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b7574e45368b877807b6b0b391e0ae4a1610b780 
>   src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef 
>   src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc 
>   src/test/python/apache/aurora/client/hooks/test_hooked_api.py eb97c611d7e17668a3e646722684a847fc491d1a 
>   src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 736d1fcf1d99226efd252336f1630e1f033073ca 
> 
> Diff: https://reviews.apache.org/r/54459/diff/
> 
> 
> Testing
> -------
> 
> Added a unit test in the scheduler, and a test in the client.
> 
> Also manually tested using the Vagrant environment.
> 
> 
> File Attachments
> ----------------
> 
> "Some message" shown in UI
>   https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png
> 
> 
> Thanks,
> 
> Cody Gibb
> 
>

Re: Review Request 54459: Add message parameter to killTasks

Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/#review163922
-----------------------------------------------------------



@ReviewBot retry

- Zameer Manji


On Feb. 1, 2017, 4:57 p.m., Cody Gibb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54459/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2017, 4:57 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1846
>     https://issues.apache.org/jira/browse/AURORA-1846
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.
> 
> Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`
> 
> In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7 
>   src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a40114d6c49b3892f21aedddcdd3a414675e39f3 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1 
>   src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc 
>   src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7 
>   src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b7574e45368b877807b6b0b391e0ae4a1610b780 
>   src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef 
>   src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc 
>   src/test/python/apache/aurora/client/hooks/test_hooked_api.py eb97c611d7e17668a3e646722684a847fc491d1a 
>   src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 736d1fcf1d99226efd252336f1630e1f033073ca 
> 
> Diff: https://reviews.apache.org/r/54459/diff/
> 
> 
> Testing
> -------
> 
> Added a unit test in the scheduler, and a test in the client.
> 
> Also manually tested using the Vagrant environment.
> 
> 
> File Attachments
> ----------------
> 
> "Some message" shown in UI
>   https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png
> 
> 
> Thanks,
> 
> Cody Gibb
> 
>

Re: Review Request 54459: Add message parameter to killTasks

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/#review163923
-----------------------------------------------------------


Ship it!




Master (7de6d34) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Feb. 2, 2017, 12:57 a.m., Cody Gibb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54459/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2017, 12:57 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1846
>     https://issues.apache.org/jira/browse/AURORA-1846
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.
> 
> Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`
> 
> In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7 
>   src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a40114d6c49b3892f21aedddcdd3a414675e39f3 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1 
>   src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc 
>   src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7 
>   src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b7574e45368b877807b6b0b391e0ae4a1610b780 
>   src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef 
>   src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc 
>   src/test/python/apache/aurora/client/hooks/test_hooked_api.py eb97c611d7e17668a3e646722684a847fc491d1a 
>   src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 736d1fcf1d99226efd252336f1630e1f033073ca 
> 
> Diff: https://reviews.apache.org/r/54459/diff/
> 
> 
> Testing
> -------
> 
> Added a unit test in the scheduler, and a test in the client.
> 
> Also manually tested using the Vagrant environment.
> 
> 
> File Attachments
> ----------------
> 
> "Some message" shown in UI
>   https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png
> 
> 
> Thanks,
> 
> Cody Gibb
> 
>

Re: Review Request 54459: Add message parameter to killTasks

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/#review163921
-----------------------------------------------------------



Master (7de6d34) is red with this patch.
  ./build-support/jenkins/build.sh

  creating build/temp.linux-x86_64-2.7
  creating build/temp.linux-x86_64-2.7/lmdb
  creating build/temp.linux-x86_64-2.7/lib
  x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -Ilib/py-lmdb -Ilib -I/usr/include/python2.7 -c lmdb/cpython.c -o build/temp.linux-x86_64-2.7/lmdb/cpython.o -UNDEBUG -w
  x86_64-linux-gnu-gcc -pthread -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fno-strict-aliasing -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -fPIC -Ilib/py-lmdb -Ilib -I/usr/include/python2.7 -c lib/mdb.c -o build/temp.linux-x86_64-2.7/lib/mdb.o -UNDEBUG -w
  Assembler messages:
  Fatal error: can't create build/temp.linux-x86_64-2.7/lib/mdb.o: No such file or directory
  error: command 'x86_64-linux-gnu-gcc' failed with exit status 1
  
  ----------------------------------------
  Failed building wheel for lmdb
  Running setup.py clean for lmdb
Exception:
Traceback (most recent call last):
  File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/pants.HrWD8h/install/local/lib/python2.7/site-packages/pip/basecommand.py", line 215, in main
    status = self.run(options, args)
  File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/pants.HrWD8h/install/local/lib/python2.7/site-packages/pip/commands/install.py", line 310, in run
    wb.build(autobuilding=True)
  File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/pants.HrWD8h/install/local/lib/python2.7/site-packages/pip/wheel.py", line 814, in build
    python_tag=python_tag,
  File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/pants.HrWD8h/install/local/lib/python2.7/site-packages/pip/wheel.py", line 700, in _build_one
    rmtree(tempd)
  File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/pants.HrWD8h/install/local/lib/python2.7/site-packages/pip/_vendor/retrying.py", line 49, in wrapped_f
    return Retrying(*dargs, **dkw).call(f, *args, **kw)
  File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/pants.HrWD8h/install/local/lib/python2.7/site-packages/pip/_vendor/retrying.py", line 212, in call
    raise attempt.get()
  File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/pants.HrWD8h/install/local/lib/python2.7/site-packages/pip/_vendor/retrying.py", line 247, in get
    six.reraise(self.value[0], self.value[1], self.value[2])
  File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/pants.HrWD8h/install/local/lib/python2.7/site-packages/pip/_vendor/retrying.py", line 200, in call
    attempt = Attempt(fn(*args, **kwargs), attempt_number, False)
  File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/pants.HrWD8h/install/local/lib/python2.7/site-packages/pip/utils/__init__.py", line 102, in rmtree
    onerror=rmtree_errorhandler)
  File "/usr/lib/python2.7/shutil.py", line 239, in rmtree
    onerror(os.listdir, path, sys.exc_info())
  File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/pants.HrWD8h/install/local/lib/python2.7/site-packages/pip/utils/__init__.py", line 110, in rmtree_errorhandler
    if os.stat(path).st_mode & stat.S_IREAD:
OSError: [Errno 2] No such file or directory: '/tmp/tmpZOIF9Spip-wheel-'
You are using pip version 8.1.2, however version 9.0.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/python/../../pants: line 99: /home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pants/setup/bootstrap-Linux-x86_64/1.3.0.dev3/bin/python: No such file or directory


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Feb. 2, 2017, 12:57 a.m., Cody Gibb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54459/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2017, 12:57 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1846
>     https://issues.apache.org/jira/browse/AURORA-1846
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.
> 
> Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`
> 
> In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7 
>   src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a40114d6c49b3892f21aedddcdd3a414675e39f3 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1 
>   src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc 
>   src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7 
>   src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b7574e45368b877807b6b0b391e0ae4a1610b780 
>   src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef 
>   src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc 
>   src/test/python/apache/aurora/client/hooks/test_hooked_api.py eb97c611d7e17668a3e646722684a847fc491d1a 
>   src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 736d1fcf1d99226efd252336f1630e1f033073ca 
> 
> Diff: https://reviews.apache.org/r/54459/diff/
> 
> 
> Testing
> -------
> 
> Added a unit test in the scheduler, and a test in the client.
> 
> Also manually tested using the Vagrant environment.
> 
> 
> File Attachments
> ----------------
> 
> "Some message" shown in UI
>   https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png
> 
> 
> Thanks,
> 
> Cody Gibb
> 
>

Re: Review Request 54459: Add message parameter to killTasks

Posted by Cody Gibb <co...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/
-----------------------------------------------------------

(Updated Feb. 2, 2017, 12:57 a.m.)


Review request for Aurora, Joshua Cohen and Zameer Manji.


Changes
-------

Fix unused import


Bugs: AURORA-1846
    https://issues.apache.org/jira/browse/AURORA-1846


Repository: aurora


Description
-------

RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.

Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`

In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".


Diffs (updated)
-----

  api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7 
  src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80 
  src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a40114d6c49b3892f21aedddcdd3a414675e39f3 
  src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1 
  src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc 
  src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d 
  src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38 
  src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff 
  src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7 
  src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61 
  src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b7574e45368b877807b6b0b391e0ae4a1610b780 
  src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa 
  src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef 
  src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc 
  src/test/python/apache/aurora/client/hooks/test_hooked_api.py eb97c611d7e17668a3e646722684a847fc491d1a 
  src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 736d1fcf1d99226efd252336f1630e1f033073ca 

Diff: https://reviews.apache.org/r/54459/diff/


Testing
-------

Added a unit test in the scheduler, and a test in the client.

Also manually tested using the Vagrant environment.


File Attachments
----------------

"Some message" shown in UI
  https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png


Thanks,

Cody Gibb

Re: Review Request 54459: Add message parameter to killTasks

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/#review163916
-----------------------------------------------------------



Master (7de6d34) is red with this patch.
  ./build-support/jenkins/build.sh

:commons:processResources
:commons:classes
:commons:jar
:compileJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java:74: Note: Wrote forwarder org.apache.aurora.scheduler.storage.log.WriteAheadStorageForwarder
@Forward({
^
Note: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/org/apache/aurora/common/args/apt/cmdline.arg.info.txt.2
Note: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/META-INF/compiler/resource-mappings/org.apache.aurora.common.args.apt.CmdLineProcessor

:generateBuildProperties
:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileJmhJavaNote: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.

:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java:41: Wrong order for 'org.apache.aurora.common.args.OptionInfo' import. Order should be: java, javax, scala, com, net, org.         Each group should be separated by a single blank line. [ImportOrder]
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java:41:8: Unused import - org.apache.aurora.common.args.OptionInfo. [UnusedImports]
 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 1 mins 14.04 secs


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Feb. 2, 2017, 12:43 a.m., Cody Gibb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54459/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2017, 12:43 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1846
>     https://issues.apache.org/jira/browse/AURORA-1846
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.
> 
> Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`
> 
> In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7 
>   src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a40114d6c49b3892f21aedddcdd3a414675e39f3 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1 
>   src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc 
>   src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7 
>   src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b7574e45368b877807b6b0b391e0ae4a1610b780 
>   src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef 
>   src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc 
>   src/test/python/apache/aurora/client/hooks/test_hooked_api.py eb97c611d7e17668a3e646722684a847fc491d1a 
>   src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912 
>   src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 736d1fcf1d99226efd252336f1630e1f033073ca 
> 
> Diff: https://reviews.apache.org/r/54459/diff/
> 
> 
> Testing
> -------
> 
> Added a unit test in the scheduler, and a test in the client.
> 
> Also manually tested using the Vagrant environment.
> 
> 
> File Attachments
> ----------------
> 
> "Some message" shown in UI
>   https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png
> 
> 
> Thanks,
> 
> Cody Gibb
> 
>

Re: Review Request 54459: Add message parameter to killTasks

Posted by Cody Gibb <co...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/
-----------------------------------------------------------

(Updated Feb. 2, 2017, 12:43 a.m.)


Review request for Aurora, Joshua Cohen and Zameer Manji.


Changes
-------

Rebase


Bugs: AURORA-1846
    https://issues.apache.org/jira/browse/AURORA-1846


Repository: aurora


Description
-------

RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.

Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`

In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".


Diffs (updated)
-----

  api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7 
  src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80 
  src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a40114d6c49b3892f21aedddcdd3a414675e39f3 
  src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1 
  src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc 
  src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d 
  src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38 
  src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff 
  src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7 
  src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61 
  src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b7574e45368b877807b6b0b391e0ae4a1610b780 
  src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa 
  src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef 
  src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc 
  src/test/python/apache/aurora/client/hooks/test_hooked_api.py eb97c611d7e17668a3e646722684a847fc491d1a 
  src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 736d1fcf1d99226efd252336f1630e1f033073ca 

Diff: https://reviews.apache.org/r/54459/diff/


Testing
-------

Added a unit test in the scheduler, and a test in the client.

Also manually tested using the Vagrant environment.


File Attachments
----------------

"Some message" shown in UI
  https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png


Thanks,

Cody Gibb

Re: Review Request 54459: Add message parameter to killTasks

Posted by Cody Gibb <co...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/
-----------------------------------------------------------

(Updated Dec. 9, 2016, 7:22 p.m.)


Review request for Aurora, Joshua Cohen and Zameer Manji.


Changes
-------

Address comments:
- Write end-to-end test
- Fix indentation issues
- Fix client message/config parameter ordering + fix client test dependent on ordering
- Add period delimiter to message


Bugs: AURORA-1846
    https://issues.apache.org/jira/browse/AURORA-1846


Repository: aurora


Description
-------

RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.

Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`

In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".


Diffs (updated)
-----

  api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7 
  src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80 
  src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 16b1b52f8691d978a9ec1bf7aa0c9716b3484cf0 
  src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1 
  src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc 
  src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d 
  src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38 
  src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff 
  src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7 
  src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61 
  src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b28cd2489a52041a8e7e53f298fad8d8cd29406f 
  src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa 
  src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef 
  src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc 
  src/test/python/apache/aurora/client/hooks/test_hooked_api.py eb97c611d7e17668a3e646722684a847fc491d1a 
  src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912 
  src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 46309371a33d26bdd467b5fa131634354be2a978 

Diff: https://reviews.apache.org/r/54459/diff/


Testing
-------

Added a unit test in the scheduler, and a test in the client.

Also manually tested using the Vagrant environment.


File Attachments
----------------

"Some message" shown in UI
  https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png


Thanks,

Cody Gibb

Re: Review Request 54459: Add message parameter to killTasks

Posted by Cody Gibb <co...@gmail.com>.

> On Dec. 7, 2016, 6:52 p.m., Joshua Cohen wrote:
> > src/main/python/apache/aurora/client/hooks/hooked_api.py, line 55
> > <https://reviews.apache.org/r/54459/diff/2/?file=1578419#file1578419line55>
> >
> >     Let's not change the argument order on these methods? It's possible someone has a custom hook defined somewhere that isn't passing these as named args.

There's actually a test that asserts certain methods of the NonHookedAuroraClientAPI (kill_job, restart, start_cronjob) have the exact same spec as the AuroraClientAPI, but with a `config` parameter appended.

`assert nonhooked_argspec.args[len(api_argspec.args)] == 'config'`

Moving message to the last parameter would break this pattern \u2014�do you think asserting `'config' in nonhooked_argspec.args` would be a sufficient check instead?


- Cody


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/#review158290
-----------------------------------------------------------


On Dec. 7, 2016, 2:20 a.m., Cody Gibb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54459/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2016, 2:20 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1846
>     https://issues.apache.org/jira/browse/AURORA-1846
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.
> 
> Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`
> 
> In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7 
>   src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 16b1b52f8691d978a9ec1bf7aa0c9716b3484cf0 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1 
>   src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc 
>   src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7 
>   src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b28cd2489a52041a8e7e53f298fad8d8cd29406f 
>   src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef 
>   src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc 
>   src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912 
> 
> Diff: https://reviews.apache.org/r/54459/diff/
> 
> 
> Testing
> -------
> 
> Added a unit test in the scheduler, and a test in the client.
> 
> Also manually tested using the Vagrant environment.
> 
> 
> File Attachments
> ----------------
> 
> "Some message" shown in UI
>   https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png
> 
> 
> Thanks,
> 
> Cody Gibb
> 
>

Re: Review Request 54459: Add message parameter to killTasks

Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/#review158290
-----------------------------------------------------------



Thanks for the patch! Looks good to me overall, a few comments below, almost entirely style-based. +1 to David's suggestion to add to the end to end tests, and if you could also add a note to RELEASE-NOTES.md, that'd be great.


src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java (lines 429 - 430)
<https://reviews.apache.org/r/54459/#comment229059>

    Formatting for continuation indents should be:
    
        public Response killTasks(
            @Nullable JobKey mutableJob,
            ...
            ...) {
    
          // code continues here, after blank line



src/main/python/apache/aurora/client/hooks/hooked_api.py (line 55)
<https://reviews.apache.org/r/54459/#comment229061>

    Let's not change the argument order on these methods? It's possible someone has a custom hook defined somewhere that isn't passing these as named args.



src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java (lines 35 - 37)
<https://reviews.apache.org/r/54459/#comment229062>

    Fix indentation (should be 4 spaces for continuation).



src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java (lines 52 - 53)
<https://reviews.apache.org/r/54459/#comment229063>

    Same here.



src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java (lines 67 - 72)
<https://reviews.apache.org/r/54459/#comment229064>

    And here.



src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java (lines 608 - 612)
<https://reviews.apache.org/r/54459/#comment229065>

    Fix indent.


- Joshua Cohen


On Dec. 7, 2016, 2:20 a.m., Cody Gibb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54459/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2016, 2:20 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1846
>     https://issues.apache.org/jira/browse/AURORA-1846
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.
> 
> Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`
> 
> In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7 
>   src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 16b1b52f8691d978a9ec1bf7aa0c9716b3484cf0 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1 
>   src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc 
>   src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7 
>   src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b28cd2489a52041a8e7e53f298fad8d8cd29406f 
>   src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef 
>   src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc 
>   src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912 
> 
> Diff: https://reviews.apache.org/r/54459/diff/
> 
> 
> Testing
> -------
> 
> Added a unit test in the scheduler, and a test in the client.
> 
> Also manually tested using the Vagrant environment.
> 
> 
> File Attachments
> ----------------
> 
> "Some message" shown in UI
>   https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png
> 
> 
> Thanks,
> 
> Cody Gibb
> 
>

Re: Review Request 54459: Add message parameter to killTasks

Posted by Cody Gibb <co...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/
-----------------------------------------------------------

(Updated Dec. 7, 2016, 2:20 a.m.)


Review request for Aurora, Joshua Cohen and Zameer Manji.


Changes
-------

- Fix style problem
- Add test to scheduler which verifies the actual message formation


Bugs: AURORA-1846
    https://issues.apache.org/jira/browse/AURORA-1846


Repository: aurora


Description
-------

RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.

Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`

In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".


Diffs (updated)
-----

  api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7 
  src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80 
  src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 16b1b52f8691d978a9ec1bf7aa0c9716b3484cf0 
  src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1 
  src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc 
  src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d 
  src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38 
  src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff 
  src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7 
  src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61 
  src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b28cd2489a52041a8e7e53f298fad8d8cd29406f 
  src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa 
  src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef 
  src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc 
  src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912 

Diff: https://reviews.apache.org/r/54459/diff/


Testing
-------

Added a unit test in the scheduler, and a test in the client.

Also manually tested using the Vagrant environment.


File Attachments
----------------

"Some message" shown in UI
  https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png


Thanks,

Cody Gibb

Re: Review Request 54459: Add message parameter to killTasks

Posted by Cody Gibb <co...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/
-----------------------------------------------------------

(Updated Dec. 7, 2016, 12:58 a.m.)


Review request for Aurora, Joshua Cohen and Zameer Manji.


Changes
-------

Added screenshot of UI.


Bugs: AURORA-1846
    https://issues.apache.org/jira/browse/AURORA-1846


Repository: aurora


Description
-------

RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.

Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`

In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".


Diffs
-----

  api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7 
  src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80 
  src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 16b1b52f8691d978a9ec1bf7aa0c9716b3484cf0 
  src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1 
  src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc 
  src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d 
  src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38 
  src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff 
  src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7 
  src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61 
  src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b28cd2489a52041a8e7e53f298fad8d8cd29406f 
  src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa 
  src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef 
  src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc 
  src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912 

Diff: https://reviews.apache.org/r/54459/diff/


Testing
-------

Added a unit test in the scheduler, and a test in the client.

Also manually tested using the Vagrant environment.


File Attachments (updated)
----------------

"Some message" shown in UI
  https://reviews.apache.org/media/uploaded/files/2016/12/07/9ab25047-4418-4121-906c-380ded9e1962__Screen_Shot_2016-12-06_at_4.56.43_PM.png


Thanks,

Cody Gibb

Re: Review Request 54459: Add message parameter to killTasks

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54459/#review158280
-----------------------------------------------------------



Master (91ddb07) is red with this patch.
  ./build-support/jenkins/build.sh

  Running setup.py bdist_wheel for cov-core: started
  Running setup.py bdist_wheel for cov-core: finished with status 'done'
  Stored in directory: /home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pip/wheels/86/e1/c2/9ff8cfe9773ce07003f2c2be096e169af4614c2f634671d49b
  Running setup.py bdist_wheel for pycparser: started
  Running setup.py bdist_wheel for pycparser: finished with status 'done'
  Stored in directory: /home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pip/wheels/a8/0b/41/dc95621f9d3a0da7bc191b8a71f0e8182ffd3cc5f33ac55005
  Running setup.py bdist_wheel for twitter.common.options: started
  Running setup.py bdist_wheel for twitter.common.options: finished with status 'done'
  Stored in directory: /home/jenkins/jenkins-slave/workspace/AuroraBot/.home/.cache/pip/wheels/17/41/80/c4811d8c1c7ca7007e520c3399872fc340f45c3a26a6a23e6a
Successfully built pantsbuild.pants twitter.common.collections setproctitle ansicolors pathspec scandir twitter.common.dirutil pystache psutil docutils Markdown Pygments twitter.common.confluence coverage pytest pytest-cov lmdb pywatchman twitter.common.lang twitter.common.log cov-core pycparser twitter.common.options
Installing collected packages: twitter.common.lang, twitter.common.collections, setproctitle, setuptools, six, ansicolors, pyparsing, packaging, pathspec, scandir, twitter.common.dirutil, requests, pystache, psutil, pex, docutils, Markdown, Pygments, twitter.common.options, twitter.common.log, twitter.common.confluence, monotonic, fasteners, coverage, py, pytest, cov-core, pytest-cov, futures, pycparser, cffi, lmdb, pywatchman, pantsbuild.pants
  Found existing installation: setuptools 21.2.1
    Uninstalling setuptools-21.2.1:
      Successfully uninstalled setuptools-21.2.1
Successfully installed Markdown-2.1.1 Pygments-1.4 ansicolors-1.0.2 cffi-1.7.0 cov-core-1.15.0 coverage-3.7.1 docutils-0.12 fasteners-0.14.1 futures-3.0.5 lmdb-0.89 monotonic-1.2 packaging-16.7 pantsbuild.pants-1.3.0.dev0 pathspec-0.3.4 pex-1.1.13 psutil-4.3.0 py-1.4.31 pycparser-2.17 pyparsing-2.1.10 pystache-0.5.3 pytest-2.6.4 pytest-cov-1.8.1 pywatchman-1.3.0 requests-2.5.3 scandir-1.2 setproctitle-1.1.10 setuptools-5.4.1 six-1.10.0 twitter.common.collections-0.3.9 twitter.common.confluence-0.3.9 twitter.common.dirutil-0.3.9 twitter.common.lang-0.3.9 twitter.common.log-0.3.9 twitter.common.options-0.3.9
You are using pip version 8.1.2, however version 9.0.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.

00:47:05 00:00 [main]
               (To run a reporting server: ./pants server)
00:47:05 00:00   [setup]
00:47:05 00:00     [parse]
               Executing tasks in goals: compile
00:47:05 00:00   [compile]
00:47:05 00:00     [compile-prep-command]
00:47:05 00:00     [compile]
00:47:05 00:00     [python-eval]
00:47:05 00:00     [pythonstyle]
00:47:05 00:00       [cache]                                           
                   No cached artifacts for 43 targets.
                   Invalidated 43 targets.
E501:ERROR   PythonFile(src/test/python/apache/aurora/client/cli/test_kill.py):256 line too long (101 > 100 characters)
     |      kill_calls = [call(cls.TEST_JOBKEY, [i], config=None, message=message) for i in instance_range]


FAILURE: 1 Python Style issues found. For import order related issues, please try `./pants fmt.isort <targets>`


00:47:30 00:25   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Dec. 7, 2016, 12:37 a.m., Cody Gibb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54459/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2016, 12:37 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Bugs: AURORA-1846
>     https://issues.apache.org/jira/browse/AURORA-1846
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> RPC's such as pauseJobUpdate include a parameter for "a user-specified message to include with the induced job update state change." This diff provides a similar optional parameter for the killTasks RPC, which allows users to indicate the reason why a task was killed, and later inspect that reason when consuming task events.
> 
> Example usage from Aurora CLI: `$ aurora job killall devcluster/www-data/prod/hello --message "Some message"`
> 
> In the task event, the supplied message (if provided) is appended to the existing template "Killed by <user>", separated by a newline. For the above example, this looks like: "Killed by aurora\nSome message".
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift c3ec96584d7acdc50c80fc629f8cff61f2d206d7 
>   src/main/java/org/apache/aurora/scheduler/thrift/AuditMessages.java a7aecedcab7a5ae116b0536fe7831689e065ea80 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 16b1b52f8691d978a9ec1bf7aa0c9716b3484cf0 
>   src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java bfc3dc868b2b52d3ccf6a7c54039ed75fe0501a1 
>   src/main/python/apache/aurora/client/api/__init__.py e1dde638bd1d686269fbcd88cb083a52e7f5dbfc 
>   src/main/python/apache/aurora/client/cli/jobs.py 8ba41aa914f7ddd301891f67dd763ba50a977a9d 
>   src/main/python/apache/aurora/client/hooks/hooked_api.py 86c3a09481d0504690439b608c269285b9cc2a38 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/HttpSecurityIT.java b20900da82915f429c35a68775b2106fb15394ff 
>   src/test/java/org/apache/aurora/scheduler/http/api/security/ShiroAuthorizingParamInterceptorTest.java 05f4a18938be8075e487478cab06ff51874e08a7 
>   src/test/java/org/apache/aurora/scheduler/thrift/AuditMessagesTest.java 9c8460ce206eb13b4b9910d76d6fcade439c9c61 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java b28cd2489a52041a8e7e53f298fad8d8cd29406f 
>   src/test/python/apache/aurora/api_util.py 983cde48a48bc2388e8535c3d17b867373c8dcaa 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py f6018caa4f431e85a9e9ff203ac3d4b6c33f40ef 
>   src/test/python/apache/aurora/client/cli/test_kill.py 564ea440983359ae3c382c58aa249965752fedbc 
>   src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py 04b2257cb7e4e78ab90564ab27b160de2b1c8912 
> 
> Diff: https://reviews.apache.org/r/54459/diff/
> 
> 
> Testing
> -------
> 
> Added a unit test in the scheduler, and a test in the client.
> 
> Also manually tested using the Vagrant environment.
> 
> 
> Thanks,
> 
> Cody Gibb
> 
>