You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2019/01/11 20:03:08 UTC
[kudu-CR] [docs] Add docs for rack/location-awareness
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12219
Change subject: [docs] Add docs for rack/location-awareness
......................................................................
[docs] Add docs for rack/location-awareness
I stuck to the name "rack-awareness" throughout, preferring it to the
term we have used internally, "location-awareness", because even though
the latter term is more technically correct, the former is the more
typical and colloquial name for this sort of thing.
These docs borrow heavily from the WIP blog post written by Alexey.
Change-Id: I505b7fd545a4253170a5b7cac63c33e7d9669490
---
M docs/administration.adoc
1 file changed, 102 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/12219/1
--
To view, visit http://gerrit.cloudera.org:8080/12219
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I505b7fd545a4253170a5b7cac63c33e7d9669490
Gerrit-Change-Number: 12219
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] [docs] Add docs for rack/location-awareness
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12219 )
Change subject: [docs] Add docs for rack/location-awareness
......................................................................
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/12219/2/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/12219/2/docs/administration.adoc@218
PS2, Line 218: and where
: each `/`-separated component
nit: reads a bit funny imo, maybe "a `/`-separated string ... in which each `/`-separated component ..."?
http://gerrit.cloudera.org:8080/#/c/12219/2/docs/administration.adoc@239
PS2, Line 239: `/L0`, `/L1`, `/L1`, `/L2`
May want to specify how the policy will handle multi-component locations. E.g. in /D0/L0, /D0/L1, /D2/L2, /D3/L3, does it weigh the fact that /D0/L0 and /D0/L1 share a common ancestor vs /D0/L0 and /D3/L3? Or is the fact that the locations are different sufficient?
http://gerrit.cloudera.org:8080/#/c/12219/2/docs/administration.adoc@1348
PS2, Line 1348: establish the placement policy
What does this mean?
http://gerrit.cloudera.org:8080/#/c/12219/2/docs/administration.adoc@1354
PS2, Line 1354: `
nit: flag
--
To view, visit http://gerrit.cloudera.org:8080/12219
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I505b7fd545a4253170a5b7cac63c33e7d9669490
Gerrit-Change-Number: 12219
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 11 Jan 2019 20:59:16 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add docs for rack/location-awareness
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12219 )
Change subject: [docs] Add docs for rack/location-awareness
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@256
PS1, Line 256: the pl
> One cannot "reestablish" or "restore" the placement policy on a cluster tha
I like your new approach more actually. I don't think you can "conform" something; something can only conform or not. Active vs. passive voice?
http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@258
PS1, Line 258: more
> Tablets aren't moved; replicas are. Tablets are fixed (re the placement pol
Sounds good.
--
To view, visit http://gerrit.cloudera.org:8080/12219
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I505b7fd545a4253170a5b7cac63c33e7d9669490
Gerrit-Change-Number: 12219
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 11 Jan 2019 22:53:41 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add docs for rack/location-awareness
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12219 )
Change subject: [docs] Add docs for rack/location-awareness
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12219/2/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/12219/2/docs/administration.adoc@1348
PS2, Line 1348:
> Ask Adar :)
FWIW I think "conform" as in "tries to force the cluster to conform to the placement policy" was clearer.
http://gerrit.cloudera.org:8080/#/c/12219/3/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/12219/3/docs/administration.adoc@1344
PS3, Line 1344: establish the placement policy on a
: cluster to the placement policy
Missed this before, this doesn't read quite right.
--
To view, visit http://gerrit.cloudera.org:8080/12219
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I505b7fd545a4253170a5b7cac63c33e7d9669490
Gerrit-Change-Number: 12219
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 11 Jan 2019 23:21:40 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add docs for rack/location-awareness
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12219 )
Change subject: [docs] Add docs for rack/location-awareness
......................................................................
Patch Set 1: Verified+1
Docs-only change.
--
To view, visit http://gerrit.cloudera.org:8080/12219
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I505b7fd545a4253170a5b7cac63c33e7d9669490
Gerrit-Change-Number: 12219
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 11 Jan 2019 20:03:48 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Add docs for rack/location-awareness
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12219
to look at the new patch set (#2).
Change subject: [docs] Add docs for rack/location-awareness
......................................................................
[docs] Add docs for rack/location-awareness
I stuck to the name "rack-awareness" throughout, preferring it to the
term we have used internally, "location-awareness", because even though
the latter term is more technically correct, the former is the more
typical and colloquial name for this sort of thing.
These docs borrow heavily from the WIP blog post written by Alexey.
Change-Id: I505b7fd545a4253170a5b7cac63c33e7d9669490
---
M docs/administration.adoc
1 file changed, 99 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/12219/2
--
To view, visit http://gerrit.cloudera.org:8080/12219
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I505b7fd545a4253170a5b7cac63c33e7d9669490
Gerrit-Change-Number: 12219
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [docs] Add docs for rack/location-awareness
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12219 )
Change subject: [docs] Add docs for rack/location-awareness
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12219
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I505b7fd545a4253170a5b7cac63c33e7d9669490
Gerrit-Change-Number: 12219
Gerrit-PatchSet: 4
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Sat, 12 Jan 2019 02:50:14 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Add docs for rack/location-awareness
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12219 )
Change subject: [docs] Add docs for rack/location-awareness
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12219
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I505b7fd545a4253170a5b7cac63c33e7d9669490
Gerrit-Change-Number: 12219
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 11 Jan 2019 20:32:30 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Add docs for rack/location-awareness
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Andrew Wong, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12219
to look at the new patch set (#4).
Change subject: [docs] Add docs for rack/location-awareness
......................................................................
[docs] Add docs for rack/location-awareness
I stuck to the name "rack-awareness" throughout, preferring it to the
term we have used internally, "location-awareness", because even though
the latter term is more technically correct, the former is the more
typical and colloquial name for this sort of thing.
These docs borrow heavily from the WIP blog post written by Alexey.
Change-Id: I505b7fd545a4253170a5b7cac63c33e7d9669490
---
M docs/administration.adoc
1 file changed, 100 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/12219/4
--
To view, visit http://gerrit.cloudera.org:8080/12219
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I505b7fd545a4253170a5b7cac63c33e7d9669490
Gerrit-Change-Number: 12219
Gerrit-PatchSet: 4
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [docs] Add docs for rack/location-awareness
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12219 )
Change subject: [docs] Add docs for rack/location-awareness
......................................................................
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@256
PS1, Line 256: conform
> I like your new approach more actually. I don't think you can "conform" som
You can! Conform is a transitive verb :themoreyouknow:. See https://www.merriam-webster.com/dictionary/conform.
http://gerrit.cloudera.org:8080/#/c/12219/2/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/12219/2/docs/administration.adoc@218
PS2, Line 218: and where
: each `/`-separated component
> nit: reads a bit funny imo, maybe "a `/`-separated string ... in which each
"in which" reads funny to me, so I'm going to leave it my way.
http://gerrit.cloudera.org:8080/#/c/12219/2/docs/administration.adoc@239
PS2, Line 239: `/L0`, `/L1`, `/L1`, `/L2`
> May want to specify how the policy will handle multi-component locations. E
Added a bit that we don't use the hierarchical structure though we might in the future.
http://gerrit.cloudera.org:8080/#/c/12219/2/docs/administration.adoc@1348
PS2, Line 1348: o place a replica in accord wi
> What does this mean?
Ask Adar :)
http://gerrit.cloudera.org:8080/#/c/12219/2/docs/administration.adoc@1354
PS2, Line 1354: re
> nit: flag
Done
--
To view, visit http://gerrit.cloudera.org:8080/12219
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I505b7fd545a4253170a5b7cac63c33e7d9669490
Gerrit-Change-Number: 12219
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 11 Jan 2019 23:13:11 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add docs for rack/location-awareness
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12219 )
Change subject: [docs] Add docs for rack/location-awareness
......................................................................
[docs] Add docs for rack/location-awareness
I stuck to the name "rack-awareness" throughout, preferring it to the
term we have used internally, "location-awareness", because even though
the latter term is more technically correct, the former is the more
typical and colloquial name for this sort of thing.
These docs borrow heavily from the WIP blog post written by Alexey.
Change-Id: I505b7fd545a4253170a5b7cac63c33e7d9669490
Reviewed-on: http://gerrit.cloudera.org:8080/12219
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M docs/administration.adoc
1 file changed, 100 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12219
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I505b7fd545a4253170a5b7cac63c33e7d9669490
Gerrit-Change-Number: 12219
Gerrit-PatchSet: 5
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [docs] Add docs for rack/location-awareness
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12219 )
Change subject: [docs] Add docs for rack/location-awareness
......................................................................
Removed reviewer Kudu Jenkins.
--
To view, visit http://gerrit.cloudera.org:8080/12219
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I505b7fd545a4253170a5b7cac63c33e7d9669490
Gerrit-Change-Number: 12219
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
[kudu-CR] [docs] Add docs for rack/location-awareness
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12219 )
Change subject: [docs] Add docs for rack/location-awareness
......................................................................
Removed reviewer Kudu Jenkins.
--
To view, visit http://gerrit.cloudera.org:8080/12219
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I505b7fd545a4253170a5b7cac63c33e7d9669490
Gerrit-Change-Number: 12219
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [docs] Add docs for rack/location-awareness
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has removed a vote on this change.
Change subject: [docs] Add docs for rack/location-awareness
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/12219
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I505b7fd545a4253170a5b7cac63c33e7d9669490
Gerrit-Change-Number: 12219
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [docs] Add docs for rack/location-awareness
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12219 )
Change subject: [docs] Add docs for rack/location-awareness
......................................................................
Patch Set 1:
(12 comments)
http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@208
PS1, Line 208: Kudu supports a rack awareness feature from version 1.9. Kudu's ordinary
> Nit: maybe "As of version 1.9, Kudu supports a rack awareness feature"?
Done
http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@209
PS1, Line 209: protect
> Nit: maybe 'ensure' is more precise?
Done
http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@213
PS1, Line 213: sorts
> Nit: 'kinds' is more precise (avoids ambiguity with the verb form of 'sorts
Done
http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@252
PS1, Line 252: can reestablish the placement policy if it is
: violated and if it is possible to move replicas of the tablets which violate the
: placement policy in such a way that the placement policy will no longer be
: violated after the replica moves are complete
> Nit: This seems unnecessarily verbose. Maybe "can restore the placement pol
Done
http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@256
PS1, Line 256: conform
> Nit: use the same verb here as in the previous sentence (either reestablish
One cannot "reestablish" or "restore" the placement policy on a cluster that was just upgraded to use location awareness and that may never have conformed to the policy before.
Howabout "can also be used to establish the placement policy on a cluster if it has just been..."? Sounds a little worse than using "conform" to me but I'm ok with either.
http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@258
PS1, Line 258: fixed
> Nit: moved
Tablets aren't moved; replicas are. Tablets are fixed (re the placement policy) by moving replicas. Howabout "and existing replicas need to be moved to comply with the placement policy"?
http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@1345
PS1, Line 1345: conform
> Nit: reestablish (or restore, or whatever. See above)
Same idea as before. I tried using "establish" instead. LMKWYT.
http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@1347
PS1, Line 1347: in a
: situation where it was not possible to place a replica in accord with the
: policy.
> Nit: I think you can drop this section, unnecessarily verbose.
Done
http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@1351
PS1, Line 1351: re-establishes
> re-establish
Done
http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@1354
PS1, Line 1354: between locations in an attempt to spread tablet replicas among location
> locations
Done
http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@1358
PS1, Line 1358: balances
> Is there a significance I'm not seeing for the use of "balances" here vs. "
Done
http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@1359
PS1, Line 1359: such
> Nit: 'the' instead
Done
--
To view, visit http://gerrit.cloudera.org:8080/12219
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I505b7fd545a4253170a5b7cac63c33e7d9669490
Gerrit-Change-Number: 12219
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 11 Jan 2019 20:32:01 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add docs for rack/location-awareness
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12219
to look at the new patch set (#3).
Change subject: [docs] Add docs for rack/location-awareness
......................................................................
[docs] Add docs for rack/location-awareness
I stuck to the name "rack-awareness" throughout, preferring it to the
term we have used internally, "location-awareness", because even though
the latter term is more technically correct, the former is the more
typical and colloquial name for this sort of thing.
These docs borrow heavily from the WIP blog post written by Alexey.
Change-Id: I505b7fd545a4253170a5b7cac63c33e7d9669490
---
M docs/administration.adoc
1 file changed, 100 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/19/12219/3
--
To view, visit http://gerrit.cloudera.org:8080/12219
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I505b7fd545a4253170a5b7cac63c33e7d9669490
Gerrit-Change-Number: 12219
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] [docs] Add docs for rack/location-awareness
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12219 )
Change subject: [docs] Add docs for rack/location-awareness
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12219/3/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/12219/3/docs/administration.adoc@1344
PS3, Line 1344: establish the placement policy on a
: cluster to the placement policy
> Missed this before, this doesn't read quite right.
Yeah, I fudged up the 'conform' -> 'establish' change.
--
To view, visit http://gerrit.cloudera.org:8080/12219
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I505b7fd545a4253170a5b7cac63c33e7d9669490
Gerrit-Change-Number: 12219
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 11 Jan 2019 23:25:41 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add docs for rack/location-awareness
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12219 )
Change subject: [docs] Add docs for rack/location-awareness
......................................................................
Patch Set 1:
(12 comments)
http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc
File docs/administration.adoc:
http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@208
PS1, Line 208: Kudu supports a rack awareness feature from version 1.9. Kudu's ordinary
Nit: maybe "As of version 1.9, Kudu supports a rack awareness feature"?
http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@209
PS1, Line 209: protect
Nit: maybe 'ensure' is more precise?
http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@213
PS1, Line 213: sorts
Nit: 'kinds' is more precise (avoids ambiguity with the verb form of 'sorts')?
http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@252
PS1, Line 252: can reestablish the placement policy if it is
: violated and if it is possible to move replicas of the tablets which violate the
: placement policy in such a way that the placement policy will no longer be
: violated after the replica moves are complete
Nit: This seems unnecessarily verbose. Maybe "can restore the placement policy if it is physically possible to do so"?
http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@256
PS1, Line 256: conform
Nit: use the same verb here as in the previous sentence (either reestablish, or restore, or whatever).
http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@258
PS1, Line 258: fixed
Nit: moved
http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@1345
PS1, Line 1345: conform
Nit: reestablish (or restore, or whatever. See above)
http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@1347
PS1, Line 1347: in a
: situation where it was not possible to place a replica in accord with the
: policy.
Nit: I think you can drop this section, unnecessarily verbose.
http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@1351
PS1, Line 1351: re-establishes
re-establish
http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@1354
PS1, Line 1354: between locations in an attempt to spread tablet replicas among location
locations
http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@1358
PS1, Line 1358: balances
Is there a significance I'm not seeing for the use of "balances" here vs. "tries to balance" in the previous bullet?
http://gerrit.cloudera.org:8080/#/c/12219/1/docs/administration.adoc@1359
PS1, Line 1359: such
Nit: 'the' instead
--
To view, visit http://gerrit.cloudera.org:8080/12219
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I505b7fd545a4253170a5b7cac63c33e7d9669490
Gerrit-Change-Number: 12219
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 11 Jan 2019 20:15:17 +0000
Gerrit-HasComments: Yes
[kudu-CR] [docs] Add docs for rack/location-awareness
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12219 )
Change subject: [docs] Add docs for rack/location-awareness
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12219
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I505b7fd545a4253170a5b7cac63c33e7d9669490
Gerrit-Change-Number: 12219
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 11 Jan 2019 23:13:53 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Add docs for rack/location-awareness
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/12219 )
Change subject: [docs] Add docs for rack/location-awareness
......................................................................
Removed reviewer Kudu Jenkins.
--
To view, visit http://gerrit.cloudera.org:8080/12219
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I505b7fd545a4253170a5b7cac63c33e7d9669490
Gerrit-Change-Number: 12219
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>