You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2014/03/17 14:30:09 UTC

Review Request 19290: Unittests for Service resource an all it's attributes

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19290/
-----------------------------------------------------------

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-5104
    https://issues.apache.org/jira/browse/AMBARI-5104


Repository: ambari


Description
-------

Test Service resource management resource. Test all actions and all the attributes.

Note here we should not call directly provider methods like action_create, but make resource management library do that for us, by calling env.run(). In other case test won't cover resources definitions, and other import logic


Diffs
-----

  ambari-agent/src/test/python/resource_management/TestServiceResource.py PRE-CREATION 

Diff: https://reviews.apache.org/r/19290/diff/


Testing
-------


Thanks,

Andrew Onischuk

Re: Review Request 19290: Unittests for Service resource an all it's attributes

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19290/#review37368
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On March 17, 2014, 1:30 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19290/
> -----------------------------------------------------------
> 
> (Updated March 17, 2014, 1:30 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-5104
>     https://issues.apache.org/jira/browse/AMBARI-5104
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Test Service resource management resource. Test all actions and all the attributes.
> 
> Note here we should not call directly provider methods like action_create, but make resource management library do that for us, by calling env.run(). In other case test won't cover resources definitions, and other import logic
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/test/python/resource_management/TestServiceResource.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/19290/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>