You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2020/10/07 18:01:31 UTC

[GitHub] [thrift] fishy commented on pull request #2256: THRIFT-5240: Disable go server side connectivity check by default

fishy commented on pull request #2256:
URL: https://github.com/apache/thrift/pull/2256#issuecomment-705101786


   Actually dig deeper to the go runtime bug, it looks like the excessive cpu only happens when the ticker interval is short (1ms). using the example code given by that bug, using 1ms it causes ~20% cpu, but changing that to 5ms makes the cpu drop to ~5%, and 10ms makes it drop to ~3%.
   
   So maybe 5ms is a better default than 0? @dcelasun what do you think?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org