You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2026/08/27 02:39:59 UTC
[PR] [SPARK-58846][CONNECT][PYTHON][FOLLOWUP] Preserve RpcDeadlines positional arguments [spark]
zhengruifeng opened a new pull request, #58326:
URL: https://github.com/apache/spark/pull/58326
### What changes were proposed in this pull request?
This is a follow-up to #58085.
This PR appends `RpcDeadlines.release_relation` after all existing dataclass fields instead of
inserting it between `release_session` and `artifact_status`. It also clarifies that ordinary
non-reattachable query `ExecutePlan` calls have no deadline, while relation cleanup is the bounded
exception.
The deadline tests now cover the new default and disabled values and verify that the existing
positional constructor arguments retain their original bindings.
### Why are the changes needed?
The generated dataclass constructor accepts positional arguments. Inserting `release_relation`
before existing fields silently shifted the bindings for `artifact_status`, `clone_session`,
`get_status`, and `fetch_error_details`. Appending the field preserves those bindings.
The documentation also made a categorical statement that non-reattachable `ExecutePlan` calls have
no deadline immediately before documenting the relation-cleanup exception. Qualifying the statement
removes that contradiction.
### Does this PR introduce _any_ user-facing change?
Yes, within the unreleased `master` branch only. Existing positional `RpcDeadlines` constructor
arguments keep their original meanings. The release RPC deadline behavior introduced by #58085 is
unchanged. No released Spark version is affected.
### How was this patch tested?
Built Spark with Hive support and ran:
`conda run -n spark-dev-313 python/run-tests --testnames pyspark.sql.tests.connect.client.test_client_retries`
The test suite passed.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex (GPT-5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58846][CONNECT][PYTHON][FOLLOWUP] Preserve RpcDeadlines positional arguments [spark]
Posted by "kishor-rkrishnan (via GitHub)" <gi...@apache.org>.
kishor-rkrishnan commented on PR #58326:
URL: https://github.com/apache/spark/pull/58326#issuecomment-5448688560
@zhengruifeng LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58846][CONNECT][PYTHON][FOLLOWUP] Preserve RpcDeadlines positional arguments [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #58326:
URL: https://github.com/apache/spark/pull/58326#issuecomment-5448871745
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/463b400cb4d2b06ac0cfa2e889a6f5ffff9d1703
- merged into branch-4.x https://github.com/apache/spark/commit/3d9602c587b4b579c64937ef83803402ed186040
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58846][CONNECT][PYTHON][FOLLOWUP] Preserve RpcDeadlines positional arguments [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #58326: [SPARK-58846][CONNECT][PYTHON][FOLLOWUP] Preserve RpcDeadlines positional arguments
URL: https://github.com/apache/spark/pull/58326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58846][CONNECT][PYTHON][FOLLOWUP] Preserve RpcDeadlines positional arguments [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #58326:
URL: https://github.com/apache/spark/pull/58326#issuecomment-5436271770
cc @kishor-rkrishnan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org