You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "LorenzoBettini (via GitHub)" <gi...@apache.org> on 2023/03/30 16:25:18 UTC
[GitHub] [maven-archetypes] LorenzoBettini opened a new pull request, #17: [MARCHETYPES-67] Fix maven-archetype-plugin test case
LorenzoBettini opened a new pull request, #17:
URL: https://github.com/apache/maven-archetypes/pull/17
As described here https://issues.apache.org/jira/browse/MARCHETYPES-67
The POM test project for unit test was referring to a non existent plugin "maven-my-plugin" instead of referring to the plugin created by the artifact.
The unit test also did not check the correct configuration of the test project. I've added a further assertion in the unit test; I made sure it fails without the patch to the POM test project; with the patched POM test project everything works.
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MARCHETYPES) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[MARCHETYPES-XXX] SUMMARY`, where you replace `MARCHETYPES-XXX`
and `SUMMARY` with the appropriate JIRA issue. Best practice is to use the JIRA issue
title in the pull request title and in the first line of the commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetypes] slachiewicz merged pull request #17: [MARCHETYPES-67] Fix maven-archetype-plugin test case
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz merged PR #17:
URL: https://github.com/apache/maven-archetypes/pull/17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-archetypes] LorenzoBettini commented on pull request #17: [MARCHETYPES-67] Fix maven-archetype-plugin test case
Posted by "LorenzoBettini (via GitHub)" <gi...@apache.org>.
LorenzoBettini commented on PR #17:
URL: https://github.com/apache/maven-archetypes/pull/17#issuecomment-1493888900
@rfscholte would you have time to have a look at it, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org