You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/12/23 11:01:38 UTC
[GitHub] [camel-quarkus] zbendhiba opened a new pull request #2093: Hazelcast native support fixes #1647
zbendhiba opened a new pull request #2093:
URL: https://github.com/apache/camel-quarkus/pull/2093
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #2093: Hazelcast native support fixes #1647
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #2093:
URL: https://github.com/apache/camel-quarkus/pull/2093#issuecomment-750310439
I have restarted the CI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #2093: Hazelcast native support fixes #1647
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #2093:
URL: https://github.com/apache/camel-quarkus/pull/2093#discussion_r547972892
##########
File path: integration-tests/hazelcast/src/main/java/org/apache/camel/quarkus/component/hazelcast/it/HazelcastRoutes.java
##########
@@ -0,0 +1,189 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.camel.quarkus.component.hazelcast.it;
+
+import javax.enterprise.context.ApplicationScoped;
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.ws.rs.Produces;
+
+import com.hazelcast.core.HazelcastInstance;
+import io.quarkus.arc.Unremovable;
+import org.apache.camel.builder.RouteBuilder;
+import org.apache.camel.component.hazelcast.HazelcastConstants;
+import org.apache.camel.component.hazelcast.HazelcastDefaultComponent;
+import org.apache.camel.component.hazelcast.atomicnumber.HazelcastAtomicnumberComponent;
+import org.apache.camel.component.hazelcast.instance.HazelcastInstanceComponent;
+import org.apache.camel.component.hazelcast.list.HazelcastListComponent;
+import org.apache.camel.component.hazelcast.map.HazelcastMapComponent;
+import org.apache.camel.component.hazelcast.multimap.HazelcastMultimapComponent;
+import org.apache.camel.component.hazelcast.replicatedmap.HazelcastReplicatedmapComponent;
+import org.apache.camel.component.hazelcast.set.HazelcastSetComponent;
+import org.apache.camel.component.hazelcast.topic.HazelcastTopicComponent;
+
+@ApplicationScoped
+public class HazelcastRoutes extends RouteBuilder {
+ public static final String MOCK_LIST_ADDED = "mock:list-added";
+ public static final String MOCK_LIST_DELETED = "mock:list-removed";
+ public static final String MOCK_SET_ADDED = "mock:set-added";
+ public static final String MOCK_SET_DELETED = "mock:set-removed";
+ public static final String MOCK_MAP_ADDED = "mock:map-added";
+ public static final String MOCK_MAP_DELETED = "mock:map-removed";
+ public static final String MOCK_MAP_UPDATED = "mock:map-updated";
+ public static final String MOCK_MAP_EVICTED = "mock:map-evicted";
+ public static final String MOCK_MULTIMAP_ADDED = "mock:multimap-added";
+ public static final String MOCK_MULTIMAP_DELETED = "mock:multimap-removed";
+ public static final String MOCK_REPLICATED_ADDED = "mock:replicatedmap-added";
+ public static final String MOCK_REPLICATED_DELETED = "mock:replicatedmap-removed";
+ public static final String MOCK_TOPIC_RECEIVED = "mock:topic-received";
+
+ @Inject
+ HazelcastInstance hazelcastInstance;
+
+ @Produces
+ @ApplicationScoped
+ @Unremovable
+ @Named("hazelcast-instance")
+ HazelcastDefaultComponent hazelcastInstance() {
+ final HazelcastInstanceComponent hazelcastComponent = new HazelcastInstanceComponent();
+ return getHazelcastComponent(hazelcastComponent);
+ }
+
+ @Produces
+ @ApplicationScoped
+ @Unremovable
+ @Named("hazelcast-atomicvalue")
+ HazelcastDefaultComponent hazelcastAtomicnumber() {
+ final HazelcastAtomicnumberComponent hazelcastComponent = new HazelcastAtomicnumberComponent();
+ return getHazelcastComponent(hazelcastComponent);
+ }
+
+ @Produces
+ @ApplicationScoped
+ @Unremovable
+ @Named("hazelcast-list")
+ HazelcastDefaultComponent hazelcastList() {
+ final HazelcastListComponent hazelcastComponent = new HazelcastListComponent();
+ return getHazelcastComponent(hazelcastComponent);
+ }
+
+ @Produces
+ @ApplicationScoped
+ @Unremovable
+ @Named("hazelcast-map")
+ HazelcastDefaultComponent hazelcastMap() {
+ final HazelcastMapComponent hazelcastComponent = new HazelcastMapComponent();
+ return getHazelcastComponent(hazelcastComponent);
+ }
+
+ @Produces
+ @ApplicationScoped
+ @Unremovable
+ @Named("hazelcast-multimap")
+ HazelcastDefaultComponent hazelcastMultimap() {
+ final HazelcastMultimapComponent hazelcastComponent = new HazelcastMultimapComponent();
+ return getHazelcastComponent(hazelcastComponent);
+ }
+
+ @Produces
+ @ApplicationScoped
+ @Unremovable
+ @Named("hazelcast-replicatedmap")
+ HazelcastDefaultComponent hazelcastReplicatedmap() {
+ final HazelcastReplicatedmapComponent hazelcastComponent = new HazelcastReplicatedmapComponent();
+ return getHazelcastComponent(hazelcastComponent);
+ }
+
+ @Produces
+ @ApplicationScoped
+ @Unremovable
+ @Named("hazelcast-set")
+ HazelcastDefaultComponent hazelcastSet() {
+ final HazelcastSetComponent hazelcastComponent = new HazelcastSetComponent();
+ return getHazelcastComponent(hazelcastComponent);
+ }
+
+ @Produces
+ @ApplicationScoped
+ @Unremovable
+ @Named("hazelcast-topic")
+ HazelcastDefaultComponent hazelcastTopic() {
+ final HazelcastTopicComponent hazelcastComponent = new HazelcastTopicComponent();
+ return getHazelcastComponent(hazelcastComponent);
+ }
+
+ private HazelcastDefaultComponent getHazelcastComponent(HazelcastDefaultComponent hazelcastComponent) {
Review comment:
`configureHazelcastComponent` would perhaps better describe what this method does.
##########
File path: extensions/hazelcast/runtime/pom.xml
##########
@@ -55,6 +63,20 @@
<groupId>org.apache.camel</groupId>
<artifactId>camel-hazelcast</artifactId>
</dependency>
+ <dependency>
+ <groupId>com.hazelcast</groupId>
+ <artifactId>quarkus-hazelcast-client</artifactId>
+ </dependency>
+ <!-- fix version -->
Review comment:
Is this comment needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on pull request #2093: Hazelcast native support fixes #1647
Posted by GitBox <gi...@apache.org>.
zbendhiba commented on pull request #2093:
URL: https://github.com/apache/camel-quarkus/pull/2093#issuecomment-750152977
Please note that this PR doesn't include all the integration tests needed. I'll follow up with an other PR: see issue https://github.com/apache/camel-quarkus/issues/2094
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga merged pull request #2093: Hazelcast native support fixes #1647
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #2093:
URL: https://github.com/apache/camel-quarkus/pull/2093
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on a change in pull request #2093: Hazelcast native support fixes #1647
Posted by GitBox <gi...@apache.org>.
zbendhiba commented on a change in pull request #2093:
URL: https://github.com/apache/camel-quarkus/pull/2093#discussion_r547980228
##########
File path: extensions/hazelcast/runtime/pom.xml
##########
@@ -55,6 +63,20 @@
<groupId>org.apache.camel</groupId>
<artifactId>camel-hazelcast</artifactId>
</dependency>
+ <dependency>
+ <groupId>com.hazelcast</groupId>
+ <artifactId>quarkus-hazelcast-client</artifactId>
+ </dependency>
+ <!-- fix version -->
Review comment:
nope!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org