You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/02/05 06:24:40 UTC
[GitHub] [incubator-tvm] Coderx7 opened a new pull request #4820: Fixed
subprocess creation under windows
Coderx7 opened a new pull request #4820: Fixed subprocess creation under windows
URL: https://github.com/apache/incubator-tvm/pull/4820
This addresses #4819
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] Coderx7 commented on issue #4820: Fixed subprocess
creation under windows
Posted by GitBox <gi...@apache.org>.
Coderx7 commented on issue #4820: Fixed subprocess creation under windows
URL: https://github.com/apache/incubator-tvm/pull/4820#issuecomment-582260857
@tqchen Please review.
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] merrymercy merged pull request #4820: Fixed
subprocess creation under windows
Posted by GitBox <gi...@apache.org>.
merrymercy merged pull request #4820: Fixed subprocess creation under windows
URL: https://github.com/apache/incubator-tvm/pull/4820
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] merrymercy commented on a change in pull request
#4820: Fixed subprocess creation under windows
Posted by GitBox <gi...@apache.org>.
merrymercy commented on a change in pull request #4820: Fixed subprocess creation under windows
URL: https://github.com/apache/incubator-tvm/pull/4820#discussion_r375169945
##########
File path: python/tvm/rpc/server.py
##########
@@ -363,7 +364,10 @@ def __init__(self,
# interim, stop the pylint diagnostic.
#
# pylint: disable=subprocess-popen-preexec-fn
- self.proc = subprocess.Popen(cmd, preexec_fn=os.setsid)
+ if platform.system() == "Windows":
Review comment:
use 4 spaces for indentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] Coderx7 edited a comment on issue #4820: Fixed
subprocess creation under windows
Posted by GitBox <gi...@apache.org>.
Coderx7 edited a comment on issue #4820: Fixed subprocess creation under windows
URL: https://github.com/apache/incubator-tvm/pull/4820#issuecomment-582260857
@eqy Please review.
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] Coderx7 commented on a change in pull request
#4820: Fixed subprocess creation under windows
Posted by GitBox <gi...@apache.org>.
Coderx7 commented on a change in pull request #4820: Fixed subprocess creation under windows
URL: https://github.com/apache/incubator-tvm/pull/4820#discussion_r375186003
##########
File path: python/tvm/rpc/server.py
##########
@@ -363,7 +364,10 @@ def __init__(self,
# interim, stop the pylint diagnostic.
#
# pylint: disable=subprocess-popen-preexec-fn
- self.proc = subprocess.Popen(cmd, preexec_fn=os.setsid)
+ if platform.system() == "Windows":
Review comment:
Its done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] Coderx7 edited a comment on issue #4820: Fixed
subprocess creation under windows
Posted by GitBox <gi...@apache.org>.
Coderx7 edited a comment on issue #4820: Fixed subprocess creation under windows
URL: https://github.com/apache/incubator-tvm/pull/4820#issuecomment-582260857
@eqy @merrymercy Please review.
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services