[GitHub] [cassandra] ifesdjeen commented on a diff in pull request #2190: CASSANDRA-18299: Add support for prepared statements for accord transactions

["ifesdjeen (via GitHub)" <gi...@apache.org>]

ifesdjeen commented on code in PR #2190:
URL: https://github.com/apache/cassandra/pull/2190#discussion_r1126789911


##########
src/java/org/apache/cassandra/service/accord/AccordService.java:
##########
@@ -226,7 +226,7 @@ public TxnData coordinate(Txn txn, ConsistencyLevel consistencyLevel)
 
     private static RuntimeException throwTimeout(Txn txn, ConsistencyLevel consistencyLevel)
     {
-        throw txn.isWrite() ? new WriteTimeoutException(WriteType.TRANSACTION, consistencyLevel, 0, 0)
+        throw txn.isWrite() ? new WriteTimeoutException(WriteType.CAS, consistencyLevel, 0, 0)

Review Comment:
   I am not very familiar with Accord code, but I am assuming that you use CAS here because here is no support for transaction in the client yet, or? If so, maybe its worth to add a comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org