You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by GitBox <gi...@apache.org> on 2022/10/21 21:47:02 UTC
[GitHub] [lucenenet] rclabo opened a new pull request, #713: Removed 3 private nested classes that were not in use
rclabo opened a new pull request, #713:
URL: https://github.com/apache/lucenenet/pull/713
Classes removed: DirectDocValuesProducer.FSTEntry, FreeTextSuggester.AnalyzingComparer and Arrays.EmptyArrayHolder. Replaced code with appropriate LUCENENET comment. Related to Issue #669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] NightOwl888 commented on pull request #713: Removed 3 private nested classes that were not in use
Posted by GitBox <gi...@apache.org>.
NightOwl888 commented on PR #713:
URL: https://github.com/apache/lucenenet/pull/713#issuecomment-1288129808
I went ahead and made the change to this PR before the merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] NightOwl888 commented on pull request #713: Removed 3 private nested classes that were not in use
Posted by GitBox <gi...@apache.org>.
NightOwl888 commented on PR #713:
URL: https://github.com/apache/lucenenet/pull/713#issuecomment-1288133419
Since we just removed support for .NET Framework < 4.6.2, let's keep `FEATURE_ARRAYEMPTY` in case we have to revert for some reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] NightOwl888 merged pull request #713: Removed 3 private nested classes that were not in use
Posted by GitBox <gi...@apache.org>.
NightOwl888 merged PR #713:
URL: https://github.com/apache/lucenenet/pull/713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] rclabo commented on pull request #713: Removed 3 private nested classes that were not in use
Posted by GitBox <gi...@apache.org>.
rclabo commented on PR #713:
URL: https://github.com/apache/lucenenet/pull/713#issuecomment-1288132572
> I went ahead and made the change to this PR before the merge.
I know. You put back the code for `Arrays.EmptyArrayHolder` and placed it in a `FEATURE_ARRAYEMPTY` compiler directive for conditional compilation. I'm asking if I should submit a separate PR and remove all the `FEATURE_ARRAYEMPTY` compiler directives and related code? Or are they still needed for some reason?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] rclabo commented on pull request #713: Removed 3 private nested classes that were not in use
Posted by GitBox <gi...@apache.org>.
rclabo commented on PR #713:
URL: https://github.com/apache/lucenenet/pull/713#issuecomment-1288127424
> EmptyArrayHolder is for conditional compilation, but we currently don't have any targets for it. We shouldn't remove it until we are ready to remove FEATURE_ARRAYEMPTY. I have made the change to put it in a conditional compilation section of its own.
OK thanks. Should I submit a separate PR and remove FEATURE_ARRAYEMPTY and groom code accordingly? Or is it best to leave it in for some future need?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org