[GitHub] [airflow] amoghrajesh commented on a diff in pull request #29756: DAG list sorting lost when switching page

["amoghrajesh (via GitHub)" <gi...@apache.org>]

amoghrajesh commented on code in PR #29756:
URL: https://github.com/apache/airflow/pull/29756#discussion_r1122690163


##########
airflow/www/utils.py:
##########
@@ -238,6 +247,8 @@ def generate_pages(current_page, num_of_pages, search=None, status=None, tags=No
     :param status: 'all', 'active', or 'paused'
     :param tags: array of strings of the current filtered tags
     :param window: the number of pages to be shown in the paging component (7 default)
+    :param sorting_key: the sorting key selected for the dags
+    :param sorting_direction: direction of sorting, 'asc' or 'desc'

Review Comment:
   Having it as None means that sorting is not applicable or not provided. I will mention that in the docstring as well.
   
   Good point. It makes sense to have all or none behaving in a similar way as they are dependent variables. That is why I am using them in an "and" way, for ex: https://github.com/apache/airflow/pull/29756/files#diff-ba09c7727b94aa05a7557d151820479d3f53d71e9a4c601db8a3de3f7f2caf76R42



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org