You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@oodt.apache.org by ma...@apache.org on 2015/10/25 23:54:45 UTC

[05/12] oodt git commit: OODT-890 remove unneeded boxing, unboxing, swap indexof to contains, stringbuffer to builder

OODT-890 remove unneeded boxing, unboxing, swap indexof to contains, stringbuffer to builder


Project: http://git-wip-us.apache.org/repos/asf/oodt/repo
Commit: http://git-wip-us.apache.org/repos/asf/oodt/commit/eadd1425
Tree: http://git-wip-us.apache.org/repos/asf/oodt/tree/eadd1425
Diff: http://git-wip-us.apache.org/repos/asf/oodt/diff/eadd1425

Branch: refs/heads/master
Commit: eadd142574b2eb637f7194b0d635a3c8c5b2de74
Parents: 1e5b0f9
Author: Tom Barber <to...@analytical-labs.com>
Authored: Sun Oct 25 22:16:39 2015 +0000
Committer: Tom Barber <to...@analytical-labs.com>
Committed: Sun Oct 25 22:16:39 2015 +0000

----------------------------------------------------------------------
 .../org/apache/oodt/cas/catalog/query/parser/TokenMgrError.java    | 2 +-
 .../apache/oodt/commons/database/DatabaseConnectionBuilder.java    | 2 +-
 .../src/main/java/org/apache/oodt/cas/filemgr/structs/Product.java | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/oodt/blob/eadd1425/catalog/src/main/java/org/apache/oodt/cas/catalog/query/parser/TokenMgrError.java
----------------------------------------------------------------------
diff --git a/catalog/src/main/java/org/apache/oodt/cas/catalog/query/parser/TokenMgrError.java b/catalog/src/main/java/org/apache/oodt/cas/catalog/query/parser/TokenMgrError.java
index 7bac32a..340b607 100644
--- a/catalog/src/main/java/org/apache/oodt/cas/catalog/query/parser/TokenMgrError.java
+++ b/catalog/src/main/java/org/apache/oodt/cas/catalog/query/parser/TokenMgrError.java
@@ -47,7 +47,7 @@ public class TokenMgrError extends Error
    * Replaces unprintable characters by their escaped (or unicode escaped)
    * equivalents in the given string
    */
-  protected static final String addEscapes(String str) {
+  protected static String addEscapes(String str) {
     StringBuilder retval = new StringBuilder();
     char ch;
     for (int i = 0; i < str.length(); i++) {

http://git-wip-us.apache.org/repos/asf/oodt/blob/eadd1425/commons/src/main/java/org/apache/oodt/commons/database/DatabaseConnectionBuilder.java
----------------------------------------------------------------------
diff --git a/commons/src/main/java/org/apache/oodt/commons/database/DatabaseConnectionBuilder.java b/commons/src/main/java/org/apache/oodt/commons/database/DatabaseConnectionBuilder.java
index 1d98191..e997812 100644
--- a/commons/src/main/java/org/apache/oodt/commons/database/DatabaseConnectionBuilder.java
+++ b/commons/src/main/java/org/apache/oodt/commons/database/DatabaseConnectionBuilder.java
@@ -38,7 +38,7 @@ import org.apache.commons.pool.impl.GenericObjectPool;
  */
 public final class DatabaseConnectionBuilder {
 
-    public static final DataSource buildDataSource(String user, String pass,
+    public static DataSource buildDataSource(String user, String pass,
             String driver, String url) {
 
         DataSource ds;

http://git-wip-us.apache.org/repos/asf/oodt/blob/eadd1425/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/Product.java
----------------------------------------------------------------------
diff --git a/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/Product.java b/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/Product.java
index d441142..cfc7d41 100644
--- a/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/Product.java
+++ b/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/Product.java
@@ -261,7 +261,7 @@ public class Product {
         this.rootRef = rootRef;
     }
 
-    public static final Product getDefaultFlatProduct(String name,
+    public static Product getDefaultFlatProduct(String name,
             String defaultProductTypeId) {
         Product defaultProduct = new Product();
         defaultProduct.setProductName(name);