You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Christian Schulte (JIRA)" <ji...@codehaus.org> on 2009/02/13 03:58:19 UTC

[jira] Created: (MRELEASE-412) release:prepare does not update properties during rewrite-poms-for-development phase.

release:prepare does not update properties during rewrite-poms-for-development phase.
-------------------------------------------------------------------------------------

                 Key: MRELEASE-412
                 URL: http://jira.codehaus.org/browse/MRELEASE-412
             Project: Maven 2.x Release Plugin
          Issue Type: Bug
          Components: prepare
    Affects Versions: 2.0-beta-8
         Environment: Maven version: 2.0.10-RC8
Java version: 1.5.0_14
OS name: "linux" version: "2.6.28.4" arch: "i386" Family: "unix"

            Reporter: Christian Schulte
            Priority: Blocker


When a dependency version is specified using a property like ${someExpression} that property is correctly updated during the rewrite-poms-for-release phase but not during the rewrite-poms-for-development phase. The attached patch solves this for me.



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MRELEASE-412) release:prepare does not update properties during rewrite-poms-for-development phase.

Posted by "Stephen Connolly (JIRA)" <ji...@codehaus.org>.
     [ https://jira.codehaus.org/browse/MRELEASE-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stephen Connolly updated MRELEASE-412:
--------------------------------------

    Fix Version/s: 2.3

This looks like it could be applied for 2.3

> release:prepare does not update properties during rewrite-poms-for-development phase.
> -------------------------------------------------------------------------------------
>
>                 Key: MRELEASE-412
>                 URL: https://jira.codehaus.org/browse/MRELEASE-412
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>          Components: prepare
>    Affects Versions: 2.0-beta-8
>         Environment: Maven version: 2.0.10-RC8
> Java version: 1.5.0_14
> OS name: "linux" version: "2.6.28.4" arch: "i386" Family: "unix"
>            Reporter: Christian Schulte
>            Priority: Blocker
>              Labels: maven-patch-available, properties
>             Fix For: 2.3
>
>         Attachments: MRELEASE-412.patch
>
>
> When a dependency version is specified using a property like ${someExpression} that property is correctly updated during the rewrite-poms-for-release phase but not during the rewrite-poms-for-development phase. The attached patch solves this for me.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MRELEASE-412) release:prepare does not update properties during rewrite-poms-for-development phase.

Posted by "Christian Schulte (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRELEASE-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Schulte updated MRELEASE-412:
---------------------------------------

    Attachment: MRELEASE-412.patch

Patch for updating properties during the rewrite-poms-for-development phase.

> release:prepare does not update properties during rewrite-poms-for-development phase.
> -------------------------------------------------------------------------------------
>
>                 Key: MRELEASE-412
>                 URL: http://jira.codehaus.org/browse/MRELEASE-412
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>          Components: prepare
>    Affects Versions: 2.0-beta-8
>         Environment: Maven version: 2.0.10-RC8
> Java version: 1.5.0_14
> OS name: "linux" version: "2.6.28.4" arch: "i386" Family: "unix"
>            Reporter: Christian Schulte
>            Priority: Blocker
>         Attachments: MRELEASE-412.patch
>
>
> When a dependency version is specified using a property like ${someExpression} that property is correctly updated during the rewrite-poms-for-release phase but not during the rewrite-poms-for-development phase. The attached patch solves this for me.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MRELEASE-412) release:prepare does not update properties during rewrite-poms-for-development phase.

Posted by "Pedro Rodriguez (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRELEASE-412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=249463#action_249463 ] 

Pedro Rodriguez commented on MRELEASE-412:
------------------------------------------

The unit tests couldn’t show it because the problem occurs at the integration level of the release phases.

The rewrite-poms-for-release phase changed the property only in the xml.    

During the rewrite-poms-for-development, the new xml (with the "release" version value) get parsed. However, the same unchanged reactor project (with the previous “development” property value) is used.  

The development version is not set during the rewrite-poms-for-development phase because the value of the property in the xml is not the same that in the project model.

Fix: The project model needs to be updated when we change a property value. 

We have fixed this issue at the same time that the MRELEASE-454

> release:prepare does not update properties during rewrite-poms-for-development phase.
> -------------------------------------------------------------------------------------
>
>                 Key: MRELEASE-412
>                 URL: http://jira.codehaus.org/browse/MRELEASE-412
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>          Components: prepare
>    Affects Versions: 2.0-beta-8
>         Environment: Maven version: 2.0.10-RC8
> Java version: 1.5.0_14
> OS name: "linux" version: "2.6.28.4" arch: "i386" Family: "unix"
>            Reporter: Christian Schulte
>            Priority: Blocker
>         Attachments: MRELEASE-412.patch
>
>
> When a dependency version is specified using a property like ${someExpression} that property is correctly updated during the rewrite-poms-for-release phase but not during the rewrite-poms-for-development phase. The attached patch solves this for me.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] (MRELEASE-412) release:prepare does not update properties during rewrite-poms-for-development phase.

Posted by "Christian Schulte (JIRA)" <ji...@codehaus.org>.
     [ https://jira.codehaus.org/browse/MRELEASE-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Schulte closed MRELEASE-412.
--------------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 2.3)
                   2.2.2

Version 2.2.2 fixed this as well.
                
> release:prepare does not update properties during rewrite-poms-for-development phase.
> -------------------------------------------------------------------------------------
>
>                 Key: MRELEASE-412
>                 URL: https://jira.codehaus.org/browse/MRELEASE-412
>             Project: Maven 2.x Release Plugin
>          Issue Type: Bug
>          Components: prepare
>    Affects Versions: 2.0-beta-8
>         Environment: Maven version: 2.0.10-RC8
> Java version: 1.5.0_14
> OS name: "linux" version: "2.6.28.4" arch: "i386" Family: "unix"
>            Reporter: Christian Schulte
>            Priority: Blocker
>              Labels: maven-patch-available, properties
>             Fix For: 2.2.2
>
>         Attachments: MRELEASE-412.patch
>
>
> When a dependency version is specified using a property like ${someExpression} that property is correctly updated during the rewrite-poms-for-release phase but not during the rewrite-poms-for-development phase. The attached patch solves this for me.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira