You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/19 15:59:54 UTC

[GitHub] [arrow] pitrou commented on a change in pull request #9267: ARROW-11277: [C++] Workaround macOS 10.11: don't default construct consts

pitrou commented on a change in pull request #9267:
URL: https://github.com/apache/arrow/pull/9267#discussion_r560287406



##########
File path: cpp/src/arrow/dataset/expression.cc
##########
@@ -681,7 +681,7 @@ Result<Expression> FoldConstants(Expression expr) {
         if (std::all_of(call->arguments.begin(), call->arguments.end(),
                         [](const Expression& argument) { return argument.literal(); })) {
           // all arguments are literal; we can evaluate this subexpression *now*
-          static const Datum ignored_input;
+          static const Datum ignored_input = Datum{};

Review comment:
       Perhaps we can give Datum a default constructor?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org