You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "rionmonster (via GitHub)" <gi...@apache.org> on 2025/09/12 04:31:53 UTC
[PR] [FLINK-38345][flink-connector-base] Added previousEnumerator resolution for HybridSource during checkpoint recovery [flink]
rionmonster opened a new pull request, #26983:
URL: https://github.com/apache/flink/pull/26983
## Contribution Checklist
## What is the purpose of the change
This pull request addresses the issue detailed in [FLINK-38345](https://issues.apache.org/jira/browse/FLINK-38345) where checkpoint recovery scenarios for `HybridSource` instances could result in null pointer exceptions (as the `currentEnumerator` is null subsequently results in the `previousEnumerator` also being null).
## Brief change log
- Added an `isRecovering` flag for the `HybridSourceSplitEnumerator` to detect recovery-based scenarios.
- Added two new static helper classes within the `HybridSourceSplitEnumerator` responsible for recovery:
- `RecoveryAwareSourceSwitchContext` which replaces a similar, previously inline, implementation for establishing a new context for the `previousEnumerator`.
- `EmptyRecoverySourceSwitchContext` which is a temporary context used to facilitate source creation (as the creation of a new `Source` instances requires an existing context).
- Added a new `testRestoreEnumeratorWithSwitchContextSource` (originally written by @mattcuento) to reproduce the original issue and as a means to verify the fix.
## Verifying this change
This change added tests and can be verified as follows:
- Added new `testRestoreEnumeratorWithSwitchContextSource` which originally reproduced the issue by creating a `HybridSource` instance, triggering a source switch, snapshotting, and attempting enumerator restoration.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **don't know**
- Anything that affects deployment or recovery: **no/don't know**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **not applicable**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38345][flink-connector-base] Added previousEnumerator resolution for HybridSource during checkpoint recovery [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #26983: [FLINK-38345][flink-connector-base] Added previousEnumerator resolution for HybridSource during checkpoint recovery
URL: https://github.com/apache/flink/pull/26983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38345][flink-connector-base] Added previousEnumerator resolution for HybridSource during checkpoint recovery [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26983:
URL: https://github.com/apache/flink/pull/26983#issuecomment-4457884250
This PR has been closed since it has not had any activity in 120 days.
If you feel like this was a mistake, or you would like to continue working on it,
please feel free to re-open the PR and ask for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38345][flink-connector-base] Added previousEnumerator resolution for HybridSource during checkpoint recovery [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26983:
URL: https://github.com/apache/flink/pull/26983#issuecomment-4249915450
This PR is being marked as stale since it has not had any activity in the last 90 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.
If you are having difficulty finding a reviewer, please reach out to the
community, contact details can be found here: https://flink.apache.org/what-is-flink/community/
If this PR is no longer valid or desired, please feel free to close it.
If no activity occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38345][flink-connector-base] Added previousEnumerator resolution for HybridSource during checkpoint recovery [flink]
Posted by "alpinegizmo (via GitHub)" <gi...@apache.org>.
alpinegizmo commented on PR #26983:
URL: https://github.com/apache/flink/pull/26983#issuecomment-3747129240
Reopened. Hoping we can find someone to review this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38345][flink-connector-base] Added previousEnumerator resolution for HybridSource during checkpoint recovery [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26983:
URL: https://github.com/apache/flink/pull/26983#issuecomment-3737058953
This PR has been closed since it has not had any activity in 120 days.
If you feel like this was a mistake, or you would like to continue working on it,
please feel free to re-open the PR and ask for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38345][flink-connector-base] Added previousEnumerator resolution for HybridSource during checkpoint recovery [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26983:
URL: https://github.com/apache/flink/pull/26983#issuecomment-3645104437
This PR is being marked as stale since it has not had any activity in the last 90 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.
If you are having difficulty finding a reviewer, please reach out to the
community, contact details can be found here: https://flink.apache.org/what-is-flink/community/
If this PR is no longer valid or desired, please feel free to close it.
If no activity occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38345][flink-connector-base] Added previousEnumerator resolution for HybridSource during checkpoint recovery [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #26983:
URL: https://github.com/apache/flink/pull/26983#issuecomment-3283626826
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "78c38a7c79e0d9db960b6c3ed7e142195d56704d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "78c38a7c79e0d9db960b6c3ed7e142195d56704d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 78c38a7c79e0d9db960b6c3ed7e142195d56704d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38345][flink-connector-base] Added previousEnumerator resolution for HybridSource during checkpoint recovery [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #26983: [FLINK-38345][flink-connector-base] Added previousEnumerator resolution for HybridSource during checkpoint recovery
URL: https://github.com/apache/flink/pull/26983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org