You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org> on 2025/06/13 03:50:56 UTC

[Impala-ASF-CR] IMPALA-14141: Disable auto compaction for the a table in acid.test

Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23020


Change subject: IMPALA-14141: Disable auto compaction for the a table in acid.test
......................................................................

IMPALA-14141: Disable auto compaction for the a table in acid.test

This patch disables auto compaction for the table
'insert_only_major_and_minor_compacted' to prevent Hive from
automatically compacting the files associated with the table after the
changes to Hive Metastore configurations in HIVE-28662. Without this
patch, after HIVE-28662, the files associated with the table would be
reduced to 1, which in turn would fail the respective test case in
acid.test.

Change-Id: I5ed35c7f9e6aa277140691f032a8a36eee2f0185
---
M testdata/datasets/functional/functional_schema_template.sql
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/23020/1
-- 
To view, visit http://gerrit.cloudera.org:8080/23020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5ed35c7f9e6aa277140691f032a8a36eee2f0185
Gerrit-Change-Number: 23020
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>

[Impala-ASF-CR] IMPALA-14141: Disable auto compaction of HMS after HIVE-28662

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23020 )

Change subject: IMPALA-14141: Disable auto compaction of HMS after HIVE-28662
......................................................................

IMPALA-14141: Disable auto compaction of HMS after HIVE-28662

This patch disables auto compaction of Hive Metastore, because after
the changes to Hive Metastore configurations in HIVE-28662, Hive could
automatically compact files associated with ACID tables, which makes
some test cases non-deterministic, e.g., those in acid.test.

Change-Id: I5ed35c7f9e6aa277140691f032a8a36eee2f0185
Reviewed-on: http://gerrit.cloudera.org:8080/23020
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/test/resources/hive-site.xml.py
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Csaba Ringhofer: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/23020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5ed35c7f9e6aa277140691f032a8a36eee2f0185
Gerrit-Change-Number: 23020
Gerrit-PatchSet: 5
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-14141: Disable auto compaction of HMS after HIVE-28662

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23020 )

Change subject: IMPALA-14141: Disable auto compaction of HMS after HIVE-28662
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12036/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/23020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed35c7f9e6aa277140691f032a8a36eee2f0185
Gerrit-Change-Number: 23020
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Jun 2025 14:34:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14141: Disable auto compaction of HMS after HIVE-28662

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23020 )

Change subject: IMPALA-14141: Disable auto compaction of HMS after HIVE-28662
......................................................................


Patch Set 3: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/23020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed35c7f9e6aa277140691f032a8a36eee2f0185
Gerrit-Change-Number: 23020
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Jun 2025 14:27:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14141: Disable auto compaction for the a table in acid.test

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/23020 )

Change subject: IMPALA-14141: Disable auto compaction for the a table in acid.test
......................................................................


Patch Set 2:

Added Zoltan and Csaba as reviewers since they are more familiar with the test file acid.test.


-- 
To view, visit http://gerrit.cloudera.org:8080/23020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed35c7f9e6aa277140691f032a8a36eee2f0185
Gerrit-Change-Number: 23020
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Jun 2025 03:45:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14141: Disable auto compaction of HMS after HIVE-28662

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23020 )

Change subject: IMPALA-14141: Disable auto compaction of HMS after HIVE-28662
......................................................................


Patch Set 3:

You must rebase to pick up IMPALA-14144: Make pip_download.py more tolerant with PEP 503 simple pages.


-- 
To view, visit http://gerrit.cloudera.org:8080/23020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed35c7f9e6aa277140691f032a8a36eee2f0185
Gerrit-Change-Number: 23020
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Jun 2025 02:52:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14141: Disable auto compaction of HMS after HIVE-28662

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23020 )

Change subject: IMPALA-14141: Disable auto compaction of HMS after HIVE-28662
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/23020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed35c7f9e6aa277140691f032a8a36eee2f0185
Gerrit-Change-Number: 23020
Gerrit-PatchSet: 4
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Jun 2025 15:39:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14141: Disable auto compaction of HMS after HIVE-28662

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23020 )

Change subject: IMPALA-14141: Disable auto compaction of HMS after HIVE-28662
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12039/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/23020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed35c7f9e6aa277140691f032a8a36eee2f0185
Gerrit-Change-Number: 23020
Gerrit-PatchSet: 4
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Jun 2025 02:53:54 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14141: Disable auto compaction of HMS after HIVE-28662

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/23020 )

Change subject: IMPALA-14141: Disable auto compaction of HMS after HIVE-28662
......................................................................


Patch Set 4:

> Patch Set 4: Verified-1
> 
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12039/

We seemed to hit IMPALA-13607 at https://jenkins.impala.io/job/ubuntu-20.04-from-scratch/5770/.


-- 
To view, visit http://gerrit.cloudera.org:8080/23020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed35c7f9e6aa277140691f032a8a36eee2f0185
Gerrit-Change-Number: 23020
Gerrit-PatchSet: 4
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Jun 2025 09:29:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14141: Disable auto compaction of HMS after HIVE-28662

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23020 )

Change subject: IMPALA-14141: Disable auto compaction of HMS after HIVE-28662
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12041/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/23020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed35c7f9e6aa277140691f032a8a36eee2f0185
Gerrit-Change-Number: 23020
Gerrit-PatchSet: 4
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Jun 2025 09:30:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14141: Disable auto compaction for the a table in acid.test

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23020 )

Change subject: IMPALA-14141: Disable auto compaction for the a table in acid.test
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23020/2/testdata/datasets/functional/functional_schema_template.sql
File testdata/datasets/functional/functional_schema_template.sql:

http://gerrit.cloudera.org:8080/#/c/23020/2/testdata/datasets/functional/functional_schema_template.sql@4609
PS2, Line 4609: ALTER TABLE {db_name}{db_suffix}.{table_name} SET TBLPROPERTIES ('no_auto_compaction'='true');
nit: IMPALA-11682 add both insert_only_minor_compacted and insert_only_major_and_minor_compacted.
Can you please comment why only insert_only_major_and_minor_compacted need this no_auto_compaction=true property, while insert_only_minor_compacted is not?



-- 
To view, visit http://gerrit.cloudera.org:8080/23020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed35c7f9e6aa277140691f032a8a36eee2f0185
Gerrit-Change-Number: 23020
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Jun 2025 04:00:37 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14141: Disable auto compaction for the a table in acid.test

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23020 )

Change subject: IMPALA-14141: Disable auto compaction for the a table in acid.test
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23020/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23020/2//COMMIT_MSG@9
PS2, Line 9: This patch disables auto compaction for the table
           : 'insert_only_major_and_minor_compacted' 
why don't we disable hive.compactor.initiator.on globally to avoid "surprise compactions"? it's possible that only this single dataload table is impacted, but there are some tests that do compactions and the possibility of triggering this in HMS may make the flaky


http://gerrit.cloudera.org:8080/#/c/23020/2/testdata/datasets/functional/functional_schema_template.sql
File testdata/datasets/functional/functional_schema_template.sql:

http://gerrit.cloudera.org:8080/#/c/23020/2/testdata/datasets/functional/functional_schema_template.sql@4609
PS2, Line 4609: ALTER TABLE {db_name}{db_suffix}.{table_name} SET TBLPROPERTIES ('no_auto_compaction'='true');
> nit: IMPALA-11682 add both insert_only_minor_compacted and insert_only_majo
>Can you please comment why only insert_only_major_and_minor_compacted need this 

probably there is some threshold, e.g. size and number of files needed to trigger compaction



-- 
To view, visit http://gerrit.cloudera.org:8080/23020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed35c7f9e6aa277140691f032a8a36eee2f0185
Gerrit-Change-Number: 23020
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Jun 2025 05:57:22 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14141: Disable auto compaction for the a table in acid.test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23020 )

Change subject: IMPALA-14141: Disable auto compaction for the a table in acid.test
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/19473/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed35c7f9e6aa277140691f032a8a36eee2f0185
Gerrit-Change-Number: 23020
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Jun 2025 04:18:16 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14141: Disable auto compaction of HMS after HIVE-28662

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23020 )

Change subject: IMPALA-14141: Disable auto compaction of HMS after HIVE-28662
......................................................................


Patch Set 3:

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12038/


-- 
To view, visit http://gerrit.cloudera.org:8080/23020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed35c7f9e6aa277140691f032a8a36eee2f0185
Gerrit-Change-Number: 23020
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Jun 2025 02:53:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14141: Disable auto compaction of HMS after HIVE-28662

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23020 )

Change subject: IMPALA-14141: Disable auto compaction of HMS after HIVE-28662
......................................................................


Patch Set 4: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12039/


-- 
To view, visit http://gerrit.cloudera.org:8080/23020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed35c7f9e6aa277140691f032a8a36eee2f0185
Gerrit-Change-Number: 23020
Gerrit-PatchSet: 4
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Jun 2025 09:02:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14141: Disable auto compaction for the a table in acid.test

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23020 )

Change subject: IMPALA-14141: Disable auto compaction for the a table in acid.test
......................................................................


Patch Set 2: Code-Review+1

Thanks for looking into this. Please double check with IMPALA-11682 and make sure that this patch does not change the nature of the tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed35c7f9e6aa277140691f032a8a36eee2f0185
Gerrit-Change-Number: 23020
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Jun 2025 03:25:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14141: Disable auto compaction of HMS after HIVE-28662

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23020 )

Change subject: IMPALA-14141: Disable auto compaction of HMS after HIVE-28662
......................................................................


Patch Set 3:

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/12036/


-- 
To view, visit http://gerrit.cloudera.org:8080/23020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed35c7f9e6aa277140691f032a8a36eee2f0185
Gerrit-Change-Number: 23020
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Jun 2025 00:34:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14141: Disable auto compaction of HMS after HIVE-28662

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/23020 )

Change subject: IMPALA-14141: Disable auto compaction of HMS after HIVE-28662
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23020/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23020/2//COMMIT_MSG@9
PS2, Line 9: This patch disables auto compaction of Hive Metastore, because after
           : the changes to Hive Metastore configurat
> why don't we disable hive.compactor.initiator.on globally to avoid "surpris
Thanks Csaba! I will set 'hive.compactor.initiator.on' to false in the next patch.



-- 
To view, visit http://gerrit.cloudera.org:8080/23020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed35c7f9e6aa277140691f032a8a36eee2f0185
Gerrit-Change-Number: 23020
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Jun 2025 14:34:45 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14141: Disable auto compaction of HMS after HIVE-28662

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Hello Riza Suminto, Zoltan Borok-Nagy, Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23020

to look at the new patch set (#3).

Change subject: IMPALA-14141: Disable auto compaction of HMS after HIVE-28662
......................................................................

IMPALA-14141: Disable auto compaction of HMS after HIVE-28662

This patch disables auto compaction of Hive Metastore, because after
the changes to Hive Metastore configurations in HIVE-28662, Hive could
automatically compact files associated with ACID tables, which makes
some test cases non-deterministic, e.g., those in acid.test.

Change-Id: I5ed35c7f9e6aa277140691f032a8a36eee2f0185
---
M fe/src/test/resources/hive-site.xml.py
1 file changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/23020/3
-- 
To view, visit http://gerrit.cloudera.org:8080/23020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5ed35c7f9e6aa277140691f032a8a36eee2f0185
Gerrit-Change-Number: 23020
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-14141: Disable auto compaction of HMS after HIVE-28662

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23020 )

Change subject: IMPALA-14141: Disable auto compaction of HMS after HIVE-28662
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12038/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/23020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed35c7f9e6aa277140691f032a8a36eee2f0185
Gerrit-Change-Number: 23020
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Jun 2025 02:07:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14141: Disable auto compaction of HMS after HIVE-28662

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23020 )

Change subject: IMPALA-14141: Disable auto compaction of HMS after HIVE-28662
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/23020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed35c7f9e6aa277140691f032a8a36eee2f0185
Gerrit-Change-Number: 23020
Gerrit-PatchSet: 4
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 17 Jun 2025 04:58:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14141: Disable auto compaction of HMS after HIVE-28662

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23020 )

Change subject: IMPALA-14141: Disable auto compaction of HMS after HIVE-28662
......................................................................


Patch Set 3: Verified-1

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/19502/ : ABORTED


-- 
To view, visit http://gerrit.cloudera.org:8080/23020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed35c7f9e6aa277140691f032a8a36eee2f0185
Gerrit-Change-Number: 23020
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Jun 2025 20:20:11 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14141: Disable auto compaction for the a table in acid.test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23020 )

Change subject: IMPALA-14141: Disable auto compaction for the a table in acid.test
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/23020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed35c7f9e6aa277140691f032a8a36eee2f0185
Gerrit-Change-Number: 23020
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Jun 2025 10:06:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14141: Disable auto compaction for the a table in acid.test

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/23020

to look at the new patch set (#2).

Change subject: IMPALA-14141: Disable auto compaction for the a table in acid.test
......................................................................

IMPALA-14141: Disable auto compaction for the a table in acid.test

This patch disables auto compaction for the table
'insert_only_major_and_minor_compacted' to prevent Hive from
automatically compacting the files associated with the table after the
changes to Hive Metastore configurations in HIVE-28662. Without this
patch, after HIVE-28662, the files associated with the table would be
reduced to 1 from 4, which in turn would fail the respective test case
in acid.test.

Change-Id: I5ed35c7f9e6aa277140691f032a8a36eee2f0185
---
M testdata/datasets/functional/functional_schema_template.sql
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/23020/2
-- 
To view, visit http://gerrit.cloudera.org:8080/23020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5ed35c7f9e6aa277140691f032a8a36eee2f0185
Gerrit-Change-Number: 23020
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-14141: Disable auto compaction for the a table in acid.test

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23020 )

Change subject: IMPALA-14141: Disable auto compaction for the a table in acid.test
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12016/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/23020
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ed35c7f9e6aa277140691f032a8a36eee2f0185
Gerrit-Change-Number: 23020
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 13 Jun 2025 03:56:50 +0000
Gerrit-HasComments: No