[jira] [Commented] (HIVE-15161) migrate ColumnStats to use jackson

["Alexander Kolbasov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-15161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385292#comment-16385292 ] 

Alexander Kolbasov commented on HIVE-15161:
-------------------------------------------

[~kgyrtkirk] I noticed a bit of an odd code:
{code:java}
public static void setBasicStatsState(Map<String, String> params, String setting) {
  ...
  ColumnStatsAccurate stats = parseStatsAcc(params.get(COLUMN_STATS_ACCURATE));
  stats.basicStats = true;
}{code}
So  it parses the value of {{COLUMN_STATS_ACCURATE}} but then always ignores it and sets {{stats.basicStats}} to true anyway. Is it intentional? Can this be removed?

> migrate ColumnStats to use jackson
> ----------------------------------
>
>                 Key: HIVE-15161
>                 URL: https://issues.apache.org/jira/browse/HIVE-15161
>             Project: Hive
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0, 2.1.0
>            Reporter: Zoltan Haindrich
>            Assignee: Zoltan Haindrich
>            Priority: Major
>             Fix For: 2.3.0
>
>         Attachments: HIVE-15161.1.patch, HIVE-15161.2.patch, HIVE-15161.3.patch, HIVE-15161.4.patch, HIVE-15161.4.patch, HIVE-15161.5.patch, HIVE-15161.5.patch, HIVE-15161.6.patch
>
>
> * json.org has license issues
> * jackson can provide a fully compatible alternative to it
> * there are a few flakiness issues caused by the order of the map entries of the columns...this cat be addressed, org.json api was unfriendly in this manner ;)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)