You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/08 05:06:17 UTC
[GitHub] [incubator-shardingsphere] menghaoranss opened a new pull request
#5101: Support remove schema dynamically#step 1&2
menghaoranss opened a new pull request #5101: Support remove schema dynamically#step 1&2
URL: https://github.com/apache/incubator-shardingsphere/pull/5101
For #5065 .
Changes proposed in this pull request:
- Add delete(key) interface in CenterRepository and implement it with zookeeper&etcd&nacos&apollo
- Add unit tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull
request #5101: Support remove schema dynamically#step 1&2
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #5101: Support remove schema dynamically#step 1&2
URL: https://github.com/apache/incubator-shardingsphere/pull/5101#discussion_r405495986
##########
File path: sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/ApolloCenterRepository.java
##########
@@ -103,6 +103,11 @@ public void watch(final String key, final DataChangedEventListener dataChangedEv
configWrapper.addChangeListener(listener, Collections.singleton(apolloKey), Collections.singleton(apolloKey));
}
+ @Override
+ public void delete(final String key) {
+ openApiWrapper.remove(ConfigKeyUtils.path2Key(key));
Review comment:
Please do not use abbreviation, `pathToKey` is better
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #5101:
Support remove schema dynamically#step 1&2
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #5101: Support remove schema dynamically#step 1&2
URL: https://github.com/apache/incubator-shardingsphere/pull/5101#issuecomment-610772614
## Pull Request Test Coverage Report for [Build 10881](https://coveralls.io/builds/29929587)
* **12** of **18** **(66.67%)** changed or added relevant lines in **5** files are covered.
* **5** unchanged lines in **1** file lost coverage.
* Overall coverage decreased (**-0.009%**) to **57.308%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-apollo/src/main/java/org/apache/shardingsphere/orchestration/center/instance/wrapper/ApolloOpenApiWrapper.java](https://coveralls.io/builds/29929587/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-apollo%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2Fwrapper%2FApolloOpenApiWrapper.java#L89) | 0 | 2 | 0.0%
| [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-nacos/src/main/java/org/apache/shardingsphere/orchestration/center/instance/NacosCenterRepository.java](https://coveralls.io/builds/29929587/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-nacos%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FNacosCenterRepository.java#L150) | 4 | 6 | 66.67%
| [sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-zookeeper-curator/src/main/java/org/apache/shardingsphere/orchestration/center/instance/CuratorZookeeperCenterRepository.java](https://coveralls.io/builds/29929587/source?filename=sharding-orchestration%2Fsharding-orchestration-center%2Fsharding-orchestration-center-zookeeper-curator%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcenter%2Finstance%2FCuratorZookeeperCenterRepository.java#L237) | 4 | 6 | 66.67%
<!-- | **Total:** | **12** | **18** | **66.67%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-metadatacenter/src/main/java/org/apache/shardingsphere/orchestration/core/metadatacenter/MetaDataCenter.java](https://coveralls.io/builds/29929587/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-metadatacenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fmetadatacenter%2FMetaDataCenter.java#L37) | 5 | 0% |
<!-- | **Total:** | **5** | | -->
| Totals | [](https://coveralls.io/builds/29929587) |
| :-- | --: |
| Change from base [Build 10880](https://coveralls.io/builds/29929260): | -0.009% |
| Covered Lines: | 11680 |
| Relevant Lines: | 20381 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #5101:
Support remove schema dynamically#step 1&2
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #5101: Support remove schema dynamically#step 1&2
URL: https://github.com/apache/incubator-shardingsphere/pull/5101
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services