[GitHub] DaanHoogland commented on a change in pull request #2602: CLOUDSTACK-10365: Change the "getXXX" boolean-related method names to…

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #2602: CLOUDSTACK-10365: Change the "getXXX" boolean-related method names to…
URL: https://github.com/apache/cloudstack/pull/2602#discussion_r185414457
 
 

 ##########
 File path: api/src/main/java/com/cloud/offering/ServiceOffering.java
 ##########
 @@ -86,7 +86,7 @@
     /**
      * @return Does this service plan support Volatile VM that is, discard VM's root disk and create a new one on reboot?
      */
-    boolean getVolatileVm();
+    boolean isVolatileVm();
 
 Review comment:
   @BruceKuiLiu I am with 2 all the way, with the exception of the use of these methods in code generation tools. In this last method I would expect a name like isForVolatileVms() or the ealier sugested name. Of cause the accessor is named after the field implying that the field is not properly named either.
   I am +0 on this one. Try to find more reviews.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services