You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/07/21 13:59:03 UTC
[GitHub] [arrow] kszucs opened a new pull request #10768: [Release] Verify 5.0.0-RC0 [WIP]
kszucs opened a new pull request #10768:
URL: https://github.com/apache/arrow/pull/10768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #10768: [Release] Verify 5.0.0-RC0 [WIP]
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #10768:
URL: https://github.com/apache/arrow/pull/10768#issuecomment-884665051
For the Ruby one: Arrow Flight is built with system OpenSSL but Arrow Flight GLib tried to link against conda's OpenSSL and it's failed. I don't know why this was caused...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs closed pull request #10768: [Release] Verify 5.0.0-RC0 [WIP]
Posted by GitBox <gi...@apache.org>.
kszucs closed pull request #10768:
URL: https://github.com/apache/arrow/pull/10768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10768: [Release] Verify 5.0.0-RC0 [WIP]
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10768:
URL: https://github.com/apache/arrow/pull/10768#issuecomment-884258888
Revision: 514a1aadfcf871e20cd1178a874285303a347f57
Submitted crossbow builds: [ursacomputing/crossbow @ actions-631](https://github.com/ursacomputing/crossbow/branches/all?query=actions-631)
|Task|Status|
|----|------|
|verify-rc-source-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-631-github-verify-rc-source-linux-cpp)|
|verify-rc-source-linux-csharp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-631-github-verify-rc-source-linux-csharp)|
|verify-rc-source-linux-go|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-631-github-verify-rc-source-linux-go)|
|verify-rc-source-linux-integration|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-631-github-verify-rc-source-linux-integration)|
|verify-rc-source-linux-java|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-631-github-verify-rc-source-linux-java)|
|verify-rc-source-linux-js|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-631-github-verify-rc-source-linux-js)|
|verify-rc-source-linux-python|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-631-github-verify-rc-source-linux-python)|
|verify-rc-source-linux-ruby|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-631-github-verify-rc-source-linux-ruby)|
|verify-rc-source-macos-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-631-github-verify-rc-source-macos-cpp)|
|verify-rc-source-macos-csharp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-631-github-verify-rc-source-macos-csharp)|
|verify-rc-source-macos-go|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-631-github-verify-rc-source-macos-go)|
|verify-rc-source-macos-integration|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-631-github-verify-rc-source-macos-integration)|
|verify-rc-source-macos-java|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-631-github-verify-rc-source-macos-java)|
|verify-rc-source-macos-js|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-631-github-verify-rc-source-macos-js)|
|verify-rc-source-macos-python|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-631-github-verify-rc-source-macos-python)|
|verify-rc-source-macos-ruby|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-631-github-verify-rc-source-macos-ruby)|
|verify-rc-source-windows|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-631-github-verify-rc-source-windows)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10768: [Release] Verify 5.0.0-RC0 [WIP]
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10768:
URL: https://github.com/apache/arrow/pull/10768#issuecomment-884213216
Revision: c0fefec65f9cf6d9012851b88b28946257f2120a
Submitted crossbow builds: [ursacomputing/crossbow @ actions-630](https://github.com/ursacomputing/crossbow/branches/all?query=actions-630)
|Task|Status|
|----|------|
|verify-rc-source-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-630-github-verify-rc-source-linux-cpp)|
|verify-rc-source-linux-csharp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-630-github-verify-rc-source-linux-csharp)|
|verify-rc-source-linux-go|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-630-github-verify-rc-source-linux-go)|
|verify-rc-source-linux-integration|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-630-github-verify-rc-source-linux-integration)|
|verify-rc-source-linux-java|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-630-github-verify-rc-source-linux-java)|
|verify-rc-source-linux-js|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-630-github-verify-rc-source-linux-js)|
|verify-rc-source-linux-python|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-630-github-verify-rc-source-linux-python)|
|verify-rc-source-linux-ruby|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-630-github-verify-rc-source-linux-ruby)|
|verify-rc-source-linux-rust|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-630-github-verify-rc-source-linux-rust)|
|verify-rc-source-macos-cpp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-630-github-verify-rc-source-macos-cpp)|
|verify-rc-source-macos-csharp|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-630-github-verify-rc-source-macos-csharp)|
|verify-rc-source-macos-go|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-630-github-verify-rc-source-macos-go)|
|verify-rc-source-macos-integration|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-630-github-verify-rc-source-macos-integration)|
|verify-rc-source-macos-java|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-630-github-verify-rc-source-macos-java)|
|verify-rc-source-macos-js|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-630-github-verify-rc-source-macos-js)|
|verify-rc-source-macos-python|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-630-github-verify-rc-source-macos-python)|
|verify-rc-source-macos-ruby|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-630-github-verify-rc-source-macos-ruby)|
|verify-rc-source-macos-rust|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-630-github-verify-rc-source-macos-rust)|
|verify-rc-source-windows|[](https://github.com/ursacomputing/crossbow/actions?query=branch:actions-630-github-verify-rc-source-windows)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10768: [Release] Verify 5.0.0-RC0 [WIP]
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10768:
URL: https://github.com/apache/arrow/pull/10768#issuecomment-884212330
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10768: [Release] Verify 5.0.0-RC0 [WIP]
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10768:
URL: https://github.com/apache/arrow/pull/10768#issuecomment-884212435
@github-actions crossbow submit --group verify-rc-source --param release=5.0.0 --param rc=0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou edited a comment on pull request #10768: [Release] Verify 5.0.0-RC0 [WIP]
Posted by GitBox <gi...@apache.org>.
kou edited a comment on pull request #10768:
URL: https://github.com/apache/arrow/pull/10768#issuecomment-884665051
For the Ruby one: Arrow Flight is built with system OpenSSL but Arrow Flight GLib tried to link against conda's OpenSSL and it's failed. I don't know why this was occurred...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #10768: [Release] Verify 5.0.0-RC0 [WIP]
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #10768:
URL: https://github.com/apache/arrow/pull/10768#issuecomment-884726000
> For the Ruby one: Arrow Flight is built with system OpenSSL but Arrow Flight GLib tried to link against conda's OpenSSL and it's failed. I don't know why this was occurred...
Wrong. This verification scripts build Arrow C++ with bundled gRPC. The bundled gRPC uses system shared OpenSSL but `libarrow_flight.so` doesn't link system shared OpenSSL.
The following patch will solve this:
```diff
diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index a79d4fd7b..56c37000b 100644
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -2543,6 +2543,9 @@ macro(build_grpc)
c-ares::cares
ZLIB::ZLIB
Threads::Threads)
+ if(ARROW_OPENSSL_USE_SHARED)
+ list(APPEND GRPC_LINK_LIBRARIES OpenSSL::SSL)
+ endif()
set_target_properties(gRPC::grpc
PROPERTIES IMPORTED_LOCATION "${GRPC_STATIC_LIBRARY_GRPC}"
INTERFACE_INCLUDE_DIRECTORIES "${GRPC_INCLUDE_DIR}"
```
I confirmed this on my local Ubuntu 20.04 Docker container.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] removed a comment on pull request #10768: [Release] Verify 5.0.0-RC0 [WIP]
Posted by GitBox <gi...@apache.org>.
github-actions[bot] removed a comment on pull request #10768:
URL: https://github.com/apache/arrow/pull/10768#issuecomment-884212330
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs edited a comment on pull request #10768: [Release] Verify 5.0.0-RC0 [WIP]
Posted by GitBox <gi...@apache.org>.
kszucs edited a comment on pull request #10768:
URL: https://github.com/apache/arrow/pull/10768#issuecomment-884509827
I assume the integration verification tasks fail due to an environmental issue, similarly to the ruby one (presumably need to properly set `PKG_CONFIG_PATH`).
Integration tests pass for both in case of conda-integration build and local verification on macOS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10768: [Release] Verify 5.0.0-RC0 [WIP]
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10768:
URL: https://github.com/apache/arrow/pull/10768#issuecomment-884876221
Closing in favor of RC1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10768: [Release] Verify 5.0.0-RC0 [WIP]
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10768:
URL: https://github.com/apache/arrow/pull/10768#issuecomment-884258237
@github-actions crossbow submit --group verify-rc-source --param release=5.0.0 --param rc=0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #10768: [Release] Verify 5.0.0-RC0 [WIP]
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #10768:
URL: https://github.com/apache/arrow/pull/10768#issuecomment-884747318
#10773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10768: [Release] Verify 5.0.0-RC0 [WIP]
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10768:
URL: https://github.com/apache/arrow/pull/10768#issuecomment-884509827
I assume the integration verification tasks fail due to an environmental issue, similarly to the ruby one (need to properly set `PKG_CONFIG_PATH`).
Integration tests pass for both in case of conda-integration build and local verification on macOS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org