You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@continuum.apache.org by Ken Liu <ke...@gmail.com> on 2008/09/11 16:53:39 UTC
which jpa branch is active?
Hi,
I am interested in contributing to the JPA refactoring effort as I have JPA
expertise. I saw that there are two jpa branches (continuum-jpa and
continuum-jpa-evenisse). Are both of these branches under development? Are
they both considered to be candidates for merging into the trunk?
Any background information on these would be appreciated.
Thanks,
Ken
Re: which jpa branch is active?
Posted by Rahul Thakur <ra...@gmail.com>.
Ken Liu wrote:
> I took some time over the weekend to look at the two branches. IMHO the
> approach used in the jpa-evenisse branch is more of a typical approach to
> using JPA and is basically the approach I would take.
>
> I can't quite grok the code in the other branch - I don't see the motivation
> for creating a Query abstraction, either.
>
Abstracting the Query in that manner keeps the store API compact yet
flexible enough to query entities based on various criteria.
Rahul
> Ken
>
> On Sat, Sep 13, 2008 at 1:30 AM, Emmanuel Venisse<
> emmanuel.venisse@gmail.com> wrote:
>
>
>> On Fri, Sep 12, 2008 at 9:46 PM, Wendy Smoak<ws...@gmail.com> wrote:
>>
>>
>>> On Fri, Sep 12, 2008 at 2:04 AM, Emmanuel Venisse
>>> <em...@gmail.com> wrote:
>>>
>>>> On Fri, Sep 12, 2008 at 6:58 AM, Rahul Thakur
>>>>
>>>>> Emmanuel, I am not sure I understand - where did you find sql in the
>>>>> code? I think we have discussed the approached a few times on this
>>>>> list but your comment above sounds like you didn't quite grasp the
>>>>> motivation behind it.
>>>>>
>>>> Not sql but JPQL. For example in toString method in
>>>>
>>>>
>> https://svn.apache.org/repos/asf/continuum/branches/continuum-jpa/continuum-model-jpa/src/main/java/org/apache/maven/continuum/store/jpa/ProjectGroupQuery.java
>>
>>>> You're probably right, I don't grasp the motivation and I don't really
>>>>
>>> like
>>>
>>>> all string concatenations in toString() methods.
>>>>
>>> Emmanuel, can you link to the equivalent (or a similar) query on your
>>> branch so we can see how it compares?
>>>
>> In my branch, I use @NamedQueries annotations on the class, for example:
>>
>>
>> http://svn.apache.org/repos/asf/continuum/branches/continuum-jpa-evenisse/src/main/java/org/apache/continuum/model/project/ProjectGroup.java
>>
>> http://svn.apache.org/repos/asf/continuum/branches/continuum-jpa-evenisse/src/main/java/org/apache/continuum/model/project/Project.java
>>
>>
>>
>>> Thanks,
>>> --
>>> Wendy
>>>
>>>
>
>
Re: which jpa branch is active?
Posted by Ken Liu <ke...@gmail.com>.
I took some time over the weekend to look at the two branches. IMHO the
approach used in the jpa-evenisse branch is more of a typical approach to
using JPA and is basically the approach I would take.
I can't quite grok the code in the other branch - I don't see the motivation
for creating a Query abstraction, either.
Ken
On Sat, Sep 13, 2008 at 1:30 AM, Emmanuel Venisse <
emmanuel.venisse@gmail.com> wrote:
> On Fri, Sep 12, 2008 at 9:46 PM, Wendy Smoak <ws...@gmail.com> wrote:
>
> > On Fri, Sep 12, 2008 at 2:04 AM, Emmanuel Venisse
> > <em...@gmail.com> wrote:
> > > On Fri, Sep 12, 2008 at 6:58 AM, Rahul Thakur
> >
> > >> Emmanuel, I am not sure I understand - where did you find sql in the
> > >> code? I think we have discussed the approached a few times on this
> > >> list but your comment above sounds like you didn't quite grasp the
> > >> motivation behind it.
> > >
> > > Not sql but JPQL. For example in toString method in
> > >
> >
> https://svn.apache.org/repos/asf/continuum/branches/continuum-jpa/continuum-model-jpa/src/main/java/org/apache/maven/continuum/store/jpa/ProjectGroupQuery.java
> > >
> > > You're probably right, I don't grasp the motivation and I don't really
> > like
> > > all string concatenations in toString() methods.
> >
> > Emmanuel, can you link to the equivalent (or a similar) query on your
> > branch so we can see how it compares?
>
>
> In my branch, I use @NamedQueries annotations on the class, for example:
>
>
> http://svn.apache.org/repos/asf/continuum/branches/continuum-jpa-evenisse/src/main/java/org/apache/continuum/model/project/ProjectGroup.java
>
> http://svn.apache.org/repos/asf/continuum/branches/continuum-jpa-evenisse/src/main/java/org/apache/continuum/model/project/Project.java
>
>
> >
> >
> > Thanks,
> > --
> > Wendy
> >
>
Re: which jpa branch is active?
Posted by Emmanuel Venisse <em...@gmail.com>.
On Fri, Sep 12, 2008 at 9:46 PM, Wendy Smoak <ws...@gmail.com> wrote:
> On Fri, Sep 12, 2008 at 2:04 AM, Emmanuel Venisse
> <em...@gmail.com> wrote:
> > On Fri, Sep 12, 2008 at 6:58 AM, Rahul Thakur
>
> >> Emmanuel, I am not sure I understand - where did you find sql in the
> >> code? I think we have discussed the approached a few times on this
> >> list but your comment above sounds like you didn't quite grasp the
> >> motivation behind it.
> >
> > Not sql but JPQL. For example in toString method in
> >
> https://svn.apache.org/repos/asf/continuum/branches/continuum-jpa/continuum-model-jpa/src/main/java/org/apache/maven/continuum/store/jpa/ProjectGroupQuery.java
> >
> > You're probably right, I don't grasp the motivation and I don't really
> like
> > all string concatenations in toString() methods.
>
> Emmanuel, can you link to the equivalent (or a similar) query on your
> branch so we can see how it compares?
In my branch, I use @NamedQueries annotations on the class, for example:
http://svn.apache.org/repos/asf/continuum/branches/continuum-jpa-evenisse/src/main/java/org/apache/continuum/model/project/ProjectGroup.java
http://svn.apache.org/repos/asf/continuum/branches/continuum-jpa-evenisse/src/main/java/org/apache/continuum/model/project/Project.java
>
>
> Thanks,
> --
> Wendy
>
Re: which jpa branch is active?
Posted by Wendy Smoak <ws...@gmail.com>.
On Fri, Sep 12, 2008 at 2:04 AM, Emmanuel Venisse
<em...@gmail.com> wrote:
> On Fri, Sep 12, 2008 at 6:58 AM, Rahul Thakur
>> Emmanuel, I am not sure I understand - where did you find sql in the
>> code? I think we have discussed the approached a few times on this
>> list but your comment above sounds like you didn't quite grasp the
>> motivation behind it.
>
> Not sql but JPQL. For example in toString method in
> https://svn.apache.org/repos/asf/continuum/branches/continuum-jpa/continuum-model-jpa/src/main/java/org/apache/maven/continuum/store/jpa/ProjectGroupQuery.java
>
> You're probably right, I don't grasp the motivation and I don't really like
> all string concatenations in toString() methods.
Emmanuel, can you link to the equivalent (or a similar) query on your
branch so we can see how it compares?
Thanks,
--
Wendy
Re: which jpa branch is active?
Posted by Emmanuel Venisse <em...@gmail.com>.
On Fri, Sep 12, 2008 at 6:58 AM, Rahul Thakur
<ra...@gmail.com>wrote:
> Hello Ken,
>
> Those 2 branches were created to investigate different approaches with
> JPA. I don't remember a consensus reached on which one to use.
>
> On Fri, Sep 12, 2008 at 4:28 AM, Emmanuel Venisse
> <em...@gmail.com> wrote:
> > Both was "test" branches. If you want to look at one, I'd prefer you look
> at
> > mine (continuum-jpa-evenisse) ;-)
>
> Yeah ditto, I'd prefer you look at continuum-jpa ;-))
>
> > My branch was based on jpa annotations and the other one was done with
> sql
> > in the code. I think annotations are better but I'm not a JPA expert.
>
> Emmanuel, I am not sure I understand - where did you find sql in the
> code? I think we have discussed the approached a few times on this
> list but your comment above sounds like you didn't quite grasp the
> motivation behind it.
Not sql but JPQL. For example in toString method in
https://svn.apache.org/repos/asf/continuum/branches/continuum-jpa/continuum-model-jpa/src/main/java/org/apache/maven/continuum/store/jpa/ProjectGroupQuery.java
You're probably right, I don't grasp the motivation and I don't really like
all string concatenations in toString() methods.
>
>
> Ken, feel free to poke around with both and let us know if you have
> any queries or issues. The continuum-jpa used OpenJPA as JPA provider
> for investigation, but IIRC there was an inclination to go with
> TopLink in the group.
>
> Cheers,
> Rahul
>
Re: which jpa branch is active?
Posted by Rahul Thakur <ra...@gmail.com>.
Hello Ken,
Those 2 branches were created to investigate different approaches with
JPA. I don't remember a consensus reached on which one to use.
On Fri, Sep 12, 2008 at 4:28 AM, Emmanuel Venisse
<em...@gmail.com> wrote:
> Both was "test" branches. If you want to look at one, I'd prefer you look at
> mine (continuum-jpa-evenisse) ;-)
Yeah ditto, I'd prefer you look at continuum-jpa ;-))
> My branch was based on jpa annotations and the other one was done with sql
> in the code. I think annotations are better but I'm not a JPA expert.
Emmanuel, I am not sure I understand - where did you find sql in the
code? I think we have discussed the approached a few times on this
list but your comment above sounds like you didn't quite grasp the
motivation behind it.
Ken, feel free to poke around with both and let us know if you have
any queries or issues. The continuum-jpa used OpenJPA as JPA provider
for investigation, but IIRC there was an inclination to go with
TopLink in the group.
Cheers,
Rahul
Re: which jpa branch is active?
Posted by Emmanuel Venisse <em...@gmail.com>.
We can't use LGPL in Apache products we deliver for third party libraries,
it isn't allowed.
You can look the following links for more informations about licenses:
http://www.apache.org/legal/resolved.html
http://www.apache.org/legal/3party.html#criteriaandcategories
Emmanuel
On Thu, Sep 11, 2008 at 8:12 PM, Ken Liu <ke...@gmail.com> wrote:
> Thanks for the info.
>
> I read an old email thread (from the 2.0 planning earlier this year)
> discussing which JPA provider to use. Was there ever a consensus reached on
> this?
>
> I think Hibernate is probably the most commonly used JPA provider (I use it
> in my workplace as well), but there was mention of TopLink Essentials.
> Someone mentioned something about the Hibernate license (LGPL 2.1) not
> being
> compatible with Apache licensing?
>
> Ken
>
> On Thu, Sep 11, 2008 at 11:28 AM, Emmanuel Venisse <
> emmanuel.venisse@gmail.com> wrote:
>
> > Both was "test" branches. If you want to look at one, I'd prefer you look
> > at
> > mine (continuum-jpa-evenisse) ;-)
> > My branch was based on jpa annotations and the other one was done with
> sql
> > in the code. I think annotations are better but I'm not a JPA expert.
> >
> > We don't have for the moment a real development on JPA but it is
> something
> > I'd like in a future version.
> >
> > Now in trunk, the store is split to few DAO. If you want to propose
> > something, I think it would be better to start from scratch on trunk by
> > rewriting the continuum-store module. Maybe some other parts will be
> > impacted.
> >
> > Emmanuel
> >
> > On Thu, Sep 11, 2008 at 4:53 PM, Ken Liu <ke...@gmail.com> wrote:
> >
> > > Hi,
> > >
> > > I am interested in contributing to the JPA refactoring effort as I have
> > JPA
> > > expertise. I saw that there are two jpa branches (continuum-jpa and
> > > continuum-jpa-evenisse). Are both of these branches under development?
> > Are
> > > they both considered to be candidates for merging into the trunk?
> > >
> > > Any background information on these would be appreciated.
> > >
> > > Thanks,
> > >
> > > Ken
> > >
> >
>
Re: which jpa branch is active?
Posted by Ken Liu <ke...@gmail.com>.
Thanks for the info.
I read an old email thread (from the 2.0 planning earlier this year)
discussing which JPA provider to use. Was there ever a consensus reached on
this?
I think Hibernate is probably the most commonly used JPA provider (I use it
in my workplace as well), but there was mention of TopLink Essentials.
Someone mentioned something about the Hibernate license (LGPL 2.1) not being
compatible with Apache licensing?
Ken
On Thu, Sep 11, 2008 at 11:28 AM, Emmanuel Venisse <
emmanuel.venisse@gmail.com> wrote:
> Both was "test" branches. If you want to look at one, I'd prefer you look
> at
> mine (continuum-jpa-evenisse) ;-)
> My branch was based on jpa annotations and the other one was done with sql
> in the code. I think annotations are better but I'm not a JPA expert.
>
> We don't have for the moment a real development on JPA but it is something
> I'd like in a future version.
>
> Now in trunk, the store is split to few DAO. If you want to propose
> something, I think it would be better to start from scratch on trunk by
> rewriting the continuum-store module. Maybe some other parts will be
> impacted.
>
> Emmanuel
>
> On Thu, Sep 11, 2008 at 4:53 PM, Ken Liu <ke...@gmail.com> wrote:
>
> > Hi,
> >
> > I am interested in contributing to the JPA refactoring effort as I have
> JPA
> > expertise. I saw that there are two jpa branches (continuum-jpa and
> > continuum-jpa-evenisse). Are both of these branches under development?
> Are
> > they both considered to be candidates for merging into the trunk?
> >
> > Any background information on these would be appreciated.
> >
> > Thanks,
> >
> > Ken
> >
>
Re: which jpa branch is active?
Posted by Emmanuel Venisse <em...@gmail.com>.
Both was "test" branches. If you want to look at one, I'd prefer you look at
mine (continuum-jpa-evenisse) ;-)
My branch was based on jpa annotations and the other one was done with sql
in the code. I think annotations are better but I'm not a JPA expert.
We don't have for the moment a real development on JPA but it is something
I'd like in a future version.
Now in trunk, the store is split to few DAO. If you want to propose
something, I think it would be better to start from scratch on trunk by
rewriting the continuum-store module. Maybe some other parts will be
impacted.
Emmanuel
On Thu, Sep 11, 2008 at 4:53 PM, Ken Liu <ke...@gmail.com> wrote:
> Hi,
>
> I am interested in contributing to the JPA refactoring effort as I have JPA
> expertise. I saw that there are two jpa branches (continuum-jpa and
> continuum-jpa-evenisse). Are both of these branches under development? Are
> they both considered to be candidates for merging into the trunk?
>
> Any background information on these would be appreciated.
>
> Thanks,
>
> Ken
>