You are viewing a plain text version of this content. The canonical link for it is here.
Posted to ojb-dev@db.apache.org by Martin Kalén <mk...@apache.org> on 2004/08/10 13:54:46 UTC
[PROPOSAL] (trivial) apply OJB135
Greetings,
issue OJB135 in Scarab notes that build.properties has what seems to be typos for the
paths in the "target" directory during the build process.
We have previously disregarded this issue since "it works" (and hence "don't touch" comes
to mind). :-) But something in my (sometimes somewhat pedantic) mind is always a bit
annoyed with the resulting path structure when building OJB. It's also a bit of a hassle
to set up IDE-integrated JUnit testing when target classes end up all over the place.
I can go ahead and apply a trivial patch to build.properties if no one has any objections
(e.g. there might be external tools dependent on the existing directory structure).
Index: build.properties
===================================================================
RCS file: /home/cvs/db-ojb/build.properties,v
retrieving revision 1.68
diff -r1.68 build.properties
105,108c105,108
< build.srctest = ${build.dir}/srctest
< build.srctools = ${build.dir}/srctools
< build.srcsamples = ${build.dir}/srcsamples
< build.srcjca = ${build.dir}/srcjca
---
> build.srctest = ${build.dir}/src/test
> build.srctools = ${build.dir}/src/tools
> build.srcsamples = ${build.dir}/src/samples
> build.srcjca = ${build.dir}/src/jca
110,113c110,113
< build.desttest = ${build.dir}/classestest
< build.desttools = ${build.dir}/classestools
< build.destsamples = ${build.dir}/classessamples
< build.destjca = ${build.dir}/classesjca
---
> build.desttest = ${build.dir}/classes/test
> build.desttools = ${build.dir}/classes/tools
> build.destsamples = ${build.dir}/classes/samples
> build.destjca = ${build.dir}/classes/jca
Regards,
Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org
Re: [PROPOSAL] (trivial) apply OJB135
Posted by Martin Kalén <mk...@apache.org>.
Jakob Braeuchi wrote:
> i found a small problem with the current structure of the classes
> directory.
> eclipse does not like nested output pathes. we needs another directory
> within classes for 'productive' output:
Applied the change as per your proposal - no problems with main build, tests, dist targets
or samples. Main classes now go into a "prod" subdir.
> btw the .classpath file is not in sync with build.properties.
Oops from me since I don't use Eclipse. Should be in sych now - please test!
Regards,
Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org
Re: [PROPOSAL] (trivial) apply OJB135
Posted by Jakob Braeuchi <jb...@gmx.ch>.
hi martin,
i found a small problem with the current structure of the classes directory.
eclipse does not like nested output pathes. we needs another directory within
classes for 'productive' output:
classes
prod
test
samples
btw the .classpath file is not in sync with build.properties.
jakob
Martin Kalén schrieb:
> Armin Waibel wrote:
>
>> I never do an objection ;-)
>> +1
>
>
> Good to see someone so positive. :-)
>
> Commited - should be transparent, but yell if anyone has problems with
> this. I also removed the now unused splash-target and an old
> property-file that GUMP always warns about.
>
> Martin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
> For additional commands, e-mail: ojb-dev-help@db.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org
Re: [PROPOSAL] (trivial) apply OJB135
Posted by Martin Kalén <mk...@apache.org>.
Armin Waibel wrote:
> I never do an objection ;-)
> +1
Good to see someone so positive. :-)
Commited - should be transparent, but yell if anyone has problems with this. I also
removed the now unused splash-target and an old property-file that GUMP always warns about.
Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org
Re: [PROPOSAL] (trivial) apply OJB135
Posted by Armin Waibel <ar...@apache.org>.
Hi Martin,
I never do an objection ;-)
+1
Armin
Martin Kalén wrote:
> Greetings,
> issue OJB135 in Scarab notes that build.properties has what seems to be
> typos for the paths in the "target" directory during the build process.
>
> We have previously disregarded this issue since "it works" (and hence
> "don't touch" comes to mind). :-) But something in my (sometimes
> somewhat pedantic) mind is always a bit annoyed with the resulting path
> structure when building OJB. It's also a bit of a hassle to set up
> IDE-integrated JUnit testing when target classes end up all over the place.
>
> I can go ahead and apply a trivial patch to build.properties if no one
> has any objections (e.g. there might be external tools dependent on the
> existing directory structure).
>
> Index: build.properties
> ===================================================================
> RCS file: /home/cvs/db-ojb/build.properties,v
> retrieving revision 1.68
> diff -r1.68 build.properties
> 105,108c105,108
> < build.srctest = ${build.dir}/srctest
> < build.srctools = ${build.dir}/srctools
> < build.srcsamples = ${build.dir}/srcsamples
> < build.srcjca = ${build.dir}/srcjca
> ---
> > build.srctest = ${build.dir}/src/test
> > build.srctools = ${build.dir}/src/tools
> > build.srcsamples = ${build.dir}/src/samples
> > build.srcjca = ${build.dir}/src/jca
> 110,113c110,113
> < build.desttest = ${build.dir}/classestest
> < build.desttools = ${build.dir}/classestools
> < build.destsamples = ${build.dir}/classessamples
> < build.destjca = ${build.dir}/classesjca
> ---
> > build.desttest = ${build.dir}/classes/test
> > build.desttools = ${build.dir}/classes/tools
> > build.destsamples = ${build.dir}/classes/samples
> > build.destjca = ${build.dir}/classes/jca
>
> Regards,
> Martin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
> For additional commands, e-mail: ojb-dev-help@db.apache.org
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org