You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "CurtHagenlocher (via GitHub)" <gi...@apache.org> on 2023/07/17 19:11:59 UTC

[GitHub] [arrow] CurtHagenlocher commented on a diff in pull request #36125: GH-34620: [C#] Support DateOnly and TimeOnly on .NET 6.0+

CurtHagenlocher commented on code in PR #36125:
URL: https://github.com/apache/arrow/pull/36125#discussion_r1265795333


##########
csharp/src/Apache.Arrow/Arrays/Time64Array.cs:
##########
@@ -24,17 +25,25 @@ namespace Apache.Arrow
     /// </summary>
     public class Time64Array : PrimitiveArray<long>
     {
+        private const long TicksPerMicrosecond = 1000;
+        private const long NanosecondsPerTick = 100;

Review Comment:
   No, you follow just fine; it's the code that's wrong :/.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org