You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Mahesh Bandal <ma...@gmail.com> on 2021/12/17 14:32:38 UTC
Review Request 73768: RANGER-3551: Analyze & optimize module permissions related API (Part-1)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73768/
-----------------------------------------------------------
Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-3551
https://issues.apache.org/jira/browse/RANGER-3551
Repository: ranger
Description
-------
Created new GET API "/permissionlist" to reduce response object size of the permission listing page. Introduced two new java classes VXModulePermission.java & VXModulePermissionList.java
With these changes, new API will return list of Modules which will have moduleId, moduleName, list of users & groups asssigned to that module.
Also, optimized code for GET API /permission/{id}
Updated testcases for updateXModuleDefPermission
Diffs
-----
security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 0eb582c8e
security-admin/src/main/java/org/apache/ranger/biz/XUserMgrBase.java 3ea44655d
security-admin/src/main/java/org/apache/ranger/db/XXGroupPermissionDao.java d63403985
security-admin/src/main/java/org/apache/ranger/db/XXUserPermissionDao.java cb6a7e5f3
security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 1f44703fd
security-admin/src/main/java/org/apache/ranger/service/AbstractBaseResourceService.java 1d038bf28
security-admin/src/main/java/org/apache/ranger/service/XGroupPermissionService.java da88e3efb
security-admin/src/main/java/org/apache/ranger/service/XModuleDefService.java 2d5e2f18b
security-admin/src/main/java/org/apache/ranger/service/XUserPermissionService.java 963a89407
security-admin/src/main/java/org/apache/ranger/view/VXModulePermission.java PRE-CREATION
security-admin/src/main/java/org/apache/ranger/view/VXModulePermissionList.java PRE-CREATION
security-admin/src/main/resources/META-INF/jpa_named_queries.xml c19ec495e
security-admin/src/main/webapp/scripts/collection_bases/VXModuleDefListBase.js 3ebee8f9a
security-admin/src/main/webapp/scripts/utils/XAUtils.js bddf53dd9
security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js cd4641fd0
security-admin/src/test/java/org/apache/ranger/biz/TestXUserMgr.java 945bba48d
security-admin/src/test/java/org/apache/ranger/service/TestXGroupPermissionService.java f88b23aca
Diff: https://reviews.apache.org/r/73768/diff/1/
Testing
-------
1. Ranger maven build successful -> mvn clean compile verify test install
2. Ranger Setup & install successful
3. Performed sanity testing.
4. For 100,000 users "/permissionlist" api takes 800~1000 millisecods to respond with object size= 5Mb. On Ranger GUI it takes 17 seconds to process complete request. (i.e Total time taken by API = 17 seconds)
Thanks,
Mahesh Bandal