[GitHub] sandeep-krishnamurthy commented on a change in pull request #13742: Reorder module import orders for dist-kvstore

[GitBox <gi...@apache.org>]

sandeep-krishnamurthy commented on a change in pull request #13742: Reorder module import orders for dist-kvstore
URL: https://github.com/apache/incubator-mxnet/pull/13742#discussion_r244500800
 
 

 ##########
 File path: python/mxnet/__init__.py
 ##########
 @@ -82,3 +81,7 @@
 from . import gluon
 
 __version__ = base.__version__
+
 
 Review comment:
   Wow, tricky issue. Nice fix. I think add more details as code comment taking from your PR description will be useful. 
   `Otherwise this may result in error when unpickling custom LR scheduler/optimizers. For example, the LRScheduler in gluoncv https://github.com/dmlc/gluon-cv/blob/master/gluoncv/utils/lr_scheduler.py#L8 depends on a specific version of MXNet, and checks the __version__ attr of MXNet, which is not set on kvstore server due to the fact that kvstore-server module is imported before the __version__ attr is set.`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services